- Issue created by @rroose
- Assigned to sourav_paul
- Merge request !8673Issue #3458220: Date list labels are not visible above select field creating bad UX → (Open) created by sourav_paul
- Issue was unassigned.
- Status changed to Needs review
6 months ago 11:02am 5 July 2024 - Status changed to Needs work
5 months ago 1:35pm 10 July 2024 - 🇺🇸United States smustgrave
Is this reproducible without the contrib module?
MR should be against 11.x not 10.3.x
Also if reproducible in core will probably need a test case
- 🇳🇱Netherlands rroose
How to reproduce with core:
- Make sure you are logged into Drupal as user with sufficient permissions
- Enable the 'Contact' module
- Navigate to /admin/structure/contact and 'Add contact form'
- Fill in a label and recipients (can be anything) and click 'Save'
- Click on the error next to edit below operations of the newly created form and select 'Manage Fields'
- Click 'Create new field'
- Select 'Date and time' and click 'Continue'
- Fill in the label, select 'Date' and click 'Continue'
- Leave settings as is and click 'Save settings'
- Go to 'Manage form display'
- Click on the select option 'Date and time' of the newly created date field, choose 'Select list' and click on 'Save'
- Click on view to see the date field in the Drupal front-end
- Status changed to Active
5 months ago 8:03am 11 July 2024 - 🇮🇳India amanbtr72
amanmansuri72 → made their first commit to this issue’s fork.
- Status changed to Needs review
5 months ago 10:12am 11 July 2024 - 🇮🇳India amanbtr72
As per the "Problem/Motivation," I have resolved the issues as suggested for the 10.3.x version Merge request !8739 created for the same.
Kindly review
Thanks
- Status changed to RTBC
5 months ago 10:41am 11 July 2024 - 🇮🇳India chandansha
I have tested MR 8739. Now label looking good.
i moved it to RTBC.
Thanks!! - Status changed to Fixed
5 months ago 3:20am 17 July 2024 - 🇬🇧United Kingdom catch
I checked git blame to see where the invisible was added, and it was in the original 2014 commit of this code, which in turn came from a much older contrib module - so I think this was a decision taken a very long time ago that it would be hard to trace back.
Given the fix here is just removing one line of extraneous code, I don't think this needs test coverage, we could test that the labels are there, but that's just how form behaviour works if you don't set
#title_display => 'invisible'.Committed/pushed to 11.x and cherry-picked to 10.4.x, thanks! This is a small change to the form structure so I don't think it should go in a patch release, but it's also so small that a CR/release note feels extraneous.
Automatically closed - issue fixed for 2 weeks with no activity.