Date list labels are not visible above select field creating bad UX

Is this reproducible without the contrib module?

MR should be against 11.x not 10.3.x

Also if reproducible in core will probably need a test case

How to reproduce with core:

1. Make sure you are logged into Drupal as user with sufficient permissions
2. Enable the 'Contact' module
3. Navigate to /admin/structure/contact and 'Add contact form'
4. Fill in a label and recipients (can be anything) and click 'Save'
5. Click on the error next to edit below operations of the newly created form and select 'Manage Fields'
6. Click 'Create new field'
7. Select 'Date and time' and click 'Continue'
8. Fill in the label, select 'Date' and click 'Continue'
9. Leave settings as is and click 'Save settings'
10. Go to 'Manage form display'
11. Click on the select option 'Date and time' of the newly created date field, choose 'Select list' and click on 'Save'
12. Click on view to see the date field in the Drupal front-end

As per the "Problem/Motivation," I have resolved the issues as suggested for the 10.3.x version Merge request !8739 created for the same.

Kindly review

Thanks

I have tested MR 8739. Now label looking good.
i moved it to RTBC.
Thanks!!

I checked git blame to see where the invisible was added, and it was in the original 2014 commit of this code, which in turn came from a much older contrib module - so I think this was a decision taken a very long time ago that it would be hard to trace back.

Given the fix here is just removing one line of extraneous code, I don't think this needs test coverage, we could test that the labels are there, but that's just how form behaviour works if you don't set #title_display => 'invisible'.

Committed/pushed to 11.x and cherry-picked to 10.4.x, thanks! This is a small change to the form structure so I don't think it should go in a patch release, but it's also so small that a CR/release note feels extraneous.

Automatically closed - issue fixed for 2 weeks with no activity.