The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India Nikhil_110
Attached patch against Drupal 10.1.x
Patch #46 is not applied for Drupal 10 so Inter-diff file is not added.
Checking patch core/modules/system/src/Form/ModulesListForm.php...
Hunk #1 succeeded at 21 (offset 1 line).
Hunk #2 succeeded at 143 (offset 3 lines).
Hunk #3 succeeded at 208 (offset 8 lines).
error: while searching for:
$row['#requires'] = [];
$row['#required_by'] = [];$row['name']['#markup'] = $module->info['name'];
$row['description']['#markup'] = $this->t($module->info['description']);
$row['version']['#markup'] = $module->info['version'];// Generate link for module's help page. Assume that if a hook_help()
// implementation exists then the module provides an overview page, rathererror: patch failed: core/modules/system/src/Form/ModulesListForm.php:247
error: core/modules/system/src/Form/ModulesListForm.php: patch does not apply
Checking patch core/modules/system/system.admin.inc... - last update
8 months ago 29,506 pass, 62 fail - First commit to issue fork.
- Merge request !7436Issue #637538 : Module and theme names are not filtered on output. → (Open) created by Bhanu951
- Status changed to Needs review
2 months ago 6:54am 11 April 2024 - 🇮🇳India Bhanu951
Came from http://www.madirish.net/555
Re-Rolled patch from #46 against 11.x head.
- Status changed to Needs work
2 months ago 7:05am 11 April 2024 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- First commit to issue fork.
Addressed the test failures & pipeline passed
Please review , moved NR
- Status changed to Needs review
3 days ago 1:33pm 13 June 2024