- ๐ณ๐ฟNew Zealand janpongos
another tag that gets strips out that's good to be whitelisted is "drupal-media" when using core's ckeditor5.
- ๐จ๐ฆCanada AlexGreen
Couldnโt decide if it made more sense to throw an exception in
\Drupal\Core\Form\FormSubmitter::executeSubmitHandlers
or simply return early.If we throw an exception, then anything calling
FormBuilder::executeSubmitHandlers
will have to catch the exception, and if nothing catches it then the user will get a WSOD (i.e.: possibly from an expired form token because they left the page open in their browser for too long) which seems like a bad user experienceIf we return early, then anything calling
FormBuilder::executeSubmitHandlers
doesnโt really know that something went wrong (i.e.: the node didn't save)P.S. latest commit didn't include tests, was looking for feedback. (Test fails seem to be unrelated)
- ๐ฎ๐ณIndia amanmansuri72
Re-viewed the changes in the recent MR, Looks good.
Moving to RTBC+1
To maintain consistency some minor change done
Please review, moving NR
- ๐ฎ๐ณIndia Hetal.Solanki
@all
I have reviewed MR !7436. It's looks good.
Moving to RTBC.
Thank you!! Addressed test failures & pipeline passed successfully.
Please review, moving NR.
The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
Rebased MR with latest code & applied the left suggestion as well.
Please review, moving NR.
The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.