Istanbul
Account created on 3 January 2008, over 17 years ago
#

Merge Requests

More

Recent comments

🇹🇷Turkey orkut murat yılmaz Istanbul

Also there is another project, called as minikanban .

🇹🇷Turkey orkut murat yılmaz Istanbul

@jeremylichtman I've just updated that issue 💬 Custom group entity Needs work 's tags.

🇹🇷Turkey orkut murat yılmaz Istanbul

sorry for tagging the wrong version first.

🇹🇷Turkey orkut murat yılmaz Istanbul

Maybe this issue would be helpful for this motivation.

🇹🇷Turkey orkut murat yılmaz Istanbul

sorry, if I ask a silly question, after the resolving of this issue, can we use this module with D11(.2.x), Workflow 2.1(.x) and ECA 3(.x) too?

🇹🇷Turkey orkut murat yılmaz Istanbul

I'm changing the status now:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I do agree with @liam morland

🇹🇷Turkey orkut murat yılmaz Istanbul

Can you also release a beta2 version with the resolved issues?

🇹🇷Turkey orkut murat yılmaz Istanbul

we need to change it like "^2.1".

🇹🇷Turkey orkut murat yılmaz Istanbul

Also, after applying the patch, I've scanned it with the upgrade status module. The result is below:

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Markdown
Scanned on Thu, 08/28/2025 - 12:14.

9 warnings found.

web/modules/contrib/markdown/src/Plugin/Markdown/CommonMark/CommonMark.php:
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------+
| status         | line | message                                                                                                                           |
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------+
| Check
manually | 183  | Call to deprecated method convertToHtml() of class
League\CommonMark\MarkdownConverter: since 2.2; use {@link
convert()} instead
 |
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/markdown/src/Plugin/Markdown/InstallablePluginBase.php:
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status         | line | message                                                                                                                                                                                                                                                               |
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Check
manually | 95   | Call to method getPluginCollections() of deprecated
interface
Drupal\markdown\BcSupport\ObjectWithPluginCollectionInterfac
e. Deprecated in markdown:8.x-2.0 and is removed from
markdown:3.0.0. Use
Drupal\Core\Plugin\ObjectWithPluginCollectionInterface
instead.
 |
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/markdown/src/PluginManager/AllowedHtmlManager.php:
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status         | line | message                                                                                                                                                                                                               |
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Check
manually | 454  | Access to deprecated property $requiresFilter of class
Drupal\markdown\Annotation\MarkdownAllowedHtml. Deprecated
in markdown:8.x-2.0 and is removed from markdown:3.0.0. Use
the "requirements" properties instead.
 |
| Check
manually | 460  | Access to deprecated property $requiresFilter of class
Drupal\markdown\Annotation\MarkdownAllowedHtml. Deprecated
in markdown:8.x-2.0 and is removed from markdown:3.0.0. Use
the "requirements" properties instead.
 |
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/markdown/src/PluginManager/InstallablePluginManager.php:
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status         | line | message                                                                                                                                                                                                               |
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Check
manually | 214  | Call to method setContainer() of deprecated interface
Symfony\Component\DependencyInjection\ContainerAwareInterfac
e: since Symfony 6.4, use dependency injection instead
                                            |
| Check
manually | 478  | Call to deprecated method convertInstalledToLibraries() of
class
Drupal\markdown\PluginManager\InstallablePluginManager.
Deprecated in markdown:8.x-2.0 and is removed from
markdown:3.0.0. There is no replacement.
 |
| Check
manually | 561  | Access to deprecated property $versionConstraint of class
Drupal\markdown\Annotation\InstallableLibrary. Deprecated in
markdown:8.x-2.0 and is removed from markdown:3.0.0. Use the
"requirements" property instead.
 |
| Check
manually | 565  | Access to deprecated property $versionConstraint of class
Drupal\markdown\Annotation\InstallableLibrary. Deprecated in
markdown:8.x-2.0 and is removed from markdown:3.0.0. Use the
"requirements" property instead.
 |
+----------------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/markdown/markdown.info.yml:
+----------------+------+----------------------------------------------------------------------------------------------------------------------------------------------------+
| status         | line | message                                                                                                                                            |
+----------------+------+----------------------------------------------------------------------------------------------------------------------------------------------------+
| Check
manually | 5    | Value of core_version_requirement: ^9.2 | ^10 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
 |
+----------------+------+----------------------------------------------------------------------------------------------------------------------------------------------------+
🇹🇷Turkey orkut murat yılmaz Istanbul

I've checked MR !37 and it says: "Test summary: 350 failed, 425 total tests"

Do we need to refactor it?

🇹🇷Turkey orkut murat yılmaz Istanbul

Can you add this to the next beta release please?

🇹🇷Turkey orkut murat yılmaz Istanbul

I've just tested the patch with upgrade status module:)

🇹🇷Turkey orkut murat yılmaz Istanbul

Can you add this into the new release please?

🇹🇷Turkey orkut murat yılmaz Istanbul

@danrod, thanks for the commit:)

🇹🇷Turkey orkut murat yılmaz Istanbul

Thank you @mglaman :)

🇹🇷Turkey orkut murat yılmaz Istanbul

Sorry for the wrong module project. I'm correcting the name and reference too.

🇹🇷Turkey orkut murat yılmaz Istanbul

any chance for the merge?

🇹🇷Turkey orkut murat yılmaz Istanbul

can you add this to 5.0.x-dev version too?

🇹🇷Turkey orkut murat yılmaz Istanbul

I've done the patching, pushing and merging too. Can you test the latest dev release?

🇹🇷Turkey orkut murat yılmaz Istanbul

thanks to @gaurav.goyal, I can create new releases and merge the requests too.

now, this issue 🐛 checkAccess() throws an exception "Invalid specifier 'type'" with non node entities Needs review is fixed in new 3.0.x-dev release.

if this one 📌 \Drupal calls should be avoided in classes, use dependency injection instead Active is refactored for the same release, we can go back to d11 compatibility issue as well.

@jdvc, @pearls, @marvs5 can you check the latest release?

🇹🇷Turkey orkut murat yılmaz Istanbul

@thanos ntelis, can you refactor your code for the latest 3.0.x-dev version please? Sorry for extra work.

🇹🇷Turkey orkut murat yılmaz Istanbul

@b.khouy, thanks for your contributions and efforts:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I've just started following that issue as well:)

🇹🇷Turkey orkut murat yılmaz Istanbul

@alex.bukach can we test your commit? if so, can you change the status of the issue as "Needs review"?

🇹🇷Turkey orkut murat yılmaz Istanbul

@sandeep_jangra thanks for adding me as the co-maintainer of this project.

🇹🇷Turkey orkut murat yılmaz Istanbul

I've installed 1.1.x-dev version with @prudloff's patch and it is working:)

🇹🇷Turkey orkut murat yılmaz Istanbul

Is it okay to create a new release now? Maybe a beta one?

🇹🇷Turkey orkut murat yılmaz Istanbul

@greg boggs, are you going to release a new version, including this fix?

🇹🇷Turkey orkut murat yılmaz Istanbul

@b.khouy, thanks for fixing:)

Are you going to release a new version?

🇹🇷Turkey orkut murat yılmaz Istanbul

Can you refactor the patch for 10.3.x?

🇹🇷Turkey orkut murat yılmaz Istanbul

@sanduhrs, thank you:)

I'm changing the issue's status as fixed.

🇹🇷Turkey orkut murat yılmaz Istanbul

I've tested it with the upgrade status module and it works. Can someone review it too?

🇹🇷Turkey orkut murat yılmaz Istanbul

@robert castelo thank you:)

🇹🇷Turkey orkut murat yılmaz Istanbul

@gaurav.kapoor, thank you. I've just sent 2 messages to @sandeep_jangra about this issue.

🇹🇷Turkey orkut murat yılmaz Istanbul

When are you going to release a D11 version?

🇹🇷Turkey orkut murat yılmaz Istanbul

Maybe we should refactor the module for D11 too?

🇹🇷Turkey orkut murat yılmaz Istanbul

@bobburns, have you tested the latest commits on 2.0.0-alpha0?

🇹🇷Turkey orkut murat yılmaz Istanbul

I'm changing the issue's title and status too.

🇹🇷Turkey orkut murat yılmaz Istanbul

Can we migrate this issue to drush project?

🇹🇷Turkey orkut murat yılmaz Istanbul

Hi everyone,

I would like to inform you that I would be happy to act as co-maintainer on the project if @gaurav.kapoor approves.

I wish you all a great week.

🇹🇷Turkey orkut murat yılmaz Istanbul

@pearls, I do agree with you. Should I contact one of the maintainers?

🇹🇷Turkey orkut murat yılmaz Istanbul

I can also confirm that too. Thank you @benjifisher :)

🇹🇷Turkey orkut murat yılmaz Istanbul

Sorry, I forgot saying that, I've applied the MR as a patch and scanned entity limit with upgrade status module:

No problems found

🇹🇷Turkey orkut murat yılmaz Istanbul

@pearls, can you review the @jdvc's MR too?

🇹🇷Turkey orkut murat yılmaz Istanbul

I've just tested the latest version and it looks stable.

Thanks for all the efforts:)

🇹🇷Turkey orkut murat yılmaz Istanbul

any chance for merge?

🇹🇷Turkey orkut murat yılmaz Istanbul

@rakesh.gectcr, thanks for the patch. I can confirm that, patch #49 can fix this issue too.

🇹🇷Turkey orkut murat yılmaz Istanbul

It will be fixed, if the MR of this issue 💬 Please develop the module for Drupal 10 Active is accepted.

🇹🇷Turkey orkut murat yılmaz Istanbul

@vinodhini.e, can you also test these issues too?

https://www.drupal.org/project/optional_email/issues/3530927 Disable email field on user registration form, if it is set as optional Active

https://www.drupal.org/project/optional_email/issues/3443982 💬 Please develop the module for Drupal 10 Active

if they work for you too, please change the status as RTBC for both of them:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I've just re-scanned the module with the patch applied, using upgrade status module and there is an error, preventing the upgrade, which I paste below:

file: web/modules/contrib/faq/faq.install

line: 59

error: Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

I'm changing the issue's status as "needs work".

Production build 0.71.5 2024