@apaderno, you're right. Thanks for correcting.
If I change the content_sync.info.yml
as below, upgrade status report says that, it is compatible with D11 too.
name: 'Content Sync'
type: module
description: 'Allows users to import/export content using YAML files.'
package: Custom
core_version_requirement: ^9.4 || ^10.0 || ^11
configure: content.sync
dependencies:
- drupal:serialization
# Information added by Drupal.org packaging script on 2022-12-23
version: '3.0.0-beta1+27-dev'
project: 'content_sync'
datestamp: 1671838601
Please publish the dev release with this changes:) I'm excited to put this in to my CI/CD flows:)
I've downloaded the 3.0.x-dev release, applied @mjgruta's latest MR (as a patch) and changed the content_sync.info.yml file like below:
name: 'Content Sync'
type: module
description: 'Allows users to import/export content using YAML files.'
package: Custom
core_version_requirement: ^9.4 || ^10.0
configure: content.sync
dependencies:
- drupal:serialization
# Information added by Drupal.org packaging script on 2022-12-23
version: '3.0.0-beta1+27-dev'
project: 'content_sync'
datestamp: 1671838601
And activated the module.
It works nice with Drupal 10.3.0-rc1, PHP 8.3.8 and PostgreSQL 16.1 :
Thank you for everything.
@bojanz, I meant 2.0.1 (or 2.0.2) as stable branch. Thanks for your fast response:)
from now on, I'll choose a wiser issue title like this:) thanks for your warning @ressa
@itamair, thanks for the release:)
I've added @balbeeryadav's patch to my composer.json
file like this:
"enable-patching": true,
"patches": {
"drupal/facets": {
"Facets 3.0.0-beta2 release?": "https://www.drupal.org/files/issues/2024-06-01/beta-dev-diff-3394709-6.patch"
}
}
But we need to commit all RTBC issues to the dev branch and then merge everything with the Beta2 release as well.
@W01F, should we include those differences as features to db_maintenance?
Orkut Murat Yılmaz → created an issue.
Sorry, I've missed the other one 📌 Initial Drupal 11 compatibility Fixed . Closing this duplicate issue.
Orkut Murat Yılmaz → created an issue.
It works locally:)
Any chance for merge?
Any chance for merge?
Any chance for merge?
We have some good news:
I'm adding this one as a child issue to the roadmap.
I assume that it would be better to support D11 with new version.
I've tested locally and it worked.
Orkut Murat Yılmaz → made their first commit to this issue’s fork.
I've tested it locally. @ressa, thanks for the D11 compatibility:)
Orkut Murat Yılmaz → created an issue.
I've tested @gg24's MR locally and it works. Thanks for refactoring the code and modernizing the README file.
I've tested the changes by manually editing the info file.
Can you merge it with the stable branch too?
@bojanz, can you commit this to the stable branch too?
Thanks for the merge:)
I'm changing the status as RTBC. Thanks for the patch.
Orkut Murat Yılmaz → created an issue.
@reswild, can you share your notes of the update you've done on weekend with us? It would be great, if you can:)
I'm also adding my temporary fix as a patch here, in order to deal with my composer.json file.
Orkut Murat Yılmaz → created an issue.
hello, any updates on this?
It passes the local test for Upgrade Status module.
Orkut Murat Yılmaz → created an issue.
@ressa, thanks for correcting, I'm adding your comment to that post too:)
After switching to DDEV, I published a little guide for installing Drupal 10 with PostGIS on DDEV. Since then, my experience is better, if I compare with lando and docker4drupal.
I'm guessing the official response to this feature request will be "no." Considering rudy.barret's comment on the other issue → . We may need to think for other alternatives.
Any updates on this?
@pobster, thank you for your kind and enlightening comment:)
Hello and thanks for your efforts.
When I activate the module after applying the patch file, I receive the error message below:
Error: Class "Symfony\Component\EventDispatcher\Event" not found in include() (line 11 of /var/www/html/web/modules/contrib/web_page_archive/src/Event/CaptureJobCompleteEvent.php).
#0 /var/www/html/vendor/composer/ClassLoader.php(576): include()
#1 /var/www/html/vendor/composer/ClassLoader.php(427): Composer\Autoload\{closure}('/var/www/html/w...')
#2 /var/www/html/web/modules/contrib/web_page_archive/src/EventSubscriber/WebPageArchiveEventSubscriber.php(26): Composer\Autoload\ClassLoader->loadClass('Drupal\\web_page...')
#3 /var/www/html/web/core/lib/Drupal/Core/DependencyInjection/Compiler/RegisterEventSubscribersPass.php(37): Drupal\web_page_archive\EventSubscriber\WebPageArchiveEventSubscriber::getSubscribedEvents()
#4 /var/www/html/vendor/symfony/dependency-injection/Compiler/Compiler.php(80): Drupal\Core\DependencyInjection\Compiler\RegisterEventSubscribersPass->process(Object(Drupal\Core\DependencyInjection\ContainerBuilder))
#5 /var/www/html/vendor/symfony/dependency-injection/ContainerBuilder.php(767): Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object(Drupal\Core\DependencyInjection\ContainerBuilder))
#6 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(1330): Symfony\Component\DependencyInjection\ContainerBuilder->compile()
#7 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(934): Drupal\Core\DrupalKernel->compileContainer()
#8 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(816): Drupal\Core\DrupalKernel->initializeContainer()
#9 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php(615): Drupal\Core\DrupalKernel->updateModules(Array, Array)
#10 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php(251): Drupal\Core\Extension\ModuleInstaller->updateKernel(Array)
#11 /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(83): Drupal\Core\Extension\ModuleInstaller->install(Array, true)
#12 /var/www/html/web/core/modules/system/src/Form/ModulesListForm.php(502): Drupal\Core\ProxyClass\Extension\ModuleInstaller->install(Array)
#13 [internal function]: Drupal\system\Form\ModulesListForm->submitForm(Array, Object(Drupal\Core\Form\FormState))
#14 /var/www/html/web/core/lib/Drupal/Core/Form/FormSubmitter.php(129): call_user_func_array(Array, Array)
#15 /var/www/html/web/core/lib/Drupal/Core/Form/FormSubmitter.php(67): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object(Drupal\Core\Form\FormState))
#16 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(597): Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object(Drupal\Core\Form\FormState))
#17 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm('system_modules', Array, Object(Drupal\Core\Form\FormState))
#18 /var/www/html/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\system\Form\ModulesListForm), Object(Drupal\Core\Form\FormState))
#19 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch))
#20 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#21 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#22 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#23 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#24 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#25 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#26 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#28 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#29 /var/www/html/web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#30 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#31 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#32 /var/www/html/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#33 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#34 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#35 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#36 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#37 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#38 /var/www/html/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#39 {main}
How can we fix it?
Best,
Orkut
It would be nice to have this feature on the beta version too:)
Can you also add these dependencies to the 2.0.0-beta version too?
Orkut Murat Yılmaz → created an issue.
Maybe we can use Group 3.x in dev version, as suggested by Finn Lewis → .
Like @Finn Lewis said, Group 3.x would be the best option.
I strongly agree with @liquidcms, this module has a different purpose.
Any updates on merge?
Any updates on this?
I strongly do agree with @jcandan. We may go faster with a dev release.
Maybe @colan can fix it while merging.
@davidiio thanks for your refactored patch. I've tried it and it works.
Can you also create a merge request too?
Drupal Version: 10.2.2
VEFL: 8.x-3.1
BEF: 6.0.3
DB: PostgreSQL 15.6
Patch #2 works for me as well:)
Any chance for merge?
Patch #35 works. The module works with D10 now. Thank you @Tobias März:)
@Tobias März, your patch fails, when try to apply it.
patch -p1 < content_sync_d10_compatiblity.patch
The next patch would create the file LICENSE.txt,
which already exists! Assume -R? [n] ^C
rm LICENSE.txt
patch -p1 < content_sync_d10_compatiblity.patch
patching file LICENSE.txt
patching file composer.json
patching file content_sync.info.yml
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file content_sync.info.yml.rej
patching file content_sync.libraries.yml
Hunk #1 FAILED at 10.
Hunk #2 succeeded at 23 (offset 1 line).
1 out of 2 hunks FAILED -- saving rejects to file content_sync.libraries.yml.rej
patching file content_sync.module
Reversed (or previously applied) patch detected! Assume -R? [n] ^C
I've just checked your documentation and it looks satisfying. Thank you:)
This weekend I'll have some more time and I'll publish the first release I guess. We may start planning this feature next week. Thanks for reminding:)
@yogeshmpawar, thanks for the new release:)
any chance for merge?
Orkut Murat Yılmaz → created an issue.
Thanks for the merge with the stable branch:)
Can you add this one to the module description too?
When we install iyzipay, it installs Encryption module → , because it's a dependency. After the installation, it starts a conflict between Encrypt → and Encryption modules.
Encrypt module is being used by the variety of modules, especially in Drupal 10. TFA 2.0.x → module uses it as a dependency.
I've examined the code of the iyzipay module and I've noticed that the module uses Encryption as service:
On the 182nd line of src/Plugin/Commerce/PaymentGateway/IyzipayOnsite.php, it is defined as a variable:
$encryption_service = \Drupal::service('encryption');
Also, on the 26th line of src/Plugin/Commerce/PaymentMethodType/FullCreditCard.php too.
The modules use Encrypt (instead of Encryption) calls the Encrypt via api like:
use Drupal\encrypt\EncryptionProfileInterface;
use Drupal\encrypt\EncryptServiceInterface;
use Drupal\encrypt\Entity\EncryptionProfile;
Adding Encrypt functionality will be so nice for more advanced security options to iyzico module.
@yogeshmpawar thanks for the new release. Can you also add @maxilein's suggestion to the module page too?
@yogeshmpawar thanks for the new release.
@jmauricio thanks for your patch. I've just checked the code and it looks fine. I'm going to test it in a day or two.
@neelam_wadhwani have you checked lando's postgres config?
Also, second patch worked for other issue too.
Any chance for merge?
The first patch on #3 works for me too. My environment is:
PHP 8.1.26
PostgreSQL 16.1
Drupal 10.2.2
Orkut Murat Yılmaz → created an issue.
@bkomel, thanks for the MR too:)
@bkomel, thanks for your patch. it works nice:)
can you create a merge request too?
@bkomel, sorry for not providing details about the error message.
I've just tried it on a local DDEV environment and I've faced the same error on the browser console. Then, I've typed "ddev logs
" on my terminal. The last two lines of the output is:
2024/01/08 21:08:00 [warn] 2150#2150: *449 an upstream response is buffered to a temporary file /var/cache/nginx/fastcgi_temp/1/00/0000000001 while reading upstream, client: 192.168.64.5, server: , request: "GET /sites/default/files/js/js_8iTNnVNQuE2Vb3THC5OgFDYqXNxyPxvWgoqP1A9F6WQ.js?scope=footer&delta=0&language=en&theme=gin&include=eJx9kVmShCAMhi-EcoY5iRUxaqaROAGssU_fccEpq6vngSX5vywEx32PaDvJM_ja7ZZxHBL-pgz-TyieylN4REUEbWCZwNNTIzwI28Fzq0RMq0KDGShYXQd7JgKXaME9SdEbcA5DusyRhZ5aD3yTmH0LckkU6OBiIvdYb5kdew9zxMNJ2q8EdX__ZJS17rXVGz6BGylgFWBCE7VmcjkVsdjmbMCWRnJEKdB2r0knE02HC-qstr0qaOK8xWX5f5wFh27SB57WfsZSdS9yBy4pif7XZ6keeUHZhhHeHlNjdDDj1xZsWhqamWa05fICd8fQjw HTTP/1.1", upstream: "fastcgi://unix:/run/php-fpm.sock:", host: "drupalstarter.ddev.site", referrer: "https://drupalstarter.ddev.site/admin/config/content/entity_browser/add"
2024/01/08 21:08:24 [info] 2163#2163: *464 client closed connection while waiting for request, client: 192.168.64.5, server: 0.0.0.0:80
[08-Jan-2024 21:08:29] WARNING: [pool www] child 3545 said into stderr: "NOTICE: PHP message: Uncaught PHP Exception TypeError: "Drupal\media_pixabay\Plugin\EntityBrowser\Widget\Pixabay::__construct(): Argument #10 ($logger) must be of type Drupal\Core\Logger\LoggerChannelFactory, Drupal\redirect_404\Render\Redirect404LogSuppressor given, called in /var/www/html/web/modules/contrib/media_pixabay/src/Plugin/EntityBrowser/Widget/Pixabay.php on line 197" at /var/www/html/web/modules/contrib/media_pixabay/src/Plugin/EntityBrowser/Widget/Pixabay.php line 147"
2024/01/08 21:08:29 [error] 2161#2161: *466 FastCGI sent in stderr: "PHP message: Uncaught PHP Exception TypeError: "Drupal\media_pixabay\Plugin\EntityBrowser\Widget\Pixabay::__construct(): Argument #10 ($logger) must be of type Drupal\Core\Logger\LoggerChannelFactory, Drupal\redirect_404\Render\Redirect404LogSuppressor given, called in /var/www/html/web/modules/contrib/media_pixabay/src/Plugin/EntityBrowser/Widget/Pixabay.php on line 197" at /var/www/html/web/modules/contrib/media_pixabay/src/Plugin/EntityBrowser/Widget/Pixabay.php line 147" while reading response header from upstream, client: 192.168.64.5, server: , request: "POST /admin/config/content/entity_browser/pixabay/widgets?ajax_form=1&_wrapper_format=drupal_ajax HTTP/1.1", upstream: "fastcgi://unix:/run/php-fpm.sock:", host: "drupalstarter.ddev.site", referrer: "https://drupalstarter.ddev.site/admin/config/content/entity_browser/pixabay/widgets"
yes, exactly. sorry for miscategorizing.
I've re-installed the boost module with applying the patch on this issue 🐛 PHP Fatal Error after drush cex RTBC . This time it worked perfect.
My configuration is:
Drupal 10.2.0
Boost 8.x-1.x-dev (with the patch I've mentioned above)
Web Server: nginx/1.24.0
DB: PostgreSQL 15.5
PHP: 8.1.27
Thank you @C-Logemann, for reminding and for your efforts too. I guess that we can close this issue now.
@C-Logemann, yes it is fixed with that patch.
Please check this comment 🐛 'ipless' is not a supported key. Active .
Orkut Murat Yılmaz → created an issue.
@Mehrdad201 and @apaderno, thank you both. I'm understanding the concept of Drupal configuration object better now.
@apaderno, thanks for detailed explanation.
@Damien Laguerre, can you add a configuration object to this module?
@yan Thanks, I've used your solution here 🐛 'ipless' is not a supported key. Active too.
@RgnYLDZ, can you try these 2 drush commands? They can be helpful, as mentioned here 💬 Aggregation not working css and js cache directories not being created Postponed: needs info :
drush config:delete system.performance stale_file_threshold
drush config:delete system.performance ipless
@planceleur, sorry for the late reply.
Yes, I was enlightened like you did and solved my problem with changing the settings.ddev.php file parameters. Thank you for making me feel not alone:)
I've just found a related issue with a working patch 🐛 Minify html breaks pages in Drupal 10.2 Active .
@Mehrdad201 which Drupal 10 version have you installed? I've noticed a similar issue 🐛 'ipless' is not a supported key. Active happened after 10.2 update.
Orkut Murat Yılmaz → created an issue.
Orkut Murat Yılmaz → created an issue.
Sorry to bother, but can we merge this one too? :)
I've decided to complete some of these documentation tasks and I'll share the updates ASAP.
@itamair, thanks for asking. For my perspective, option 2 would be better, but I can't be sure about other users/developers mileage.
@ressa, thanks for documentation task list update and your example too:)
it's a huge leap forward! thanks for adding the MapLibre support:)
Any updates on this?
I've checked it after updating to Drupal 10.2.0 and the error is still there:
Uncaught
Object { message: "\nAn AJAX HTTP error occurred.\nHTTP Result Code: 200\nDebugging information follows.\nPath: /en/admin/config/content/entity_browser/pixabay/widgets?ajax_form=1\nStatusText: parsererror\nResponseText: ", name: "AjaxError", stack: "@https://drupal.localhost/core/misc/ajax.js?v=10.2.0:196:32\n@https://drupal.localhost/core/misc/ajax.js?v=10.2.0:1915:3\n" }
message: "\nAn AJAX HTTP error occurred.\nHTTP Result Code: 200\nDebugging information follows.\nPath: /en/admin/config/content/entity_browser/pixabay/widgets?ajax_form=1\nStatusText: parsererror\nResponseText: "
name: "AjaxError"
stack: "@https://drupal.localhost/core/misc/ajax.js?v=10.2.0:196:32\n@https://drupal.localhost/core/misc/ajax.js?v=10.2.0:1915:3\n"
<prototype>: Error:
columnNumber: 32
constructor: function AjaxError(xmlhttp, uri, customMessage)
fileName: "https://drupal.localhost/core/misc/ajax.js?v=10.2.0"
lineNumber: 196
stack: "@https://drupal.localhost/core/misc/ajax.js?v=10.2.0:196:32\n@https://drupal.localhost/core/misc/ajax.js?v=10.2.0:1915:3\n"
<prototype>: Error.prototype { stack: "", … }