Istanbul
Account created on 3 January 2008, over 17 years ago
#

Merge Requests

More

Recent comments

🇹🇷Turkey orkut murat yılmaz Istanbul

I've installed 1.1.x-dev version with @prudloff's patch and it is working:)

🇹🇷Turkey orkut murat yılmaz Istanbul

Is it okay to create a new release now? Maybe a beta one?

🇹🇷Turkey orkut murat yılmaz Istanbul

@greg boggs, are you going to release a new version, including this fix?

🇹🇷Turkey orkut murat yılmaz Istanbul

@b.khouy, thanks for fixing:)

Are you going to release a new version?

🇹🇷Turkey orkut murat yılmaz Istanbul

Can you refactor the patch for 10.3.x?

🇹🇷Turkey orkut murat yılmaz Istanbul

@sanduhrs, thank you:)

I'm changing the issue's status as fixed.

🇹🇷Turkey orkut murat yılmaz Istanbul

I've tested it with the upgrade status module and it works. Can someone review it too?

🇹🇷Turkey orkut murat yılmaz Istanbul

@robert castelo thank you:)

🇹🇷Turkey orkut murat yılmaz Istanbul

@gaurav.kapoor, thank you. I've just sent 2 messages to @sandeep_jangra about this issue.

🇹🇷Turkey orkut murat yılmaz Istanbul

When are you going to release a D11 version?

🇹🇷Turkey orkut murat yılmaz Istanbul

Maybe we should refactor the module for D11 too?

🇹🇷Turkey orkut murat yılmaz Istanbul

@bobburns, have you tested the latest commits on 2.0.0-alpha0?

🇹🇷Turkey orkut murat yılmaz Istanbul

I'm changing the issue's title and status too.

🇹🇷Turkey orkut murat yılmaz Istanbul

Can we migrate this issue to drush project?

🇹🇷Turkey orkut murat yılmaz Istanbul

Hi everyone,

I would like to inform you that I would be happy to act as co-maintainer on the project if @gaurav.kapoor approves.

I wish you all a great week.

🇹🇷Turkey orkut murat yılmaz Istanbul

@pearls, I do agree with you. Should I contact one of the maintainers?

🇹🇷Turkey orkut murat yılmaz Istanbul

I can also confirm that too. Thank you @benjifisher :)

🇹🇷Turkey orkut murat yılmaz Istanbul

Sorry, I forgot saying that, I've applied the MR as a patch and scanned entity limit with upgrade status module:

No problems found

🇹🇷Turkey orkut murat yılmaz Istanbul

@pearls, can you review the @jdvc's MR too?

🇹🇷Turkey orkut murat yılmaz Istanbul

I've just tested the latest version and it looks stable.

Thanks for all the efforts:)

🇹🇷Turkey orkut murat yılmaz Istanbul

any chance for merge?

🇹🇷Turkey orkut murat yılmaz Istanbul

@rakesh.gectcr, thanks for the patch. I can confirm that, patch #49 can fix this issue too.

🇹🇷Turkey orkut murat yılmaz Istanbul

It will be fixed, if the MR of this issue 💬 Please develop the module for Drupal 10 Active is accepted.

🇹🇷Turkey orkut murat yılmaz Istanbul

@vinodhini.e, can you also test these issues too?

https://www.drupal.org/project/optional_email/issues/3530927 Disable email field on user registration form, if it is set as optional Active

https://www.drupal.org/project/optional_email/issues/3443982 💬 Please develop the module for Drupal 10 Active

if they work for you too, please change the status as RTBC for both of them:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I've just re-scanned the module with the patch applied, using upgrade status module and there is an error, preventing the upgrade, which I paste below:

file: web/modules/contrib/faq/faq.install

line: 59

error: Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

I'm changing the issue's status as "needs work".

🇹🇷Turkey orkut murat yılmaz Istanbul

@drupal.ninja03, I've tested your patch and it is working. Thanks for your contribution:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I've created a Merge Request, using Upgrade Status module 's scanning function. It works on my development and test environments.

Can you review it please?

🇹🇷Turkey orkut murat yılmaz Istanbul

@jurgenhaas, thanks for your kind and quick answer:)

The error is gone, when I switched to dev version.

🇹🇷Turkey orkut murat yılmaz Istanbul

@jfeltkamp, thanks for the patch. I works well:)

🇹🇷Turkey orkut murat yılmaz Istanbul

Also, problem still exists with cookies 2.0.0-alpha3 (and 2.x-dev) too.

🇹🇷Turkey orkut murat yılmaz Istanbul

I've updated my Drupal core to 11.2.0-rc2 today, but the problem doesn't disappear.

🇹🇷Turkey orkut murat yılmaz Istanbul

It's not directly related to this issue, but this blog post has given some ideas to me:

https://www.gomomento.com/blog/valkey-turns-one-how-the-community-fork-l...

🇹🇷Turkey orkut murat yılmaz Istanbul

After a few cache clear and drush updb, upgrade to Webform 6.3 went well. I'm closing this issue.

Thanks for everything.

🇹🇷Turkey orkut murat yılmaz Istanbul

Sorry for the previous message.

I've just tested the MR as a patch and scanned with Upgrade Status module. The result is:

There is an error in user_one_time_login/src/Form/UserOneTimeLoginConfigForm.php file, line 36:

Call to deprecated function user_role_names(). Deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use Drupal\user\Entity\Role::loadMultiple() and, if necessary, an inline implementation instead.

🇹🇷Turkey orkut murat yılmaz Istanbul

This is the output of the audit command:

composer audit
Found 1 security vulnerability advisory affecting 1 package:
+-------------------+----------------------------------------------------------------------------------+
| Package           | drupal/faq                                                                       |
| Severity          |                                                                                  |
| CVE               | NO CVE                                                                           |
| Title             | Frequently Asked Questions - Critical - Unsupported - SA-CONTRIB-2019-077        |
| URL               | https://www.drupal.org/sa-contrib-2019-077                                       |
| Affected versions | *                                                                                |
| Reported at       | 2019-11-13T18:00:36+00:00                                                        |
| Advisory ID       | SA-CONTRIB-2019-077                                                              |
+-------------------+----------------------------------------------------------------------------------+
🇹🇷Turkey orkut murat yılmaz Istanbul

@greg boggs thanks for refactoring and the missing comments too:)

🇹🇷Turkey orkut murat yılmaz Istanbul

any chance for review?

🇹🇷Turkey orkut murat yılmaz Istanbul

Thanks for the merge:)

🇹🇷Turkey orkut murat yılmaz Istanbul

Can someone test and review this?

🇹🇷Turkey orkut murat yılmaz Istanbul

It is a little commit, but looks working. Can someone review and test it too?

🇹🇷Turkey orkut murat yılmaz Istanbul

@axelm, thanks for correcting my mistake, D10 support will be over in a year.

🇹🇷Turkey orkut murat yılmaz Istanbul

It is very interesting that the status of this issue has remained as "Needs review" for 6 months. Also, Drupal 10's support will be over in 6 months.

The feeling of abandonment is a heavy burden to carry for everyone.

We need to analyze this case carefully and find out what can be done for the benefit of our community.

🇹🇷Turkey orkut murat yılmaz Istanbul

I've created an MR, with the help of ollama and gemma3 :)

Can you review it please?

🇹🇷Turkey orkut murat yılmaz Istanbul

@andeersg, any chance for reviewing this issue too?

Production build 0.71.5 2024