Istanbul
Account created on 3 January 2008, about 17 years ago
#

Merge Requests

More

Recent comments

🇹🇷Turkey orkut murat yılmaz Istanbul

I've applied the @arunkumark's MR as a patch and I confirm that I can delete the related field now.

🇹🇷Turkey orkut murat yılmaz Istanbul

Sorry @emulamba, it was my bad. I've done the necessary things.

Thanks for your contribution:)

🇹🇷Turkey orkut murat yılmaz Istanbul

@emulamba, thanks for the commit, but can you correct your MR please? We need it to be merged with 3.0.0-rc1 version.

🇹🇷Turkey orkut murat yılmaz Istanbul

It looks beautiful on live demo and if I can find a chance to test it locally, I'll update this issue. :)

🇹🇷Turkey orkut murat yılmaz Istanbul

Sorry for very late reply, it is solved with setting the dimensions of the custom icons.

Thanks for everything:)

🇹🇷Turkey orkut murat yılmaz Istanbul

@vandana, there is a conflict in your MR. can you resolve it and then update your MR please?

🇹🇷Turkey orkut murat yılmaz Istanbul

I think the correct project for the issue is SMS Framework. Having a similar error, as I paste below:

Drupal\sms\Exception\SmsPluginReportException: Missing reports for 1 recipient(s). in Drupal\sms\EventSubscriber\SmsMessageProcessor->ensureReports() (line 122 of /var/www/html/web/modules/contrib/smsframework/src/EventSubscriber/SmsMessageProcessor.php).

What could be the reason?

Best,
Orkut

🇹🇷Turkey orkut murat yılmaz Istanbul

Hello again,

Thanks for all the things you do:)

Can you update module info page and the issue summary too?

Best,
Orkut

🇹🇷Turkey orkut murat yılmaz Istanbul

Hello and thanks for the contributions,

Are you going to add Drupal 11 compatibility info to the module page?

Best,
Orkut

🇹🇷Turkey orkut murat yılmaz Istanbul

Any chance for review?

🇹🇷Turkey orkut murat yılmaz Istanbul

@matsbla, thanks for the fix and new release too:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I've tested @immaculatexavier's MR as a patch and it works.

Thanks for contributions.

🇹🇷Turkey orkut murat yılmaz Istanbul

When I updated my core with drupal 10.4.x-dev, I start reaching to my web interface and all the errors become warnings. After rebuilding the cache, warnings disappear, as told on comment #2.

🇹🇷Turkey orkut murat yılmaz Istanbul

When check the browser, I see the WSOD, with the full error message below:

The website encountered an unexpected error. Try again later.
Error: Class "Doctrine\Deprecations\Deprecation" not found in Doctrine\Common\Lexer\Token->offsetGet() (line 104 of /var/www/html/vendor/doctrine/lexer/src/Token.php).

Doctrine\Common\Lexer\Token->offsetGet() (Line: 619)
Drupal\Component\Annotation\Doctrine\DocParser->Annotations() (Line: 338)
Drupal\Component\Annotation\Doctrine\DocParser->parse() (Line: 101)
Drupal\Component\Annotation\Doctrine\SimpleAnnotationReader->getClassAnnotations() (Line: 125)
Drupal\Component\Annotation\Doctrine\SimpleAnnotationReader->getClassAnnotation() (Line: 145)
Drupal\Component\Annotation\Plugin\Discovery\AnnotatedClassDiscovery->getDefinitions() (Line: 119)
Drupal\Core\Entity\EntityTypeManager->findDefinitions() (Line: 213)
Drupal\Core\Plugin\DefaultPluginManager->getDefinitions() (Line: 22)
Drupal\Core\Plugin\DefaultPluginManager->getDefinition() (Line: 135)
Drupal\Core\Entity\EntityTypeManager->getDefinition() (Line: 260)
Drupal\Core\Entity\EntityTypeManager->getHandler() (Line: 195)
Drupal\Core\Entity\EntityTypeManager->getStorage() (Line: 42)
Drupal\eca\Token\CurrentUserDataProvider->__construct() (Line: 261)
Drupal\Component\DependencyInjection\Container->createService() (Line: 179)
Drupal\Component\DependencyInjection\Container->get() (Line: 438)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 275)
Drupal\Component\DependencyInjection\Container->createService() (Line: 179)
Drupal\Component\DependencyInjection\Container->get() (Line: 438)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 239)
Drupal\Component\DependencyInjection\Container->createService() (Line: 179)
Drupal\Component\DependencyInjection\Container->get() (Line: 438)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 239)
Drupal\Component\DependencyInjection\Container->createService() (Line: 179)
Drupal\Component\DependencyInjection\Container->get() (Line: 105)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (Line: 239)
Symfony\Component\HttpKernel\HttpKernel->handleThrowable() (Line: 91)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)
🇹🇷Turkey orkut murat yılmaz Istanbul

It still exists with the version 8.x-1.34.

🇹🇷Turkey orkut murat yılmaz Istanbul

Hello all,

I've just created an issue Merge with "Openlayers 6" project Active , about project merge.

Best,
Orkut

🇹🇷Turkey orkut murat yılmaz Istanbul

Also, I've tried it with Drupal 11, PHP 8.3 and PostgreSQL 17 :)

🇹🇷Turkey orkut murat yılmaz Istanbul

Thank you @Oulalahakabu for the new version. I've tried it with the new one and it works so nice.

🇹🇷Turkey orkut murat yılmaz Istanbul

As I said before, I strongly do agree with @jcandan. This could be a good opportunity for community involvement.

I'd like to add that, Elastic's decision is inspirational. Please adopt it.

🇹🇷Turkey orkut murat yılmaz Istanbul

Thanks for this wonderful work:)

🇹🇷Turkey orkut murat yılmaz Istanbul

Dear @damien laguerre, thank you for your beautiful effort:)

🇹🇷Turkey orkut murat yılmaz Istanbul

@pobster, thanks for the merge:)

can we consider merging with the 4.1.1 release and publish it on the module project's page too?

best,
Orkut

🇹🇷Turkey orkut murat yılmaz Istanbul

I misunderstood your comment #3 @pobster, but it is more clear for me now.

🇹🇷Turkey orkut murat yılmaz Istanbul

Thanks for your contribution @the_g_bomb.

When I try to enable the module, after applying your commits as a patch, I receive the error message below:

Class "Symfony\Component\EventDispatcher\Event" not found

🇹🇷Turkey orkut murat yılmaz Istanbul

Unfortunately, user interface translation doesn't accept translating HTML tags. I'm changing the issue's status.

🇹🇷Turkey orkut murat yılmaz Istanbul

I'm also uploading my commit as a patch file, in order to use it in my composer.json file, until it merges into stable branch.

🇹🇷Turkey orkut murat yılmaz Istanbul

I've added a simple "trans" function in the last part of the array. Can you check this one too?

🇹🇷Turkey orkut murat yılmaz Istanbul

@Tanushree Gupta, thanks for your contribution. However, your work does focus on translating the strings, already hard coded in the slider.html.twig file. It won't work with the "slider_code" variable.

🇹🇷Turkey orkut murat yılmaz Istanbul

@apaderno, you're right. Thanks for correcting.

🇹🇷Turkey orkut murat yılmaz Istanbul

Thank you @Berdir :)

🇹🇷Turkey orkut murat yılmaz Istanbul

If I change the content_sync.info.yml as below, upgrade status report says that, it is compatible with D11 too.

name: 'Content Sync'
type: module
description: 'Allows users to import/export content using YAML files.'
package: Custom
core_version_requirement: ^9.4 || ^10.0 || ^11
configure: content.sync
dependencies:
  - drupal:serialization 

# Information added by Drupal.org packaging script on 2022-12-23
version: '3.0.0-beta1+27-dev'
project: 'content_sync'
datestamp: 1671838601

Please publish the dev release with this changes:) I'm excited to put this in to my CI/CD flows:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I've downloaded the 3.0.x-dev release, applied @mjgruta's latest MR (as a patch) and changed the content_sync.info.yml file like below:

name: 'Content Sync'
type: module
description: 'Allows users to import/export content using YAML files.'
package: Custom
core_version_requirement: ^9.4 || ^10.0
configure: content.sync
dependencies:
  - drupal:serialization 

# Information added by Drupal.org packaging script on 2022-12-23
version: '3.0.0-beta1+27-dev'
project: 'content_sync'
datestamp: 1671838601

And activated the module.

It works nice with Drupal 10.3.0-rc1, PHP 8.3.8 and PostgreSQL 16.1 :

Thank you for everything.

🇹🇷Turkey orkut murat yılmaz Istanbul

@bojanz, I meant 2.0.1 (or 2.0.2) as stable branch. Thanks for your fast response:)

🇹🇷Turkey orkut murat yılmaz Istanbul

from now on, I'll choose a wiser issue title like this:) thanks for your warning @ressa

🇹🇷Turkey orkut murat yılmaz Istanbul

I've added @balbeeryadav's patch to my composer.json file like this:

        "enable-patching": true,
        "patches": {
	    "drupal/facets": {
                "Facets 3.0.0-beta2 release?": "https://www.drupal.org/files/issues/2024-06-01/beta-dev-diff-3394709-6.patch"
            }
	}

But we need to commit all RTBC issues to the dev branch and then merge everything with the Beta2 release as well.

🇹🇷Turkey orkut murat yılmaz Istanbul

@W01F, should we include those differences as features to db_maintenance?

🇹🇷Turkey orkut murat yılmaz Istanbul

Sorry, I've missed the other one 📌 Initial Drupal 11 compatibility Fixed . Closing this duplicate issue.

🇹🇷Turkey orkut murat yılmaz Istanbul

I'm adding this one as a child issue to the roadmap.

🇹🇷Turkey orkut murat yılmaz Istanbul

I assume that it would be better to support D11 with new version.

🇹🇷Turkey orkut murat yılmaz Istanbul

I've tested it locally. @ressa, thanks for the D11 compatibility:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I've tested @gg24's MR locally and it works. Thanks for refactoring the code and modernizing the README file.

🇹🇷Turkey orkut murat yılmaz Istanbul

I've tested the changes by manually editing the info file.

🇹🇷Turkey orkut murat yılmaz Istanbul

Can you merge it with the stable branch too?

🇹🇷Turkey orkut murat yılmaz Istanbul

@bojanz, can you commit this to the stable branch too?

🇹🇷Turkey orkut murat yılmaz Istanbul

Thanks for the merge:)

🇹🇷Turkey orkut murat yılmaz Istanbul

I'm changing the status as RTBC. Thanks for the patch.

🇹🇷Turkey orkut murat yılmaz Istanbul

Hello all,

Have you seen this?

It was mentioned here Drupal 10 Support Active .

Best,
Orkut

Production build 0.71.5 2024