Allow hiding display of country for domestic addresses

The field formatter option works great. Here's an updated patch to fix the PHP warning reported by @Greg Boggs in #31 ✨ Allow hiding display of country for domestic addresses Needs work .

I tested the patch with Drupal 10 and it works perfectly. Great work.

@bronisMateusz which patch did yout test? #33 fails tests

@Anybody Sorry to be so late in replying. I am using exactly the one in the #33 ✨ Allow hiding display of country for domestic addresses Needs work . Everything is still working properly.

Thanks @bronisMateusz for your feedback. Still the two failing tests need to be resolved, so let's keep this at NW.

It's a missing schema entry.

I've attached an updated patch that adds the missing formatter schema.

Updated the updated patch to also fix two coding standards issues from the automated tests.

I think the schema is now complete, looks great, still needs tests though.

Added tests to implementation from #39

Tests were added in #42. I've rebased and moved the work into an MR since it wouldn't apply on 2.x HEAD.

Hi! I updated the Issue Fork against the current state of 2.0.x again (Commit). I also removed a line in the new code that changed the output and caused some unit tests to fail (Commit).

What I'm unsure of though is: we've introduced some changes that cause warnings in phpcs and phpstan (see pipeline). How do we deal with those? Fix? Or just ignore them for now, as we'll remove the deprecated stuff in a later version anyway?

Oh, otherwise the functionality itself still looks good!

Since 📌 Fix all code validate jobs running in GitLab CI Fixed , the code quality checks in the GitLab CI pipeline should be all green. We're not going to want to merge things that introduce warnings / errors in those jobs. The pipeline warnings here should be fixed before this is RTBC.

Thanks,
-Derek

Okay, I updated the issue fork against the latest 2.0.x-dev and made the following changes to address the pipeline issues:

• changed the format of the deprecation error message in AddressDefaultFormatter.php (pulled the version numbers from thin air, feel free to change them!)
• phpstan-ignored the fallback \Drupal call to assign the ConfigFactory if it is missing from params, as I don't see how this could be solved via DI

Definitely needed and great work making this happen.

Looks like all concerns addressed and tests passing.

After this patch, the default behavior is the same— the country always shows in the address.

It adds, however, the crucial option, on a per-field on entity display settings basis, to "Skip country for domestic addresses":

And the address displays without the redundant country.

RTBC!