🇺🇦Ukraine @sickness29

Reroll for 1.2

This patch has a wrong formatting, but still is used on our project

Reroll of the patch for 2.x-dev

This is used on our project. Reroll for latest 2.x

This is no longer needed for 2.x-dev

refactoring patch and leaving open as this is still used

Reroll of the patch from #149 for 1.9 version of the module. Keeping issue active as some projects still use this patch

Hey @dpi
I have created a new MR with a test and also added a fix from #15 with code quality fixes.
Please have a look

sickness29 → changed the visibility of the branch 3319205-views-error to hidden.

sickness29 → made their first commit to this issue’s fork.

Hey @dpi,
thanks for quick response.
I tried reproducing the issue on clean D11 with 2.8.x:
1. I have a published content in English which has draft Ukrainian translation.
2. When I go to the scheduled transitions for that unpublished Ukrainian translation I see correct status in From column.

So this is not reproducible on D11 and 2.8.x-dev.

Please let me know if I can provide anything else

I have tried to reproduce this on clean Drupal 11 and 2.8.x and it is not reproducible, so either we are fixing this for the version where it does not work or I am not sure what to do with this on 2.8.x version.

Hey @bojan_dev
updated the test to be Kernel one, please have a look.

Updated fork with recent changes from dev branch and also added unit test for new events

sickness29 → made their first commit to this issue’s fork.

Fixed code quality and added test, please have a look

sickness29 → made their first commit to this issue’s fork.

Added test for new normalizer, let me know if I can help more, thanks

sickness29 → made their first commit to this issue’s fork.

@anybody fixed merge conflict, please have a look.
sure, I understand your concerns. anything I can do to help this process?

Added test for front end builder which checks translations management, found also issues with symmetric translation setup, so added fixes as well, please check and let me know if anything

sickness29 → made their first commit to this issue’s fork.

This is already done and have test coverage on 2.0.x branch

sickness29 → made their first commit to this issue’s fork.

Hi @sharkbaitdc
this issue is not reproducible on clean drupal instance, also I could not think of a test to add as no feature is broken when image/media paragraph is used, node edit works as expected despite your claims.
Please expand what exactly is not working and steps to reproduce this on clean drupal, thanks

sickness29 → made their first commit to this issue’s fork.

I have added a functional test to test t=fr nested reference fields on node and paragraph inside that both use layout paragraphs.
Also adjusted method from base class to always use latest dialog title and save button in case we few dialogs deep.

sickness29 → made their first commit to this issue’s fork.

Implemented the validate method that does the validation for the entity before submit to be able to set errors to bulk form fields. Previous patch just avoided errors and there was no validation errors shown to user.
Also added a test case that checks node save with empty title as right now it results in WSOD.

Hi @anybody,
I don't see point in disabling entity validation.
What the test you imagine for it would be? i.e. if enabled - we have proper validation errors on form and if disabled - WSOD?
Right now I feel like it's important step in saving entity that is being missed, which is a bug that may result in WSOD in certain scenarios

sickness29 → made their first commit to this issue’s fork.

Looks like dorg no longer runs tests for patches so making a new draft MR with test only

I have updated code to make sure this like is not producing warning.
It was added here btw https://git.drupalcode.org/project/views_bulk_edit/-/commit/6f4a52387f35...

Also attaching patch with test only.

Added new option and test case for it in the MR

sickness29 → made their first commit to this issue’s fork.

Added simple test to check the case when no fields are available for edit

sickness29 → made their first commit to this issue’s fork.

Added new test case to ViewsBulkEditActionTest to make sure new option is tested.
Also added changes to make this option work as isSyncing is not working for Drupal 10.3

sickness29 → made their first commit to this issue’s fork.

Reviewed & Tested this on clean 5.2.x version and all is working. Attaching Postman details.

Setting this to "Reviewed & Tested" since it is working and maintainer needs to confirm that there's nothing to do here and close the issue. If you still have issues, make sure it's not related to your custom changes on the project. Thanks

Hi @dqd
this should now be fixed on latest dev version

Added unit test, feel free to suggest improvements

sickness29 → made their first commit to this issue’s fork.

It is done, please review

sickness29 → made their first commit to this issue’s fork.

sickness29 → created an issue.

Created MR to add computed field which contains crop data for image. Now it should be available in jsonapi relationships under "crop"

Hi @murilohp
image widget crop does not allow to add multiple crop types per image style and it does not make sense.
Steps to reproduce is not accurate as you need to hack module code to make 5th point work

Hi @phenaproxima
please check my comment and move issue status to fixed if you agree. Thanks

sickness29 → made their first commit to this issue’s fork.

Hi @candelas @woprrr
this issue is related to image_widget_crop module. crop module only provides api for image_widget_crop to use and README you have read was from image_widget_crop.

However there's indeed issue with using library files and it comes from https://www.drupal.org/project/image_widget_crop/issues/3002576 → .
The description on textfields says "or leave empty to use the installed library (if present) or a CDN fallback" and the code added in related issue breaks that.
When you save empty values the cdn placeholders values are saved and all checks in image_widget_crop_requirements or image_widget_crop_library_info_alter won't be looking for libraries anymore because there is saved values in config.

sickness29 → created an issue.

This should now be fixed on 2.0.x branch

I have adjusted the patch a bit to allow users to choose whether they want multiple value design for single value fields and also left single value widget styles and scripts. By default the option is disabled to maintain same behaviour for existing fields.

sickness29 → changed the visibility of the branch 3394371-throbber-.gif-cant to active.

sickness29 → changed the visibility of the branch 3394371-throbber-.gif-cant to hidden.

Thanks @dww, merged

sickness29 → made their first commit to this issue’s fork.

Hi @BramDriesen
that's done

Hi @andypost
thank you for your comments, MR created

Hi @wrd-oaitsd
please let me know more about datetime_extras module involvement in your issue.
From the description it seems you have a problem with empty_fields module and not this one

sickness29 → created an issue.

Hi @eojthebrave,
thanks for the feedback, I have prepared updated patch with fixes

sickness29 → created an issue.

Hi @jsacksick
good catches, thanks. I have fixed both cases

Not reproducible on 5.2.x-dev.
Tried to add '&' symbol to \Drupal\Tests\simple_oauth\Functional\TokenBearerFunctionalTestBase where clientSecret is randomly generated and it does not make any more tests fail.

Now you are able to adjust labels like so and patch will take care of using those labels.

/**
 * Implements hook_entity_type_alter().
 */
function test_module_entity_type_alter(array &$entity_types) {
  if (isset($entity_types['consumer'])) {
    $entity_types['consumer']->set('label', t('Test'));
    $entity_types['consumer']->set('label_collection', t('Tests'));
    $entity_types['consumer']->set('label_singular', t('test'));
    $entity_types['consumer']->set('label_plural', t('tests'));
  }
}

Make diff use full index.

Removed test and related fixtures.
Also fixed deprecated call to installSchema in \Drupal\Tests\consumers\Kernel\NegotiatorTest

sickness29 → created an issue.

Fix + test

Fix to the machine name call to make it D9 and D10 compatible

Hi @eojthebrave
here I reworked test from #2 to work with D9+ and used a bit another approach with computed field.
I am posting only test here to make sure it fails and going to post another comment with test and fix

Hi @boromino,
I see. I have changed implementation by providing new Remove button and added command to remove abbr tag.
Now it's possible to add empty title and also possible to remove abbreviation altogether without need to remove text.

Added feeds to require-dev, hopefully it runs this time

Added feeds as test_dependencies to make sure feeds test runs.

Reworked implementation a bit so it uses \Drupal\time_field\Time::createFromHtml5Format() instead of hardcoded sample date.
Added feeds test as well.

Rerolled patch from #2 and added Functional test for time field which checks the field with couple values

Removing phpass in test modules list