Contrib.social

Possible conflict with the Workflow module

Open on Drupal.org →
Created on 4 November 2022, over 2 years ago
Updated 9 February 2023, about 2 years ago

Problem/Motivation

I have a view for moderate content which use fields from the Workflow module. I wanted to use the view fields provided by the Scheduled transitions module with my Moderated Content view to add new field to show if the content is scheduled for transition to a "New State" on the specified date "Transition on". However, it seems the "Transition on" is the only field that I can use as all other fields will fail to render and cause the view to break with this error:

Error: Call to a member function getEntity() on null in Drupal\scheduled_transitions\Plugin\views\field\ScheduledTransitionFromStateViewsField->render() (line 63 of modules/contrib/scheduled_transitions/src/Plugin/views/field/ScheduledTransitionFromStateViewsField.php).

Stack trace error:

Drupal\scheduled_transitions\Plugin\views\field\ScheduledTransitionFromStateViewsField->render() (Line: 1158)
Drupal\views\Plugin\views\field\FieldPluginBase->advancedRender() (Line: 238)
template_preprocess_views_view_field()
call_user_func_array() (Line: 287)
Drupal\Core\Theme\ThemeManager->render() (Line: 422)
Drupal\Core\Render\Renderer->doRender() (Line: 201)
Drupal\Core\Render\Renderer->render() (Line: 1747)
Drupal\views\Plugin\views\field\FieldPluginBase->theme() (Line: 779)
Drupal\views\Plugin\views\style\StylePluginBase->elementPreRenderRow()
call_user_func_array() (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback() (Line: 772)
Drupal\Core\Render\Renderer->doCallback() (Line: 363)
Drupal\Core\Render\Renderer->doRender() (Line: 201)
Drupal\Core\Render\Renderer->render() (Line: 718)
Drupal\views\Plugin\views\style\StylePluginBase->renderFields() (Line: 584)
Drupal\views\Plugin\views\style\StylePluginBase->renderGrouping() (Line: 475)
Drupal\views\Plugin\views\style\StylePluginBase->render() (Line: 2170)
Drupal\views\Plugin\views\display\DisplayPluginBase->render() (Line: 1536)
Drupal\views\ViewExecutable->render() (Line: 199)
Drupal\views\Plugin\views\display\Page->execute() (Line: 1633)
Drupal\views\ViewExecutable->executeDisplay() (Line: 81)
Drupal\views\Element\View::preRenderViewElement()
call_user_func_array() (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback() (Line: 772)
Drupal\Core\Render\Renderer->doCallback() (Line: 363)
Drupal\Core\Render\Renderer->doRender() (Line: 201)
Drupal\Core\Render\Renderer->render() (Line: 241)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 242)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare() (Line: 132)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
call_user_func() (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (Line: 164)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 67)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 270)
Drupal\shield\ShieldMiddleware->bypass() (Line: 137)
Drupal\shield\ShieldMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 23)
Stack\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Steps to reproduce

  1. Go to the Structure → Views and edit the Content view.
  2. Expand the Advanced section and add relationship to the Scheduled transitions view "Reverse reference to Entity base field on scheduled transition".
  3. Add new field to the view. Filter by the Scheduled transitions category and select "Previous State", then Apply and save the changes.
  4. Go to Content.
💬 Support request
Status

Postponed: needs info

Version

2.3

Component

Code

Created by

🇺🇸United States alfattal Minnesota

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    esomething

    I think that the issue happens on rows in the view results for which there are no scheduled transitions. The value for the scheduled transition fields (new state, previous state and revision link) are empty, and the errors happen when Drupal, trying to render these fields, attempts to execute methods on these null values.

    I've added a simple check for null values. It works for me.

    I noticed that the code in ScheduledTransitionFromStateViewsField.php is quite different from ScheduledTransitionToStateViewsField.php. I don't understand the reason for this. Perhaps the module's maintainer will know.

  • Status changed to RTBC about 2 years ago
  • Comment about 2 years ago →
    🇺🇸United States alfattal Minnesota

    Patch on #4 worked perfectly. Thank you @esomething!

  • First commit to issue fork.
  • Pipeline finished with Failed
    about 2 years ago
    Total: 2s
    #9794
  • Comment about 2 years ago →
    🇮🇳India urvashi_vora Madhya Pradesh, India

    Patch on #4 worked and saved a lot of struggle. Thank you @esomething, appreciate the work.

    Committing the changes to help the maintainers.

  • @urvashi_vora opened merge request.
  • Status changed to Needs work about 2 years ago
  • Comment about 2 years ago →
    🇦🇺Australia dpi Perth, Australia

    The suggested changes look ok.

    The diff's are quite noisy, can we change these to early exits instead of another layer of nesting.

    Please do not use `empty()`. Use appropriate type checking via instanceof or similar.

    Code supplied does not meet coding standards.

    We should have at least one test. The project has Views tests already, this should make it easier to implement.

  • Comment about 2 years ago →
    🇦🇺Australia dpi Perth, Australia
  • Status changed to Active about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States alfattal Minnesota

    The patch in #4 failed to apply when upgrading to version 2.4.1 resulting in the same error message in the description. Changing the status to Active again.

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States SocialNicheGuru

    Since there is a patch, it should be "Needs work"

  • Comment about 1 year ago →
    🇺🇸United States alfattal Minnesota

    @dpi → Any chance to look at this issue? It's preventing me from upgrading to newer versions (I'm stuck with version 2.3.0). Thank you!

  • Comment about 1 year ago →
    🇦🇺Australia dpi Perth, Australia

    @13.

    I looked at it over a year ago, there has been no further progress. The issue remains NW.

  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    62 pass
  • Comment about 1 year ago →
    🇺🇸United States SocialNicheGuru

    I rerolled.
    If $scheduled_transition then return ''

  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States alfattal Minnesota

    Patch in #15 applied successfully on the 2.4 branch. Thank you, @SocialNicheGuru!

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇦🇺Australia dpi Perth, Australia

    This issue is not ready as it still needs tests.

    We need to use MR's, in order to validate tests and code adheres to linting and static analysis. Especially as #9 described coding standard issues.

  • Comment 10 months ago →
    🇦🇺Australia dpi Perth, Australia

    Rewording according to #4

  • First commit to issue fork.
  • Pipeline finished with Failed
    5 months ago
    Total: 158s
    #350571
  • Comment 5 months ago →
    🇺🇦Ukraine sickness29

    sickness29 → changed the visibility of the branch 3319205-views-error to hidden.

  • Pipeline finished with Failed
    5 months ago
    Total: 72s
    #350613
  • Merge request !54Fix issue with view relationship to scheduled transitions → (Open) created by sickness29
  • Pipeline finished with Failed
    5 months ago
    Total: 133s
    #352167
  • Pipeline finished with Failed
    5 months ago
    Total: 74s
    #352188
  • Comment 5 months ago →
    🇺🇦Ukraine sickness29

    Hey @dpi
    I have created a new MR with a test and also added a fix from #15 with code quality fixes.
    Please have a look

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024