alfattal → created an issue.
@kushagra.goyal Your comment is confusing. You mentioned that you've attempted to reproduce the issue and got the error that I already mentioned in this ticket, but then you are asking for testing steps to reproduce which you already did!
Nevertheless, here are the steps:
On a fresh or old Drupal setup, check the default_value_callback in the config file core.base_field_override.consumer.consumer.owner_id.yml. If it has the deprecated call back that ends with getCurrentUserId, then it will throw the error.
Workaround
Just change:
default_value_callback: 'Drupal\commerce_product\Entity\ProductVariation::getCurrentUserId'
to:
default_value_callback: 'Drupal\commerce_product\Entity\ProductVariation::getDefaultEntityOwner'
In config/default/core.base_field_override.consumer.consumer.owner_id.yml
alfattal → created an issue.
I second the suggestion in #87 🐛 [10.2 regression] CKEditor 5 breaks when "Source"/Source editing button is added and "Manually editable HTML tags" are specified Needs review . Also, the patch in #97 🐛 [10.2 regression] CKEditor 5 breaks when "Source"/Source editing button is added and "Manually editable HTML tags" are specified Needs review didn't work.
@dave reid → I can confirm that the patch in #3462165 🐛 Preview results in Error: Call to a member function getDefinitions() on null Active resolves this issue.
I'm unable to use the module after upgrading to the latest version (2.1.1) as it keeps throwing the AJAX error even without clicking on the Preview link. I had to downgrade to version (2.1.0) to resolve the issue. Hence, I'm tagging this issue as Critical.
@b.khouy I have applied the patch in #2 and it didn't seem to make any difference. The AJAX error still persists and it's preventing the media from being saved.
@zeshan.ziya Sorry for the late response. I've successfully applied the patch from the PR and I can confirm that it is working properly. 1 for RTBC!
I tried to apply the MR as a local patch, but it failed to apply.
This default event was preventing the modal from showing in Safari on iOS devices. The patch in #2 solved this issue. Indeed, it is an excellent feature to be added to the module. Thank you, Travis → , you saved my day! +1 for RTBC.
My apologies, I overlooked comment #68 🐛 [10.2 regression] CKEditor 5 breaks when "Source"/Source editing button is added and "Manually editable HTML tags" are specified Needs review
I'm having the same issue as in #65 🐛 [10.2 regression] CKEditor 5 breaks when "Source"/Source editing button is added and "Manually editable HTML tags" are specified Needs review . The patch in #63 🐛 [10.2 regression] CKEditor 5 breaks when "Source"/Source editing button is added and "Manually editable HTML tags" are specified Needs review did NOT solve the issue.
Patch in #15 applied successfully on the 2.4 branch. Thank you, @SocialNicheGuru!
@dpi → Any chance to look at this issue? It's preventing me from upgrading to newer versions (I'm stuck with version 2.3.0). Thank you!
alfattal → created an issue.
alfattal → created an issue.
The patch in #4 failed to apply when upgrading to version 2.4.1 resulting in the same error message in the description. Changing the status to Active again.
@balu-ertl → Regarding your comment in #18 🐛 Update to 3.5 replaces purge_drush but does not disable it Needs work , I think you're right. After revisiting this issue, I realized that it was caused by an old patch → that is still sitting in my composer.jason file. After removing this patch, I was able to upgrade to version 3.5 without any issue.
I've tested the two PRs and still getting the error message when running drush cron or drush p:queue-work.
Wim Leers → Which one?!
I'm having a similar issue importing the config to the database after upgrading to Drupal 10.2. The command $ drush cimterminates with the following error message when it reaches any config related to moderation.state.
Error: Call to a member function getSettings() on null in Drupal\Core\Field\FieldConfigBase->getSettings() (line 372 of /docroot/core/lib/Drupal/Core/Field/FieldConfigBase.php).
When deleting these config files, the import completes successfully.
System Info:
- Drupal 10.2.
- PHP 8.1 & MySQL 8
- Drush 12.4.3.0
The patch in #104 failed to apply on Drupal 10.2 branch while the patch in #84 still working.
@alexpott Not sure why you changed the status to Needs Review, you opened a MR based on a patch that does NOT apply and thus, it needs works!
@akoe May I ask what patches you're testing for Drupal 10? Are they local patches or from other issues? Thank you!
The patch in #55 🐛 Transaction autocommit during shutdown relies on unreliable object destruction order Active failed to apply with the following error:
Unhandled promise rejection with ArgumentCountError: Too few arguments to function React\Promise\Promise::React\Promise\{closure}(), 0 passed in phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php on line 660 and exactly 1 expected in phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php:277
Stack trace:
#0 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(660): React\Promise\Promise::React\Promise\{closure}()
#1 phar:///usr/local/bin/composer/vendor/react/promise/src/Internal/FulfilledPromise.php(47): Composer\Installer\InstallationManager::Composer\Installer\{closure}()
#2 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(661): React\Promise\Internal\FulfilledPromise->then()
#3 phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php(288): Composer\Installer\InstallationManager::Composer\Installer\{closure}()
#4 phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php(37): React\Promise\Promise->call()
#5 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(663): React\Promise\Promise->__construct()
#6 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(221): Composer\Installer\InstallationManager->runCleanup()
#7 phar:///usr/local/bin/composer/src/Composer/Installer.php(791): Composer\Installer\InstallationManager->execute()
#8 phar:///usr/local/bin/composer/src/Composer/Installer.php(292): Composer\Installer->doInstall()
#9 phar:///usr/local/bin/composer/src/Composer/Command/InstallCommand.php(147): Composer\Installer->run()
#10 phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php(298): Composer\Command\InstallCommand->execute()
#11 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run()
#12 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand()
#13 phar:///usr/local/bin/composer/src/Composer/Console/Application.php(382): Symfony\Component\Console\Application->doRun()
#14 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(171): Composer\Console\Application->doRun()
#15 phar:///usr/local/bin/composer/src/Composer/Console/Application.php(145): Symfony\Component\Console\Application->run()
#16 phar:///usr/local/bin/composer/bin/composer(88): Composer\Console\Application->run()
#17 /usr/local/bin/composer(29): require('...')
#18 {main}It also failed in the test for (10.1.x: PHP 8.1 & MySQL 8).
@Balu Ertl →
In my case, I can confirm that disabling purge_drush and then, upgrade to 3.5 eliminated the error. I tried first to upgrade and then, manually disable purge_drush, but that DIDN'T eliminate the error.
I agree with @pasive. I'm on Drupal 10 and the issue happened when I upgraded the module to version 3.5. Downgrading to the previous version resolved the issue for me.
Patch in #71 worked for me. I'm on Drupal 10.1.6, PHP 8.1.
Patch in #14 failed to apply with the following error:
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-10-17/3073426-10-2.x.patch
Unhandled promise rejection with ArgumentCountError: Too few arguments to function React\Promise\Promise::React\Promise\{closure}(), 0 passed in phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php on line 660 and exactly 1 expected in phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php:277
Stack trace:
#0 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(660): React\Promise\Promise::React\Promise\{closure}()
#1 phar:///usr/local/bin/composer/vendor/react/promise/src/Internal/FulfilledPromise.php(47): Composer\Installer\InstallationManager::Composer\Installer\{closure}()
#2 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(661): React\Promise\Internal\FulfilledPromise->then()
#3 phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php(288): Composer\Installer\InstallationManager::Composer\Installer\{closure}()
#4 phar:///usr/local/bin/composer/vendor/react/promise/src/Promise.php(37): React\Promise\Promise->call()
#5 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(663): React\Promise\Promise->__construct()
#6 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(221): Composer\Installer\InstallationManager->runCleanup()
#7 phar:///usr/local/bin/composer/src/Composer/Installer.php(791): Composer\Installer\InstallationManager->execute()
#8 phar:///usr/local/bin/composer/src/Composer/Installer.php(292): Composer\Installer->doInstall()
#9 phar:///usr/local/bin/composer/src/Composer/Command/InstallCommand.php(147): Composer\Installer->run()
#10 phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php(298): Composer\Command\InstallCommand->execute()
#11 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run()
#12 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand()
#13 phar:///usr/local/bin/composer/src/Composer/Console/Application.php(382): Symfony\Component\Console\Application->doRun()
#14 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(171): Composer\Console\Application->doRun()
#15 phar:///usr/local/bin/composer/src/Composer/Console/Application.php(145): Symfony\Component\Console\Application->run()
#16 phar:///usr/local/bin/composer/bin/composer(88): Composer\Console\Application->run()
#17 /usr/local/bin/composer(29): require('...')
#18 {main}
In Patches.php line 331:
Cannot apply patch 3073426-14: Resave method not implemented (https://www.drupal.org/files/issues/2023-10-17/3073426-10-2.x.patch)!Patch in #12 fixed the issue for me. +1 on the RTBC.
@joseph.olstad Here is the full backtrace for the error I'm getting:
[error] TypeError: Drupal\Component\DependencyInjection\ReverseContainer::generateServiceIdHash(): Argument #1 ($object) must be of type object, null given in Drupal\Component\DependencyInjection\ReverseContainer->generateServiceIdHash() (line 87 of ../docroot/core/lib/Drupal/Component/DependencyInjection/ReverseContainer.php) #0 [internal function]: Drupal\Component\DependencyInjection\ReverseContainer->generateServiceIdHash()
#1 ../docroot/core/lib/Drupal/Component/DependencyInjection/ReverseContainer.php(75): array_map()
#2 ../docroot/core/lib/Drupal/Core/DrupalKernel.php(903): Drupal\Component\DependencyInjection\ReverseContainer->recordContainer()
#3 ../vendor/drush/drush/src/Drupal/DrupalKernelTrait.php(72): Drupal\Core\DrupalKernel->initializeContainer()
#4 ../docroot/core/lib/Drupal/Core/DrupalKernel.php(816): Drush\Drupal\DrupalKernel->initializeContainer()
#5 ../docroot/core/lib/Drupal/Core/Extension/ModuleInstaller.php(608): Drupal\Core\DrupalKernel->updateModules()
#6 ../docroot/core/lib/Drupal/Core/Extension/ModuleInstaller.php(244): Drupal\Core\Extension\ModuleInstaller->updateKernel()
#7 ../docroot/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(83): Drupal\Core\Extension\ModuleInstaller->install()
#8 ../docroot/core/lib/Drupal/Core/Config/ConfigImporter.php(872): Drupal\Core\ProxyClass\Extension\ModuleInstaller->install()
#9 ../docroot/core/lib/Drupal/Core/Config/ConfigImporter.php(624): Drupal\Core\Config\ConfigImporter->processExtension()
#10 ../docroot/core/lib/Drupal/Core/Config/ConfigImporter.php(561): Drupal\Core\Config\ConfigImporter->processExtensions()
#11 ../vendor/drush/drush/src/Commands/config/ConfigImportCommands.php(259): Drupal\Core\Config\ConfigImporter->doSyncStep()
#12 ../vendor/drush/drush/includes/drush.inc(62): Drush\Commands\config\ConfigImportCommands->doImport()
#13 ../vendor/drush/drush/includes/drush.inc(53): drush_call_user_func_array()
#14 ../vendor/drush/drush/src/Commands/config/ConfigImportCommands.php(230): drush_op()
#15 [internal function]: Drush\Commands\config\ConfigImportCommands->import()
#16 ../vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array()
#17 ../vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#18 ../vendor/consolidation/annotated-command/src/CommandProcessor.php(176): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#19 ../vendor/consolidation/annotated-command/src/AnnotatedCommand.php(391): Consolidation\AnnotatedCommand\CommandProcessor->process()
#20 ../vendor/symfony/console/Command/Command.php(326): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#21 ../vendor/symfony/console/Application.php(1081): Symfony\Component\Console\Command\Command->run()
#22 ../vendor/symfony/console/Application.php(320): Symfony\Component\Console\Application->doRunCommand()
#23 ../vendor/symfony/console/Application.php(174): Symfony\Component\Console\Application->doRun()
#24 ../vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run()
#25 ../vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#26 ../vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run()
#27 ../vendor/drush/drush/drush(4): require('...')
#28 ../vendor/bin/drush(117): include('...')
#29 {main}.@TolstoyDotCom Like, what otherings?
@joseph.olstad I'm having the same issue. I've tried removing modules/contrib and following your suggested steps but that didn't help and I'm still getting the same error message.
It appeared that patch in #6 although apply and resolve the D10 compatibility issue in the Upgrade Status report, it breaks the module functionality with the following error:
The website encountered an unexpected error. Please try again later.
TypeError: Cannot assign Drupal\Core\File\FileUrlGenerator to property Drupal\unmanaged_files\Form\DeleteUnmanagedFilesForm::$fileUrlGenerator of type Drupal\unmanaged_files\Form\FileUrlGeneratorInterface in Drupal\unmanaged_files\Form\DeleteUnmanagedFilesForm::create() (line 66 of modules/contrib/unmanaged_files/src/Form/DeleteUnmanagedFilesForm.php).
Drupal\unmanaged_files\Form\DeleteUnmanagedFilesForm::create() (Line: 28)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition() (Line: 48)
Drupal\Core\Controller\HtmlFormController->getFormObject() (Line: 58)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 68)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 270)
Drupal\shield\ShieldMiddleware->bypass() (Line: 137)
Drupal\shield\ShieldMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 23)
Stack\StackedHttpKernel->handle() (Line: 718)
Drupal\Core\DrupalKernel->handle() (Line: 19)Patch in #3 solved the issue for me.
alfattal → created an issue.
alfattal → created an issue.
Patch in #9 failed to apply while the patch in #6 applied successfully with no errors in the Upgrade Status report.
Full trace:
- Applying patches for drupal/unmanaged_files
https://www.drupal.org/files/issues/2023-05-03/3299384-9.patch →
(3299384-9: Automated Drupal 10 compatibility fixes)
Downloading
https://www.drupal.org/files/issues/2023-05-03/3299384-9.patch →
patch '-p1' --no-backup-if-mismatch -d 'docroot/modules/contrib/unmanaged_files' < '/tmp/64d69f6d1f3ac.patch'
Executing command (CWD): patch '-p1' --no-backup-if-mismatch -d 'docroot/modules/contrib/unmanaged_files' < '/tmp/64d69f6d1f3ac.patch'
patching file src/Form/DeleteUnmanagedFilesForm.php
patching file src/UnmanagedFilesManager.php
Reversed (or previously applied) patch detected!
Assume -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored
-- saving rejects to file src/UnmanagedFilesManager.php.rej
patching file unmanaged_files.info.yml
patch '-p0' --no-backup-if-mismatch -d 'docroot/modules/contrib/unmanaged_files' < '/tmp/64d69f6d1f3ac.patch'
Executing command (CWD): patch '-p0' --no-backup-if-mismatch -d 'docroot/modules/contrib/unmanaged_files' < '/tmp/64d69f6d1f3ac.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Form/DeleteUnmanagedFilesForm.php b/src/Form/DeleteUnmanagedFilesForm.php
|index 3b6968a..55494d3 100644
|--- a/src/Form/DeleteUnmanagedFilesForm.php
|+++ b/src/Form/DeleteUnmanagedFilesForm.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
4 out of 4 hunks ignored
can't find file to patch at input line 48
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/UnmanagedFilesManager.php b/src/UnmanagedFilesManager.php
|index 43fd52a..437e2af 100644
|--- a/src/UnmanagedFilesManager.php
|+++ b/src/UnmanagedFilesManager.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 70
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/unmanaged_files.info.yml b/unmanaged_files.info.yml
|index 8eb8c32..4c77cc6 100644
|--- a/unmanaged_files.info.yml
|+++ b/unmanaged_files.info.yml
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
patch '-p2' --no-backup-if-mismatch -d 'docroot/modules/contrib/unmanaged_files' < '/tmp/64d69f6d1f3ac.patch'
Executing command (CWD): patch '-p2' --no-backup-if-mismatch -d 'docroot/modules/contrib/unmanaged_files' < '/tmp/64d69f6d1f3ac.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Form/DeleteUnmanagedFilesForm.php b/src/Form/DeleteUnmanagedFilesForm.php
|index 3b6968a..55494d3 100644
|--- a/src/Form/DeleteUnmanagedFilesForm.php
|+++ b/src/Form/DeleteUnmanagedFilesForm.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
4 out of 4 hunks ignored
can't find file to patch at input line 48
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/UnmanagedFilesManager.php b/src/UnmanagedFilesManager.php
|index 43fd52a..437e2af 100644
|--- a/src/UnmanagedFilesManager.php
|+++ b/src/UnmanagedFilesManager.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 70
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/unmanaged_files.info.yml b/unmanaged_files.info.yml
|index 8eb8c32..4c77cc6 100644
|--- a/unmanaged_files.info.yml
|+++ b/unmanaged_files.info.yml
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
patch '-p4' --no-backup-if-mismatch -d 'docroot/modules/contrib/unmanaged_files' < '/tmp/64d69f6d1f3ac.patch'
Executing command (CWD): patch '-p4' --no-backup-if-mismatch -d 'docroot/modules/contrib/unmanaged_files' < '/tmp/64d69f6d1f3ac.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Form/DeleteUnmanagedFilesForm.php b/src/Form/DeleteUnmanagedFilesForm.php
|index 3b6968a..55494d3 100644
|--- a/src/Form/DeleteUnmanagedFilesForm.php
|+++ b/src/Form/DeleteUnmanagedFilesForm.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
4 out of 4 hunks ignored
can't find file to patch at input line 48
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/UnmanagedFilesManager.php b/src/UnmanagedFilesManager.php
|index 43fd52a..437e2af 100644
|--- a/src/UnmanagedFilesManager.php
|+++ b/src/UnmanagedFilesManager.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 70
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/unmanaged_files.info.yml b/unmanaged_files.info.yml
|index 8eb8c32..4c77cc6 100644
|--- a/unmanaged_files.info.yml
|+++ b/unmanaged_files.info.yml
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
Could not apply patch! Skipping. The error was: Cannot apply patch
https://www.drupal.org/files/issues/2023-05-03/3299384-9.patch →
Downloading https://packages.drupal.org/8/downloads
[200] https://packages.drupal.org/8/downloads
In Patches.php line 326:
[Exception]
Cannot apply patch 3299384-9: Automated Drupal 10 compatibility fixes (
https://www.drupal.org/files/issues/2023-05-03/3299384-9.patch →
)!
Exception trace:
at /home/ffattal/mndor/vendor/cweagans/composer-patches/src/Patches.php:326
cweagans\Composer\Patches->postInstall() at n/a:n/a
call_user_func() at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:202
Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:144
Composer\EventDispatcher\EventDispatcher->dispatchPackageEvent() at phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php:460
Composer\Installer\InstallationManager->Composer\Installer\{closure}() at phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php:475
Composer\Installer\InstallationManager->executeBatch() at phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php:390
Composer\Installer\InstallationManager->downloadAndExecuteBatch() at phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php:282
Composer\Installer\InstallationManager->execute() at phar:///usr/local/bin/composer/src/Composer/Installer.php:759
Composer\Installer->doInstall() at phar:///usr/local/bin/composer/src/Composer/Installer.php:281
Composer\Installer->run() at phar:///usr/local/bin/composer/src/Composer/Command/InstallCommand.php:137
Composer\Command\InstallCommand->execute() at phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php:298
Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:1015
Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:299
Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:334
Composer\Console\Application->doRun() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:171
Symfony\Component\Console\Application->run() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:130
Composer\Console\Application->run() at phar:///usr/local/bin/composer/bin/composer:88
require() at /usr/local/bin/composer:29
@purushotam.rai You're the module/project maintainer and you should have access to the Git repo!
@dpi Revoking this permission would result in NOT being able to Reschedule a transition although the permission for that is already set. That's another anomaly or even a bug that need to be addressed.
@vegardjo Thank you for the cache clearing tip. I've made another test for the patch in #6 and after clearing the cache, I can confirm that it's working as expected. Moving this to RTBC!
I had the same issue with a view that has an exposed boolean filter. The patch in #2 fixed the issue for me. Here is a full trace for the error message:
Warning: Trying to access array offset on value of type bool in Drupal\views\Plugin\views\PluginBase->setOptionDefaults() (line 187 of core/modules/views/src/Plugin/views/PluginBase.php).
Drupal\views\Plugin\views\PluginBase->setOptionDefaults(Array, Array) (Line: 141)
Drupal\views\Plugin\views\PluginBase->init(Object, Object, Array) (Line: 104)
Drupal\views\Plugin\views\HandlerBase->init(Object, Object, Array) (Line: 95)
Drupal\views\Plugin\views\filter\FilterPluginBase->init(Object, Object, Array) (Line: 894)
Drupal\views\Plugin\views\display\DisplayPluginBase->getHandlers('filter') (Line: 1045)
Drupal\views\ViewExecutable->_initHandler('filter', Array) (Line: 903)
Drupal\views\ViewExecutable->initHandlers() (Line: 2318)
Drupal\views\Plugin\views\display\DisplayPluginBase->preExecute() (Line: 1697)
Drupal\views\ViewExecutable->preExecute(Array) (Line: 1632)
Drupal\views\ViewExecutable->executeDisplay('vita_search_block', Array) (Line: 81)
Drupal\views\Element\View::preRenderViewElement(Array) (Line: 59)
Drupal\views\Plugin\Block\ViewsBlock->build() (Line: 106)
Drupal\layout_builder\EventSubscriber\BlockComponentRenderArray->onBuildRender(Object, 'section_component.build.render_array', Object)
call_user_func(Array, Object, 'section_component.build.render_array', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'section_component.build.render_array') (Line: 90)
Drupal\layout_builder\SectionComponent->toRenderArray(Array, ) (Line: 88)
Drupal\layout_builder\Section->toRenderArray(Array) (Line: 316)
Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->buildSections(Object) (Line: 275)
Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->buildMultiple(Array) (Line: 340)
Drupal\Core\Entity\EntityViewBuilder->buildComponents(Array, Array, Array, 'full') (Line: 24)
Drupal\node\NodeViewBuilder->buildComponents(Array, Array, Array, 'full') (Line: 282)
Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array) (Line: 239)
Drupal\Core\Entity\EntityViewBuilder->build(Array)
call_user_func_array(Array, Array) (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 788)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 374)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 242)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 243)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 174)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 68)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 270)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 137)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)It worth mentioning the issue didn't break the views functionality as it was still returning results as expected.
@daften I've applied your patch in #6, went to the permissions and granted a specific role the access to administer tasks only but seems like nothing has changed. That role and every role still have access to Administer unmanaged files and Administer unmanaged files settings. For this reason, I'm changing the status to Needs work.
@fenstrat Thank you for the clarification. Yes, I tried the 3.0.0 version, and it is giving me the same error message. I'm on Drupal core version 9.5.8. Is the 3.0.0 version work only with Drupal 10?
I'm confused, both issues were marked as duplicate, this one and the referenced. Which one should we go with?!
The MR in #2 and patch in #3 works fine. However, I have a use case where a role with the permission to "Delete any files" needs to have access to the "Unmanaged File List" to perform cleaning, but this role should NOT have access to the "Unmanaged File Settings".
The current patch removes access to both. Hence, we need more granular permissions to limit the access to the settings separately from the access to the list.
alfattal → created an issue.
@VladimirAus Did you have the chance to look into the information I provided?
Patch in #63 failed to apply on the new release 8.x-1.3.
$ composer install
Gathering patches for root package.
Removing package drupal/site_alert so that it can be re-installed and re-patched.
- Removing drupal/site_alert (1.3.0)
Deleting docroot/modules/contrib/site_alert - deleted
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run `composer update` or `composer update <package name>`.
Package operations: 1 install, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
- Installing drupal/site_alert (1.3.0): Extracting archive
- Applying patches for drupal/site_alert
https://www.drupal.org/files/issues/2020-06-25/3154942-2.patch (3154942-2: Separate AJAX target from wrapper)
https://www.drupal.org/files/issues/2020-08-17/3151256-3.patch (3151256-3: Allow the ability to add multiple blocks)
https://www.drupal.org/files/issues/2023-02-15/3156557-63.patch (3156557-63: Add ability to dismiss alert)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-02-15/3156557-63.patch
In Patches.php line 326:
Cannot apply patch 3156557-63: Add ability to dismiss alert (https://www.drupal.org/files/issues/2023-02-15/3156557-63.patch)!
install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]Patch on #4 worked perfectly. Thank you @esomething!
@VladimirAus Sorry for the late response. Here is the requested information:
Version of my environment:
Drupal 9.5.2
PHP 8.0.27
Taxonomy Manager version 2.0.7 and 2.0.8
Steps to reproduce:
- Go to Structure > Taxonomy and edit any vocabulary.
- In the Manage fields tab, add general field like (Email) or (Link)
- In the new field setting, select Unlimited, save field settings then save settings. This will add the Add another item button
- Navigate to the list tab and add some terms to your vocabulary
- Go to Structure > Taxonomy Manager and click on that vocabulary. From the terms list block on the left, click on any term. This will open the edit panel to the right.
- Scroll down to the field you added and click on the Add another item. A spinning (Please wait) will show momentarily and then disappear without adding another field.
Please see the attached screenshot.
@RichardDavies No, I did not and I'm still waiting for an update from the module maintainer (phenaproxima) after he requested attaching "pre-update" and "post-update" versions of my composer.lock file.
@mglaman Yes, it seems like eDisMax was turned off during the upgrade and yes, turning it on fix the issue that I'm having. Thank you!