Add ability to dismiss alert

Created on 2 July 2020, almost 5 years ago
Updated 15 February 2023, over 2 years ago

I think it would be cool to allow admins to choose whether or not to allow users to dismiss site alerts.

Example:

https://www.drupal.org/project/sitewide_alert β†’ this module has a checkbox to make the site alert dismissable.

✨ Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States ntaylor1994

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¦πŸ‡ΊAustralia Nadim Hossain

    Rerolled the patch to match with the new release 8.x-1.3

  • πŸ‡ΊπŸ‡ΈUnited States alfattal Minnesota

    Patch in #63 failed to apply on the new release 8.x-1.3.

    $ composer install
    Gathering patches for root package.
    Removing package drupal/site_alert so that it can be re-installed and re-patched.
      - Removing drupal/site_alert (1.3.0)
    Deleting docroot/modules/contrib/site_alert - deleted
    Installing dependencies from lock file (including require-dev)
    Verifying lock file contents can be installed on current platform.
    Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run `composer update` or `composer update <package name>`.
    Package operations: 1 install, 0 updates, 0 removals
    Gathering patches for root package.
    Gathering patches for dependencies. This might take a minute.
      - Installing drupal/site_alert (1.3.0): Extracting archive
      - Applying patches for drupal/site_alert
        https://www.drupal.org/files/issues/2020-06-25/3154942-2.patch (3154942-2: Separate AJAX target from wrapper)
        https://www.drupal.org/files/issues/2020-08-17/3151256-3.patch (3151256-3: Allow the ability to add multiple blocks)
        https://www.drupal.org/files/issues/2023-02-15/3156557-63.patch (3156557-63: Add ability to dismiss alert)
       Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-02-15/3156557-63.patch
    
    In Patches.php line 326:
                                                                                                                                      
      Cannot apply patch 3156557-63: Add ability to dismiss alert (https://www.drupal.org/files/issues/2023-02-15/3156557-63.patch)!  
                                                                                                                                      
    
    install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
  • Status changed to Needs work over 2 years ago
  • πŸ‡ΊπŸ‡ΈUnited States alfattal Minnesota
  • Status changed to Needs review over 2 years ago
  • πŸ‡ΊπŸ‡ΈUnited States rpayanm

    The patch applies well on the last release, be aware you are using several patches on that module, there might be a conflict there.

  • πŸ‡¦πŸ‡ΊAustralia Nadim Hossain

    Patch #63 was missing some new files that got missed during the re roll. I have updated the patch. Please try using this and see if it works. Also keep in in mind as rpayanm mentioned, using other patches might create conflicts as well.

  • πŸ‡¦πŸ‡ΊAustralia Nadim Hossain

    I have done some testing as well just to check the patch I submitted works as expected and patch #67 is working for me. Please see the screenshots below -

  • First commit to issue fork.
Production build 0.71.5 2024