markie → created an issue. See original summary → .
gah.. already did this one..
Thanks for the responses.
Tested the MR patch locally and it negates the error. Ready for review.
seantwalsh → credited markie → .
jjchinquist → credited markie → .
This is working as designed. Smart Trim is not a text expander. The more link will always navigate to the target node.
Able to patch the current MR which was created with #67. Tested and successfully able to dismiss an alert. I do like how this splits the style away from the functionality.
damienmckenna → credited markie → .
teknorah → credited markie → .
Thanks for the patch. Can you please create a merge request?
damienmckenna → credited markie → .
jjchinquist → credited markie → .
smustgrave → credited markie → .
@bigbabert: That issue is outside the scope of mentor-team-coordination. It should stay with the site moderators and security team.
jjchinquist → credited markie → .
Hi there,
Thank you for reaching out.
The Community Working Group's main goal is to make sure the Drupal Community is a welcoming and nurturing community. Though open for use by all, the Community Working Group most commonly posts nudges, and then it is after an incident report is sent and/or when the topic has become escalated or off topic. We use the nudges in hopes of preventing more intrusive interventions by the Conflict Resolution Team.
After talking with the team, we are curious about the “open issue for logging of nudges.” Can you provide a link?
To answer some of your questions:
- Do they actually defuse the situation, or do they raise tensions in the threads?
- They intend to call out the negative behavior, as we know that, in the moment, the authors may not recognize what the community sees. We have not seen an incident where it raises tensions. It will generally defuse the situation. The only negative effect we have witnessed is that the thread goes silent.
- Does anyone feel that a CWG Nudge was used too soon in a discussion?
- We have not noticed this. Again, usually we consider a nudge after an incident report or if we’ve noticed a particular rise in tensions. Assuming the nudge is applicable and can be applied.
- Are contributors more aggressive out of concern a nudge will be given on a sensitive topic shutting down discussion before a point can be made?
- The nudges are focused on bringing the conversation back on topic. Usually, the issue/thread has gone from discussing an issue to personal attacks or other escalating topics.
- Are nudges used by 'less experienced' developers or only used by 'well-established public figures' of the Drupal Community? (Are they being used to shut down discussion, creating a non-collaborative environment?)
- The nudges are commonly used by the CWG, however, they are available to all. Everyone in the community is welcome and encouraged to use them and contribute in the spirit of our open-source community. We are all here to mentor and collaborate and not call out experience level or notoriety as proxies for ‘being right' or 'wrong’.
We are happy to hop on a call with you and discuss this and other issues/threads where nudges were applied.
Posted on behalf of the CWG
teknorah → credited markie → .
teknorah → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
With a little assistance from @jimbirch I present
https://project.pages.drupalcode.org/smart_trim/preview-111/index.html
Please review and let me know if you have anything to add.
Merged. Thanks!
See documentation at https://project.pages.drupalcode.org/gitlab_templates/jobs/pages/
jjchinquist → credited markie → .
ok.. I named the branch incorrectly, but was able to apply the MR patch locally and successfully am able to upgrade to D10.
I am running into this as well. The 3.x version supports D9, however we can't use it to move to D10 without upgrading to 4.x which.. we can't do on Drupal 9.. I am suggesting adding D10 support back to the 3.x branch for a smoother upgrade. Will add a MR in a few.
damienmckenna → credited markie → .
volkswagenchick → credited markie → .
Merged into codebase. Thanks for this
markie → changed the visibility of the branch 3515123-incorrect-dependency-in to hidden.
additionally, application keys expire.. wu tang is forever..
in this instance 'wu tang' === 'ssh keys'
Was going through the instructions at https://www.drupal.org/docs/develop/development-tools/drupalpod/drupalpo... → and am curious why drupalforge uses https instead of ssh to checkout the forks? It would be much simpler with a single ssh key instead of having to enter the username and password... This is how drupalpod was set up and once you have your ssh keys set up in gitlab, it's a much smoother process.
teknorah → credited markie → .
mradcliffe → credited markie → .
teknorah → credited markie → .
Updating to use the ssh repository checkout instead of https and adding --prefer-source switch to show how to check out the codebase and allow a person to work on the module.
The MR doesn't come close to matching the patch and has a lot of CS errors.
Please create an MR with this patch.. Thank you
mradcliffe → credited markie → .
mradcliffe → credited markie → .
jjchinquist → credited markie → .
This looks good and I'll rebase here in a few. I think we need to move the TruncateHTML functionality into a service all together. There might be a ticket for that already.. Thanks for these fixes.
Looks good. Thanks!
teknorah → credited markie → .
damienmckenna → credited markie → .
teknorah → credited markie → .
Credit should be going to https://www.drupal.org/u/markconroy → not me.
liampower → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
jjchinquist → credited markie → .
Note to self:
```
composer require "drupal/maxlength:3.1.0 as 2.1.3"
composer require "drupal/registration_role:2.x-dev as 2.0.1"
composer require 'drupal/event_platform:^1.0'
```
damienmckenna → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
damienmckenna → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
teknorah → credited markie → .
We also might be able to replace the TruncateHTML file with the trait... That file probably needs a lot of clean out anyway.
The MR is missing a lot of stuff from the other patches. Please update.