ok.. I named the branch incorrectly, but was able to apply the MR patch locally and successfully am able to upgrade to D10.
I am running into this as well. The 3.x version supports D9, however we can't use it to move to D10 without upgrading to 4.x which.. we can't do on Drupal 9.. I am suggesting adding D10 support back to the 3.x branch for a smoother upgrade. Will add a MR in a few.
damienmckenna → credited markie → .
volkswagenchick → credited markie → .
Merged into codebase. Thanks for this
markie → changed the visibility of the branch 3515123-incorrect-dependency-in to hidden.
additionally, application keys expire.. wu tang is forever..
in this instance 'wu tang' === 'ssh keys'
Was going through the instructions at https://www.drupal.org/docs/develop/development-tools/drupalpod/drupalpo... → and am curious why drupalforge uses https instead of ssh to checkout the forks? It would be much simpler with a single ssh key instead of having to enter the username and password... This is how drupalpod was set up and once you have your ssh keys set up in gitlab, it's a much smoother process.
teknorah → credited markie → .
mradcliffe → credited markie → .
teknorah → credited markie → .
Updating to use the ssh repository checkout instead of https and adding --prefer-source switch to show how to check out the codebase and allow a person to work on the module.
The MR doesn't come close to matching the patch and has a lot of CS errors.
Please create an MR with this patch.. Thank you
mradcliffe → credited markie → .
mradcliffe → credited markie → .
jjchinquist → credited markie → .
This looks good and I'll rebase here in a few. I think we need to move the TruncateHTML functionality into a service all together. There might be a ticket for that already.. Thanks for these fixes.
Looks good. Thanks!
teknorah → credited markie → .
damienmckenna → credited markie → .
teknorah → credited markie → .
Credit should be going to https://www.drupal.org/u/markconroy → not me.
liampower → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
jjchinquist → credited markie → .
Note to self:
```
composer require "drupal/maxlength:3.1.0 as 2.1.3"
composer require "drupal/registration_role:2.x-dev as 2.0.1"
composer require 'drupal/event_platform:^1.0'
```
damienmckenna → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
damienmckenna → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
hestenet → credited markie → .
teknorah → credited markie → .
We also might be able to replace the TruncateHTML file with the trait... That file probably needs a lot of clean out anyway.
The MR is missing a lot of stuff from the other patches. Please update.
damienmckenna → credited markie → .
Updated the deprecation found by upgrade_status however I was not able to follow the instructions on the project page to create a TOC block. There is no option as shown in the demonstration. That being said, this module does enable in Drupal 10 and 11....
gitpod /workspace/drupalpod (main) $ drush upgrade_status:analyze table_of_contents
Notice: running 'drush upgrade_status:analyze table_of_contents' in ddev
[notice] Processing /var/www/html/web/modules/contrib/table_of_contents.
================================================================================
Table of contents, --
Scanned on Wed, 01/15/2025 - 21:56
FILE:
web/modules/contrib/table_of_contents/src/Plugin/Block/TextLongFieldTocBlock.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 36 Providing context definitions via the "context" key is
deprecated in Drupal 8.7.x and will be removed before Drupal
9.0.0. Use the "context_definitions" key instead.
--------------------------------------------------------------------------------
Failed to execute command drush upgrade_status:analyze table_of_contents: exit status 3
Failed to run exec_dir drush upgrade_status:analyze table_of_contents; error=exit status 1
Update info.yml to accept D11 and tested in Drupalpod. Still need to run through upgrade_status
I am going to close this since there is documentation pages with screenshots available on the main page. Thanks for your assistance.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
volkswagenchick → credited markie → .
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If this applies to 2.x please reopen and update to that branch.
Drupal 7 is EOL. If you feel this issue is still prevalent for 2.x, reopen and update.
This discussion appears to include content that may easily be misinterpreted, creating the possibility of escalation. This may lead the thread in a non-productive direction. Please be mindful of how your comment may be understood and think about its impact. Even the best intentions may be lost if the content is not understood to be respectful. It is important to the community that all members are shown the appropriate amount of respect and openness when working together.
In order for our Drupal Community to thrive, we need to move forward with mindfulness and empathy.
For more information, please refer to Drupal’s Values and Principles of be constructively honest, and relentlessly optimistic → . Additionally, there are resources offered by the Drupal community to aid conflict resolution → should those be needed.
This comment is provided as a service (currently being tested) of the Drupal Community Health Team as part of a project to encourage all participants to engage in positive discourse. For more information, please visit https://www.drupal.org/project/drupal_cwg/issues/3129687 → .
damienmckenna → credited markie → .
mradcliffe → credited markie → .
mradcliffe → credited markie → .
mradcliffe → credited markie → .
mradcliffe → credited markie → .
mradcliffe → credited markie → .
mradcliffe → credited markie → .