+1 for this idea.
markie → created an issue.
MR #25 ready for review.
markie → created an issue.
markie → created an issue.
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
volkswagenchick → credited markie → .
This seems to be a duplicate of #3415921... or maybe that one duplicates this.. That being said the original patch does address the issue. The patch on #2 also does but adds scope. Granted it's a good idea to fix that as well, but I would suggest making that a separate issue, or working with the AutoBot's issue, which fixes the deprecation with a fallback function.
The MR has code outside of the patch which is outside the scope of the issue.
The patch, however, addresses the issue and applies without issue.
Looks like the composer requires section has been updated in 3.0.1 and above.. Unfortunately, they removed it all together so no dependency requirements are met. I have opened a ticket for this, but I think this ticket can be closed outdated.
Fixed a typo...
Sorry about the random MR for 8.x.. this is ready for review
Is this a duplicate of https://www.drupal.org/project/calendar/issues/3396700 🐛 Creation of dynamic properties is deprecated Needs review ? we may just be needing a release..
Marking closed outdated since there is a 10.x version released. Need to look towards 11.
volkswagenchick → credited markie → .
So curious if you feel this should be closed WAD? Or the documentation should be updated to state that "#type" is required at all times even if you are using "#theme" which seems to be the main disconnect. (at least for me in smart_trim)
seantwalsh → credited markie → .
Created a MR for smart_trim to resolve this by adding a '#type' key to the build. However it seems we should make it so if '#theme' is defined, '#type' should not be required.
https://www.drupal.org/project/smart_trim/issues/3451530#comment-15625318 🐛 Warning: Undefined array key "#type" in Drupal\Core\Form\FormHelper::processStates() Needs review
Thank you for the great reproduction steps.
Added the '#type' key to the token_browser build area. Also discussed this in https://www.drupal.org/project/drupal/issues/2700667 🐛 Notice: Undefined index: #type in Drupal\Core\Form\FormHelper::processStates() Needs work since it is a core issue. Since '#theme' is set, there's no real reason to need '#type'...
markie → made their first commit to this issue’s fork.
ChrisDarke → credited markie → .
volkswagenchick → credited markie → .
I was late.. but I was there
Here is an example of the menu using the new experimental Navigation Top Menu module
+1 for this and I would happily assist as well.
I did some PHPCS updates since I was in there.
Added D11 and reviewed. Working in D10.4....
Added the third category to the list. Smart Trim has been updated. I feel this can be closed.
merged in. thanks
Thank you
doh.. added a commit to add the cspell warning in https://www.drupal.org/project/smart_trim/issues/3439845 🐛 Fix deprecated variable in GitLab CI RTBC before seeing this one. There are some things in here that make more sense but I'll get that committed first, and see what conflicts..
MR merged. Thanks for your contributions
Added a commit to address some of the CSPELL notices
seantwalsh → credited markie → .
all tests pass in D10
MR still needs rebase
volkswagenchick → credited markie → .
hestenet → credited markie → .
Also, you may want to rebase your MR so it can work on D10..
Loaded it up in DrupalPod and re-ran with the same error.
volkswagenchick → credited markie → .
Curious.. Why not have a `--server-url` switch instead of `--omit-url`, this way build commands could utilize the functionality. And if switch is not used, default.. Just a thought
drush storybook:generate-all-stories --server-url=https://spiffy.url
tekNorah → credited markie → .
volkswagenchick → credited markie → .
0️⃣ Who is here today? Comment in the thread below with your drupal.org username to introduce yourself and tell us why you are joining us.
1️⃣ Do you have any topics to propose for the meeting today? Feel free to propose them in this thread, and then I will give them their own unique threads for discussion. Conversation moving slow? Go ahead and open your own thread in the next numeric order.
2️⃣ Do you have a recipe that you want to share? Please add a link to it in the Drupal Recipes Cookbook.
3️⃣ I’m really excited about 🐛 Install profile is disabled for lots of different reasons and core doesn't allow for that Fixed as this make the empty profile it adds unnecessary.
4️⃣ Amazing work and thank you @phenaproxima and @narendraR for moving the queue on - 5 issues rtbc! https://www.drupal.org/project/issues/distributions_recipes?status=14 → . I’ll review everything tonight. (edited)
5️⃣ Reviewing #3420516: Create config actions that can grant a set of bundle-specific permissions for all bundles of an entity type → - the revoke permission scares me quite a bit. Why is it part of this change? I think maybe having an except for these bundles option on grantPermissionsPerMediaType action would be better.
6️⃣ Love the validation in
https://www.drupal.org/project/distributions_recipes/issues/3400672 →
but filed a monster comment https://git.drupalcode.org/project/distributions_recipes/-/merge_request... - I think we should split this out from the patch and discuss in another issue. /cc
@phenaproxima
@wimleers (he/him)
Participants:
Jim Birch, Tim Lehnen, Mark Casias, Laura Johnson, Chris Burgess, Alex Pott, tavi toporjinschi, Naveen Valecha, Brian Gilbert, Bob Snodgrass (he/him), Fabian Bircher, Wim Leers, Derek Wright, Phéna Proxima, Rajab Natshah
0️⃣ Who is here today? Comment in the thread below with your drupal.org username to introduce yourself and tell us why you are joining us.
1️⃣ Do you have any topics to propose for the meeting today? Feel free to propose them in this thread, and then I will give them their own unique threads for discussion. Conversation moving slow? Go ahead and open your own thread in the next numeric order.
2️⃣ Recipe builders and developers:Convert the Standard install profile into a set of recipes - NEEDS REVIEW!!!!
3️⃣ Developers:Decide whether checkpoint() should only create a checkpoint when it needs to - NEEDS REVIEW
4️⃣ Developers:[PP-1] Robustly validate the structure of recipe.yml - Postponed, but lots more work has been done on it.
5️⃣ New Idea:Allow config actions to be applied to all config items whose names match a particular pattern
6️⃣ Recipe creators:
Please feel free to add your recipes to the Recipes Cookbook.
7️⃣ Drupalcon Portland - Who's going? What's going on?
8️⃣ @markie asks: Anyone going to MidCamp? Would you like to lead some contribution there?
Participants:
Jim Birch, Mark Casias, Laura Johnson, Bob McDonald, Tim Lehnen, eclipsegc, Rajab Natshah, Fabian Bircher, Wim Leers, Bob Snodgrass (he/him), Phéna Proxima
0️⃣ Who is here today? Comment in the thread below with your drupal.org username to introduce yourself and tell us why you are joining us.
1️⃣ Do you have any topics to propose for the meeting today? Feel free to propose them in this thread, and then I will give them their own unique threads for discussion. Conversation moving slow? Go ahead and open your own thread in the next numeric order.
2️⃣ Recipe builders and developers: Lots of work happening onConvert the Standard install profile into a set of recipes[#3417835]
3️⃣ Do you have any recipes that you would like to share? Please add them to the Recipes Cookbook.
4️⃣ Is there a good reason to actually change the standard profile over to being recipe defined?
5️⃣ Error when installing a recipe that has configuration files already in the system, even if there is no difference[#3390916]
6️⃣ Getting user input during / before applying a recipe[#3303126]
Participants:
Jim Birch, Wim Leers, Bob Snodgrass (he/him), eclipsegc, Jim Vomero, Tim Lehnen, Laura Johnson, Stephen Mustgrave, Hector Lopez, Fabian Bircher, Phéna Proxima, Mark Casias, Derek Wright, Leslie Glynn, Brian Gilbert, Alex Pott
0️⃣ Who is here today? Comment in the thread below with your drupal.org username to introduce yourself and tell us why you are joining us.
1️⃣ Do you have any topics to propose for the meeting today? Feel free to propose them in this thread, and then I will give them their own unique threads for discussion. Conversation moving slow? Go ahead and open your own thread in the next numeric order.
2️⃣ Site Builders and Developers: Could use review on Model core's standard install profile as recipes.
3️⃣ I have been plugging away at my Saplings suite of recipes.
4️⃣ Is there a good place to look for opportunities to contribute, for someone looking to help? Alternatively, can someone suggest where someone new to the initiative could help out right now?
5️⃣ I know a big request is that Recipes work with Project Browser. Before that can happen, Recipes need to be on drupal.org.Drumm stated the following this morning.I’d like to see the UX ideas for browsing & installing recipes before even thinking about which content type they might be or anything else technical.
6️⃣ Do you have any recipes that you would like to share? Please add them to the Recipes Cookbook. (edited)
7️⃣ https://project.pages.drupalcode.org/config_inspector/ I just would like share this link again, Wim's chart is so helpful to see progress on the configuration validation issues. Thanks to
@borisson_
Participants:
Jim Birch, Alex Pott, Fabian Bircher, Bob McDonald, Stephen Mustgrave, Laura Johnson, Tim Lehnen, Rajab Natshah, Abhishek Mazumdar, Bob Snodgrass (he/him), Mark Casias, Derek Wright, borisson_, Wim Leers, Phéna Proxima, Neil Drumm
0️⃣ Who is here today? Comment in the thread below with your drupal.org username to introduce yourself and tell us why you are joining us.
1️⃣ Do you have any topics to propose for the meeting today? Feel free to propose them in this thread, and then I will give them their own unique threads for discussion. Conversation moving slow? Go ahead and open your own thread in the next numeric order.
2️⃣ I had fun over the holidays breaking my starter recipe into more composable chunks.https://github.com/kanopi/saplings
3️⃣ == Asking for Input ==@André Angelantoni love to get input in my input design: #3303126: Getting user input during / before applying a recipe →
4️⃣ Hoping for a better logic on ensure of existance of a config.Is it an action or an if statement?ensure_exists with grantPermissions and simple_config_update[#3306291]
Participants:
eclipsegc, Jim Birch, Rajab Natshah, André Angelantoni, Tim Lehnen, Mark Casias, Bob Snodgrass (he/him), Eric Volkernick, Naveen Valecha, Leslie Glynn, Fabian Bircher, Wim Leers, Gus Austin, Alex Pott, Phéna Proxima, Laura Johnson, Michael
tekNorah → credited markie → .
👋🏼👋🏼
+1 for Naveen
+1 for Allan
+1 for Kristen
+1 for Pedro
+1 for Matt.
tekNorah → credited markie → .
tekNorah → credited markie → .
volkswagenchick → credited markie → .
merged. .Thanks for hopping on this at FLDC!
Release created.
Changelog updates ready for approval
Merging this in. Thanks