PHPStan fails for Next Minor

------ ------------------------------------------------------------- Line src/TruncateHTML.php ------ ------------------------------------------------------------- 90 Method Drupal\smart_trim\TruncateHTML::init() should return DOMDocument but returns DOMNode. 🪪 return.type ------ -------------------------------------------------------------

Comments & Activities

Issue created by @lostcarpark
Merge request !107Fix return type of TruncateHTML::init() → (Merged) created by lostcarpark
Pipeline finished with Failed
about 2 months ago
Total: 209s
#443080
Pipeline finished with Success
about 2 months ago
Total: 218s
#443082
Comment about 2 months ago →
🇮🇪Ireland lostcarpark
Changing return type of `TruncateHTML::init` from `DOMDocument` to `DOMNode` resolved the issue.

the `init()` method calls `HTML::load()` it would seem that this was always returning a `DOMNode`, but hadn't specified return type, so it wasn't caught.

Ready for review.
First commit to issue fork.
Pipeline finished with Skipped
about 2 months ago
#443545
Comment about 2 months ago →
System Message

markie → committed e3421a16 on 2.x authored by lostcarpark →
Issue #3511681 by lostcarpark: PHPStan fails for Next Minor
Comment about 2 months ago →
🇺🇸United States markie Albuquerque, NM
Looks good. Thanks!
Comment about 1 month ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

PHPStan fails for Next Minor

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!107PHPStan fails for Next Minor
Merged

Comments & Activities

PHPStan fails for Next Minor

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!107PHPStan fails for Next MinorMerged

Comments & Activities

!107PHPStan fails for Next Minor
Merged