- Issue created by @lostcarpark
- 🇮🇪Ireland lostcarpark
I have created a SmartTrimHooks service and moved the current hooks into it. I added legacy hooks for backwards compatibility.
I had to use ContainerBuilder in the unit test setup, as I was getting an error due to container not being initialised.
I am getting a PHPStan warning for "next minor". I don't think it's related to this change, so I'll open a separate issue to address it. We might want to address that, then rebase this with it's merged.
- 🇮🇪Ireland lostcarpark
The PHPStan failure should be resolved by 🐛 PHPStan fails for Next Minor Active , at which point this can be rebased cleanly.
- 🇺🇸United States markie Albuquerque, NM
This looks good and I'll rebase here in a few. I think we need to move the TruncateHTML functionality into a service all together. There might be a ticket for that already.. Thanks for these fixes.
- 🇮🇪Ireland lostcarpark
Rebased and tests are now passing.
I agree TruncateHTML should be a service. I'll check if there's an issue, and open one if not.
- First commit to issue fork.
-
markie →
committed ac0f5406 on 2.x authored by
lostcarpark →
Issue #3511505: Update Smart Trim to use Object Oriented Hooks
-
markie →
committed ac0f5406 on 2.x authored by
lostcarpark →