🇦🇺Australia @Nadim Hossain

Hi,
I am having this issue in my current project using the TFA Email OTP Plugin and I am using the tfa version 1.7. Till this is fixed and works with 2.x, creating a temporary patch to use it in my project against 1.7 version.
Setting the validation period to 10 minutes to match the highest validation period for a code given by the TFA Email OTP Plugin settings.

Thanks @cmlara

nadim hossain → created an issue.

Adding this patch version to get it used in the project for now -

Nadim Hossain → created an issue.

Re-rolled the patch 23 against the new release 8.x-3.6

Re-rolled the patch 12 against - 8.x-3.6

Re-rolling the patch against 1.2.5

Re-rolled the patch against 7.x-dev

Re-rolled the patch for the new release of Entity Embed version 1.6
I couldn't push the merge request resolved conflict though,

Renamed the plugin -

Nadim Hossain → created an issue.

I have faced the same issue and the patch #3 works for me. Just re-rolling it for version 8.x-1.1 to use it with the latest 1.x release.

Thanks @acbramley
I have re-rolled it from #21 against 10.2.x

Re-rolled the patch against 10.2.x, still testing needs to be done on this re-rolled patch.

We have done some testing with the new changes with the changed module name and related settings from @matthew.hallsworth.dpc and it looks good, working properly. Here are couple of screenshot from the testing branch with section.

This is the patch version against 1.x -

Nadim Hossain → created an issue.

Adding this patch file to use it in the composer patch instead of using the merge request diff until the merge request is merged and released.

Thanks for the review @matthew. I have update the merge request and adding a updated patch as well.

Created a merge request and also added this patch version to use it in the composer to avoid using the merge request diff directly.

Nadim Hossain → created an issue.

I have updated the post and media api end points. This statuses/update end point for v1.1 seems to be dead and generate the error above. The dependency package abraham/twitteroauth is updated to be compatible with twitter api 2 and by default use it when requesting. Temporary I have made the "Callback function for the authentication process" when adding user to use api 1.1, cause migrating that part will require a bit. more work. Currently this will enable to continue using this module while working on the code migration for authentication process.

Hi @mindcraft,

Thanks for creating this issue. I saw the fork and the branch you created, do not see any changes pushed in there. Let me know if you are still actively working on this. I am asking cause I just started working on it as well for my project and If I find something, I might push it here for testing, unless you push the update first :)

Thanks again

Thanks @Kristen. I have updated the patch according to the comment you made and it is ready for testing now.

Submitting a patch version to use it against the 8.x-3.0 version in composer. Also I have tested this and looks fine.

I had the same issue, tested my project with this patch and it is working fine now. Once someone reviews it, I think we can move it to the next stage.

Re-rolled the patch after the new release which ad a line change in that file.

Changed the base to be latest working version as it still exists in that.

This is the patch.

Nadim Hossain → created an issue.

Missed the use Drupal\Core\StreamWrapper\AssetsStream; statement in the last one, fixed it.

Thanks YahyaAlHamad, I was having the same issue. As you mentioned this issue is there for 3.x and I am using 3.x version, so just rerolled it against 3.x version.

Re-rolled the patch against 6.x

Because of the recent changes in 10.1.x, the patch in #85 does not get applied. So just re-rolling it to be compatible with 10.1.x

#60 missing "datetime", #62 was working fine for me in 9.5.9, so rerolled the same patch for 10.1.x

Hi @greggles
Sorry to be a pain, but if you can make either Joseph or @nord102 to be the maintainer to do the release it will be good. Also I have done review for the "Automated Drupal 10 compatibility fixes" issue. If it is enough and possible please make me a maintainer and I can just do the release. I do not see much activity from the maintainer and we need this module to be compatible with D10 to run the d10 upgrades.
Thanks

I have reviewed the changes and it looks like pretty straight forward change and good to be merged. This module blocking the d10 upgrade for the project I am working now, trying to get a release for this. Don't see much activity from the maintainers.

Kristen Pol → credited Nadim Hossain → .

Thanks @DishaKatariya
I am moving this to the next stage.

Hi,
I have fixed the above issues that I mentioned during testing. I have turned off the drupal form validation for the checkbox,tableselect that are used to select the different revision version. As this is using ajax to load the dynamic options, the drupal for validator create issues. Looks like a common issue in drupal when using ajax. Couple of suggestions that helped me are from the following links -
Reference 1
Reference 2 →

This is the field that was creating issue - revision tableselect

Also from the previous patch this part was added to show and select the latest revision only for the 1st page of the pagination, but I think it should be shown at the top of every pagination page, that is why I have reverted back the changes to default. Following code is from the previous patch -

+    // Add the latest revision if this is the first page of results.
+    if ($this->database->getPagerManager()->getPager()->getCurrentPage() === 0) {
+      $options = [
+        static::LATEST_REVISION => [
+          'revision_id' => [
+            'data' => $this->t('Latest revision'),
+          ],
+          'state' => [
+            'data' => $this->t('Automatically determines the latest revision at time of transition.'),
+            'colspan' => $entity instanceof RevisionLogInterface ? 4 : 1,
+          ],
         ],
-      ],
-    ] + $options;
+      ] + $options;
+    }

I have tested my new patch locally, but need someone else to review this and then we can move this to testing.
Thanks

Rerolled the patch to be compatible with php 8.1 upgrade.
just one minor change. From if ($role_enabled['target_id']) to if (isset($role_enabled['target_id']))

Thanks Anas for pointing out the similar patch and looks like the other patch has more possibility to get merged. I will apply the other patch you mentioned in our project and do some testing, after that will be closing this issue.

I have done some testing as well just to check the patch I submitted works as expected and patch #67 is working for me. Please see the screenshots below -

Patch #63 was missing some new files that got missed during the re roll. I have updated the patch. Please try using this and see if it works. Also keep in in mind as rpayanm mentioned, using other patches might create conflicts as well.

Rerolled the patch to match with the new release 8.x-1.3

Just updating the above patch to return null and also the function doc to say return should array|null

I am submitting this patch to be used in the composer for now against this project until the merge request gets merged and released into the new version.