- Issue created by @GuillaumeG
- last update
over 1 year ago 6 pass - @guillaumeg opened merge request.
- Status changed to RTBC
over 1 year ago 7:36am 14 July 2023 - 🇮🇳India keshavv India
MR looks good to me, We need the mentioned use statement as its object has been created 2 times in the class.
We can go with the MR.
Thank you. I mentioned this in a comment against the issue that introduced the problem (sorry I should have raised it more prominently): https://www.drupal.org/project/fast_404/issues/2820923#comment-15146433 🐛 Fast404 path checking is incompatibility with multilingual paths Fixed
Would it not be preferable to switch both instances of Fast404 to use the factory rather than bring the use statement back?
- last update
over 1 year ago 6 pass - 🇦🇺Australia Nadim Hossain
Submitting a patch version to use it against the 8.x-3.0 version in composer. Also I have tested this and looks fine.
- Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks, everyone. Assigning to myself to get this merged.
@Timmy_Cos Rather than do your suggested change right now, I'll get this in due to the fatal error. You can create a separate issue for you suggestion and link to it here.
@Nadim Hossain Fyi, for future reference, you can use an MR as a patch rather than creating a separate patch, e.g.
https://git.drupalcode.org/project/fast_404/-/merge_requests/6.diff
https://git.drupalcode.org/project/fast_404/-/merge_requests/6.patch
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Bumping to critical since it's a fatal error.
-
Kristen Pol →
committed 9cc7e04d on 8.x-3.x authored by
Nadim Hossain →
Issue #3374546 by GuillaumeG, Nadim Hossain, Kristen Pol, Timmy_Cos,...
-
Kristen Pol →
committed 9cc7e04d on 8.x-3.x authored by
Nadim Hossain →
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 3:05am 10 August 2023 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
This is merged. I'll need to check if this was in a release.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Change was merged 30 May and a release was created 11 June so the issue is in the release so we need to do a new release ASAP.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
- Status changed to Fixed
over 1 year ago 3:19am 10 August 2023 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA