- Issue created by @yahyaalhamad
- 🇯🇴Jordan yahyaalhamad Palestine
This patch is for 2.x, but the problem also exist in 3.x
- Status changed to Needs review
over 1 year ago 10:06am 11 July 2023 - last update
over 1 year ago 6 pass - last update
over 1 year ago 6 pass - 🇯🇴Jordan yahyaalhamad Palestine
Since by default, the assets folder is in 'sites/default/files', we don't want to skip everything inside of it, added a suffix 'js' and 'css' to solve this.
- last update
over 1 year ago 6 pass - 🇦🇺Australia Nadim Hossain
Thanks YahyaAlHamad, I was having the same issue. As you mentioned this issue is there for 3.x and I am using 3.x version, so just rerolled it against 3.x version.
- last update
over 1 year ago 4 pass, 4 fail - last update
over 1 year ago 6 pass - 🇦🇺Australia Nadim Hossain
Missed the
use Drupal\Core\StreamWrapper\AssetsStream;
statement in the last one, fixed it. - 🇮🇳India siddharthjain
I was running into this issue and have applied the patch mentioned in #7. It applies smoothly. Thanks for the patch :)
- First commit to issue fork.
- Merge request !7Issue #3373845: Fast404 prevents css/js assets from generating when aggregation is enabled on Drupal 10.1 → (Open) created by jvbrian
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 6 pass I created the issue fork, I applied the fast_404_css_js_aggregation-3373845-7 patch. I also tested the solution, and found that using fast_404 and aggregation enabled, both js and css tablets are being generated.
- Status changed to RTBC
over 1 year ago 4:03pm 22 July 2023 - last update
over 1 year ago 6 pass - last update
over 1 year ago 6 pass - last update
over 1 year ago 6 pass - Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Assigning to myself to see if I can get this one in soon.
- last update
over 1 year ago 6 pass - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks, everyone, for the great work. I see there are patches for both 2.x and 3.x branches so I'll get both of these in. There are some minor formatting and wording nitpicks, but I will fix these myself before committing.
@siddharthjain_7998 In the future, please don't add a patch that's already been added. You didn't say you tested the patch at all... just that it "applied smoothly". If you are going to check an issue, then it is best if you test it and explain how you tested it.
@jvbrian In the future, there is no need to create a MR if there is a patch and you aren't making any changes. Thank you for explaining that you tested it.
@ikit-claw Fyi, it probably wasn't clear but the MR was just the same as #7, so there was already a patch available.
- last update
over 1 year ago 6 pass - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Passed on 10.1:
https://www.drupal.org/pift-ci-job/2740780 →
and this has been tested on 10.1 and the fix targets 10.1+ so this looks safe to merge.
-
Kristen Pol →
committed 1cd05709 on 8.x-2.x authored by
YahyaAlHamad →
Issue #3373845 by YahyaAlHamad, jvbrian, Nadim Hossain, ikit-claw,...
-
Kristen Pol →
committed 1cd05709 on 8.x-2.x authored by
YahyaAlHamad →
-
Kristen Pol →
committed a98b2f5a on 8.x-3.x authored by
Nadim Hossain →
Issue #3373845 by YahyaAlHamad, jvbrian, Nadim Hossain, ikit-claw,...
-
Kristen Pol →
committed a98b2f5a on 8.x-3.x authored by
Nadim Hossain →
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 8:28pm 15 August 2023 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
This has been merged for both 2.x and 3.x and will be in the next 3.x release though I don't think there will be any more 2.x releases. I did make some wording and formatting changes.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 4:10pm 20 September 2023 - 🇺🇸United States janusman
To feed the search engines: This is related to Change Record https://www.drupal.org/node/3301716 →