Palestine
Account created on 9 January 2019, about 6 years ago
#

Merge Requests

Recent comments

🇯🇴Jordan yahyaalhamad Palestine

Another try to fix the indentation in twig, it seems vscode shows me that the indentation is 2 spaces, but it is actually 4 spaces

🇯🇴Jordan yahyaalhamad Palestine

The new changes were committed to fix the problems. I was not sure about the `SeedsManager.php` point, but I added a better description for the constructor, I made sure to reference other modules to make sure everything is right.

🇯🇴Jordan yahyaalhamad Palestine

This is an old issue, but I had problems with caching when different users are logged in, and other times, a 403 error is cached, this cache attempts to fix the issue by adding the dependency using the view render array, I made sure to also add the cache contexts to fix the issue of different users when attempting to use the API. Also, make sure to add cache dependency when the view access is denied.

🇯🇴Jordan yahyaalhamad Palestine

The line:

list($target_type, $revision_type) = array_pad(explode(':', $target_type_and_rev), 2, NULL);

throws a warning, I added '@' to suppress it since $revision_type is expected sometimes to be NULL.

Applied on Core 10.2.X

🇯🇴Jordan yahyaalhamad Palestine

Patch for 10.2.x for a temporary fix until the new version.

🇯🇴Jordan yahyaalhamad Palestine

Thank you @thakurnishant_06, I have discussed with my team, and it seems installing the latest stable version is more efficient than trying to update them manually. The only exception is alpha versions since they are still unstable by theory.

🇯🇴Jordan yahyaalhamad Palestine

I can confirm, this issue is happening to me, when disabling the 'search_api' module, the pager works again. It is related to the search_api module.

🇯🇴Jordan yahyaalhamad Palestine

Tested the changes from #5, it works, thank you. I converted it to a patch to easily apply it until the MR is accepted.

🇯🇴Jordan yahyaalhamad Palestine

Closing this since this will be fixed in seeds_layouts

🇯🇴Jordan yahyaalhamad Palestine

The new once function messes up with the fivestars widgets (and possibly with the other types too), it seems it only runs once (which is expected), but because of this, the JS will not execute again and the widget will not render the fivestars after an ajax submit, is this intentional? Attached a video that explains the weird bug. I fixed it by removing the once completely, but I'm not sure if this is optimal

🇯🇴Jordan yahyaalhamad Palestine

We are planning to rework the styling and the icons in the future, especially the styling.

🇯🇴Jordan yahyaalhamad Palestine

Since by default, the assets folder is in 'sites/default/files', we don't want to skip everything inside of it, added a suffix 'js' and 'css' to solve this.

🇯🇴Jordan yahyaalhamad Palestine

Yea, somehow, the zip file was not generated, I made a new version, try to install 2.0.4

🇯🇴Jordan yahyaalhamad Palestine

Fixed some compatibility issues with Gutenberg, also, added a new experimental checkbox for fixed elements.

Production build 0.71.5 2024