- 🇮🇳India Koustubh Dudhe
Koustubh Dudhe → made their first commit to this issue’s fork.
- Merge request !4Issue #3289235: Automated Drupal 10 compatibility fixes → (Open) created by Koustubh Dudhe
- First commit to issue fork.
- Merge request !5Issue #3289235: Automated Drupal 10 compatibility fixes → (Open) created by yahyaalhamad
- Status changed to RTBC
over 1 year ago 10:22am 4 August 2023 - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 4:04pm 31 October 2023 - Status changed to RTBC
about 1 year ago 4:05pm 31 October 2023 - 🇺🇸United States annie2512
I have installed the Patch #7 and Upgrade Status module says the rate_limits module is now compatible.
But when I try to composer update to D10, I get the error below. Not sure what I am missing. I even installed mglaman/composer-drupal-lenient and added drupal/rate_limits to the allowed-list of lenient modules. But it still gives this error.Problem 1
- drupal/rate_limits dev-2.x requires drupal/core ^8 || ^9 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but it conflicts with your root composer.json require (^10).
- drupal/rate_limits 2.x-dev is an alias of drupal/rate_limits dev-2.x and thus requires it to be installed too.
- Root composer.json requires drupal/rate_limits 2.x-dev -> satisfiable by drupal/rate_limits[2.x-dev (alias of dev-2.x)].Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
- 🇧🇪Belgium kensae
Instead of using the patching the 2.x-dev version, I've added the issue fork repository in my composer.json. Patching doesn't work because composer is checking the version requirements before the patch is applied.
- 🇺🇸United States annie2512
Just wanted to update that this issue with the rate_limits module is resolved.
The lenient config was not being picked up because I had deleted my composer.lock and vendor folder and was doing a 'composer install'.
So I changed composer.json to core version 9, generated lock and vendor, and then updated composer.json to core version 10, and ran composer update and the lenient config kicked in, and I had a successful D10 build. - 🇮🇳India shubhangi1995 GURGAON
The above merge https://git.drupalcode.org/project/rate_limits/-/merge_requests/5/diffs is breaking phpunit test cases due to theme.
- Status changed to Needs work
11 months ago 1:29am 14 December 2023 - Status changed to Needs review
11 months ago 1:33am 14 December 2023