I'm sorry for spamming this issue queue. I've made some modifications to the patch for 2.0.0-alpha2 to make sure it provides the same functionality as the merge request does.
Just another patch to fix the exception: TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given
In #16 I accidentally left out the GiftcardActivatedEvent class so I've re-uploaded the patch in #17
We encountered the same issue and solved by adding the --uri paramter to the drush command.
So instead of running
drush filefield-to-media:copy upload upload_media document field_media_document node
run
drush filefield-to-media:copy upload upload_media document field_media_document node --uri=https://www.yoursite.com/
Maybe this should be added to the readme of this module.
I've also created a patch that works for version 2.0.0-alpha2
I've moved the patch from #15 into a merge request. I've tested it myself on a project we're working on and it works.
I've moved the patch of #34 into the MR, because this was the last patch that worked for me.
And made some minor modifications to move events in the correct order.
It uses the default consent mode form google tag module if consent mode is enabled and reorders de dataLayers to execute the default consent mode and the consent mode update from this module, before the container initialization and other google tag events.
kensae → created an issue. See original summary → .
I've created a 2.0.x branch but this branch needs testing
I've fixed some merge conflicts.
To update this, we 'll need fixes to the issue
https://www.drupal.org/project/commerce_giftcard/issues/3181301
✨
Need to activate (Status enable) a gift card only when the payment is confirmed
Needs review
to make sure the GiftcardActivatedEvent is available in the 2.x branch of the Commerce Giftcard module.
The Merge request is currently failing for that branch, so I'll have a look into that first.
I've added onInit, onAccept and onDecline options to the Klaro App entity and I've updated the form in MR!79
I think the main problem of this issues is fixed in https://www.drupal.org/node/3227250 → ?
Thanks for merging!
I think I'm done with my changes.
If I encounter any issues I'll open a new one in the issue queue.
I made some small changes to the if statements to check if a value exists in the form_state input / values array on the given key
I was not able to update to beta4 in Drupal 11 because of the webform_options_limit dependency in info.yml
When I try to update I get the following error:
I have webform 6.3-beta installed with it's webform_options_limit submodule.
I thought adding a composer.json would solve this issue.
When I pull this issue branch with the composer.json included, I don't get this composer errors
MR18 in this issue branch covers the existing functionality of the Invite module for both Drupal 10 & 11.
I'm sorry for replying this late. It seems good implementation. I'll test it right away.
I can confirm the the fix in the issue sukr_s has referred to, solves it for me.
In my case I had a couple of fields that were filled based on the value of another field after an ajax callback.
Based on the fact if these fields have a value, the submit button's disable attribute would change from disable to enabled state.
Before the patch, the submit button keeps the disabled state, even if all fields have a value.
After patching drupal core 10.4 with the patch from the MR from issue
#2468860
🐛
Form field #states not woring with entity reference fields
Active
, the submit button gets enabled after all fields are filled out.
I've tested the change myself with a website of one of our clients.
It's running in production for two weeks now.
I modified the MR to solve the issue I mentioned about the possibility to select a an option that's greather than the remaining number.
I've tested the MR with both the Number Limit handler and the Options/Checkbox with number limit handler
The Number Limit handler works as expected!
On the Options/Checkbox with number limit handler there 's a little bug that allows you to select more places then available.
I think it's something ajax related. I'll check if I can find more details why it's failing.
Ok fine, if that's ok I'll work on the issue branch in this issue?
Then I still think we're talking about a different use-case.
In my case I don't want to set the a limit per option, but the selected option (1,2,3,4) is added to the number of allowed subsciptions, as would a number field in the NumberLimitHandler.
If I have f.e. an event with a maximum of 20 seats, and each registrant can reserve 1-4 seats (select field) then:
- I can have 5 registrants (form submissions) who select each 4 seats
- 10 registrants who select each 2 seats
- 3 registrants who select 4 seats and 2 registrants who select 3 seats and 2 registrants who select 1 seat
- ... and various other combinations.
I'm sorry if I'm wrong but I don't think I can accomplish this in
Yes, I did read your last comment, but I'm not sure how I would accomplish this with the following settings.
Maybe I'm missing something.
I'm sorry for replying this late.
What I'm actually trying to accomplish is for example a registration form where visitor can register a number of attendees for an event. The field to indicate the number of attendees would be a select field.
In this case I would use a select field with the options 1,2,3,4 and the NumberLimitWebformHandler.
So instead of a webform element Number, I would like to use a select element just to enter a number.
Would you mind I reopen this issue for this specific case?
Probably I'll have to extend the patch and check if the select only contains numeric options before it is marked as a valid field instance to use in the NumberLimitWebformHandler.
tostinni, the removed lines in the patch are moved to seperate function handleCustomFields.
I think it's just a matter of updating the requirement in the composer.json file to:
"dompdf/dompdf": "^1.0 | ^2.0 | ^3.0"
kensae → changed the visibility of the branch 3494740-pass-entity-viewmode to active.
kensae → changed the visibility of the branch 3494740-pass-entity-viewmode to hidden.
After applying the changes from MR !77 the issue seems to be fixed.
See attached screenshots.
After I created the merge request, there was a new release for Linkit, reverting a previous commit.
I've merged the new version in the issue fork, but for some reason, the MR doesn't update. So when I try to apply the merge request as a patch on the latest version it fails.
I've edited the patch manually:
3481475-add-entity-bundle.patch →
I know this isn't the preferred way.
Which line is failing?
When I'm using the issue fork directly in my composer file to load, it seems to work.
A d10 release would be great indeed. It's only a matter of changing the core_requirements and we're good to go.
This issue is introduced again with facets dev-3.0.x, using facets exposed filters, search_api 1.34.0 and views_bulk_operations 4.2.6 in Drupal 10.2.5
I've updated the patch for the combination of this versions.
I've fixed the failing test. It didn't include the hostnames.
kensae → created an issue.
kensae → changed the visibility of the branch 3241153-move-helper-functions to hidden.
This would be very useful to extend ckeditor: for example to implement the 'Balloon editor' in a custom module.
kensae → made their first commit to this issue’s fork.