Batch API returns a NULL response if the query parameters are wrong

Open on Drupal.org →

Created on 26 January 2022, about 3 years ago

Updated 4 February 2023, about 2 years ago

Hello, we are experiencing a problem. Our website has many operations involving batch API, and our users are experiencing a problem with them, apparently, if check_logged_in=1 is in the URL, it causes this error:

Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\ControllerDoesNotReturnResponseException: "The controller must return a "Symfony\\Component\\HttpFoundation\\Response" object but it returned null. Did you forget to add a return statement somewhere in your controller?" at /var/www/html/nbu/public_html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php line 98,

for example, going into "batch?id=273" works fine, but "batch?id=273&op=start?check_logged_in=1" causes the error.

I'm still not sure why the check_logged_in parameter sometimes appears randomly, was this a new change that I missed somehow?

Thank you.

🐛 Bug report

Status

Needs work

Version

9.5

Component

Last updated 15 days ago

Maintained by
🇬🇧United Kingdom @John Cook

Created by

🇯🇴Jordan yahyaalhamad Palestine

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Sign in to follow issues

Merge Requests

!1728Batch API returns a NULL response if the query parameters are wrong
Closed
🇯🇴Jordan yahyaalhamad
updated 3 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Merge request !1728Fix an issue where batch.inc will return NULL if the batch operation is wrong → (Closed) created by yahyaalhamad
Comment about 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Issue will need a valid test case.

Also should decide if it's going to be fixed in an MR or patches but mixing the two causes unneeded noise.
Status changed to Postponed: needs info 12 months ago2:49am 11 April 2024
Comment 12 months ago →
🇦🇺Australia pameeela
Marking postponed for more info, it is unclear why the URL would have invalid params. If someone can provide steps to reproduce this, it is likely to progress, otherwise it may be closed if no further info is provided.
Comment 3 months ago →
System Message
smustgrave → closed merge request !1728
Comment 3 months ago →
🇺🇸United States smustgrave
Since no steps to reproduce have been provided since being requested in #17 going to close out.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024