🇮🇳India @siddharthjain

I did help on welcome kit packaging for Drupal Camp Pune 2024.

I did helped on website work for Drupal Camp Pune 2024.

This only shows the Save button on modal, the published status checkbox doesn't shows up in modal.

siddharthjain → created an issue.

Hey @Kristen Pol I was checking the slack channel and found the discussion over there, I did joined the session(Drupal Starshot Demo Design System with Kristen Pol) on 30th July.

Here is the attached patch for 8.x-2.5 version, please review. Thanks!

I have made the changes as per description and it fixes the problem.

Attaching a video reference as well.

siddharthjain → created an issue.

The changes for D11 compatibility has been implemented under this MR: https://git.drupalcode.org/project/better_links/-/merge_requests/4
So, we can close this ticket.

@saschaeggi

Changes looks good now, now the min-width is around 240px, thanks!

Adding after screenshot also.

@saschaeggi The above changes fixes the drop down hiding issues, it was also present on content types page but it was fixed there as well. Adding the screenshots for the reference. Thanks for the changes.

@saschaeggi Changes looks good to me. I have tested it on Chrome, Safari and Firefox browser, it works fine. Attaching screenshot for reference as well.

Also I have one suggestion can we use the min-width to be the one which shows up when page is opened by default which is around 360px?

I am also facing the same issue. While generating the text using Text Complete feature using OpenAI CKEditor integration submodule, it gives "The website encountered an unexpected error. Please try again later." error in CKEditor.

#11 worked for me as well on Drupal 10.2.6 and PHP 8.2, thanks very much!

The above changes looks good, the slider is also working fine. Attaching the screenshot for reference.

I have tested the functionality, there is one concern after switching to this Merge request !72 , the slider value changed to float, earlier with the jquery_ui_slider dependency it was taking the integer. I have added screenshots for reference. Other than this the functionality works fine.

Here is the updated patch, which includes updates related to core_version_requirement and removed drupal/core from composer.json as its is not required as per D.O documentation https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file →

siddharthjain → created an issue.

Moving to Drupal.org Project Ownership.

Hello everyone!

After the above changes I was able to configure the CKEditor Widgets Bootstrap Grid for all the text formats. Attaching screenshot for reference. Thanks!

I would love to adopt this module, we have been using this module in our projects and will take care of the future releases and compatibility. I have worked on some of the previous compatibility issue for the same module as well, and its been waiting for its D9 and D10 releases so I think I can handle this module. Thank you :)

siddharthjain → made their first commit to this issue’s fork.

Update the documentation to include another module(CKEditor Widgets Bootstrap Grid), which doesn't have CKEditor5 plugin ready.

Hi there,

I have reviewed the above MR with the below steps performed:

1. Added a exposed filter using Number type field
2. Added Number filter plugin in BEF and added min and max values

Here the outcomes:

1. The Number filter plugin gets added
2. After saving the BEF settings the min and max values are not getting saved.

We can update the default value for min and max fields to look like this:
'#default_value' => !empty($this->configuration['min']) ? $this->configuration['min'] : '',

Other than this the Number filter plugin works smoothly, thanks for the functionality.

I think the above issue is not related to BEF, there has been open core issue for the same. Here is the link to the issue: https://www.drupal.org/project/drupal/issues/3252288 🐛 Argument #1 ($value) must be of type Countable|array, null given in count() (line 57 of core/lib/Drupal/Core/Render/Element/Radios.php). Needs work

Thanks for the above changes, the changes in open MR-1 makes module D10 compatible, it can be merged.
I am attaching the patch if anyone needs. Thanks!

The above patch applies smoothly and the dependencies has been updated as per this article: https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-8-or-... →

The above changes looks good to me, the documentation can be updated.

siddharthjain → created an issue.

Here is the patch with required changes. Please review.

siddharthjain → created an issue.

Here is the interdiff file attached.

Thanks for the patch @aziza_a, we have been facing issue because of member function get() called on null, after updating site to Drupal latest version

Error: Call to a member function get() on null in Drupal\context\ContextMenuActiveTrailsCacheContext->getReactingLinks() (line 31 of /app/docroot/modules/contrib/context/src/ContextMenuActiveTrailsCacheContext.php).

Here is the updated patch for 5.x-version and error being resolved. Please review.

The patch shared in #9 applies smoothly. Thanks for the patch @Goldfit

@Wim Leers Actually I am not able to recreate the issue after removing patch again and it is working fine, btw specifically what markup were you referring?

Yes, using this MR(https://git.drupalcode.org/project/entity_embed/-/merge_requests/26) fixes the problem.
Thanks for the MR.

@Wim Leers, Yes I have updated the embed module to latest version i.e. 1.7

Yes, I am also facing this same above issue after using the latest dev version while updating from Ckeditor4 to Ckeditor5, the editor does not loads up. Also if I disable embed options on a text format the editor loads normally without any error, also my site is already on D10 latest version

The patch added in #7 makes Seven theme compatible with Ckeditor5. Thanks for the patch @jrglasgow

Hi @akshay_d

Thanks for the patch, it will be good to have this feature added in the module.
I have reviewed it, it looks good.

Thanks @jrglasgow for the patch in #10. It applies applies smoothly.

@rsslwa
I was also facing the same issue, this documentation helped me to download the libraries using the composer rather than downloading directly. You can also refer here:
https://www.drupal.org/docs/8/modules/webform/webform-frequently-asked-q... →

siddharthjain_7998 → created an issue.

I was running into this issue and have applied the patch mentioned in #7. It applies smoothly. Thanks for the patch :)

As per this article( https://www.drupal.org/node/3307518 → ) the core/popperjs is deprecated in Drupal 10, so we need to implement ckeditor tooltip using Floating UI library in Drupal 10

siddharthjain_7998 → made their first commit to this issue’s fork.

Thanks for this super fast patch. I was going to add same:)
I have reviewed the MR, it works smoothly.

siddharthjain_7998 → created an issue.

The patch shared above, applies smoothly on Drupal 10 site.

Here's the patch for Pendo's module alpha version. Please review.

Thanks, the patch shared above in #2 works perfectly.

Here is the patch for same. Please review.

siddharthjain_7998 → created an issue.

Here is the updated patch for Drupal 10 compatibility.
The above patch mentioned in #7, doesn't updates core_version_requirement and doesn't deletes drupal/core in composer.json. So here is the updated patch. Please review.

Thanks @amitgoyal, #16 works for me.

Just a heads up, while updating the module to another version using composer, you might face issue while applying the patch because it installs the module using the dist version by default and this version includes project information to the bottom of the *.info.yml file which is added by Drupal’s packaging system(like example below).

# Information added by Drupal.org packaging script on 2019-05-03
version: '8.x-1.1'
core: '8.x'
project: 'module_name'
datestamp: 1556870888

There an open core issue for the same( https://www.drupal.org/project/drupal/issues/3036459 🐛 Packaging info from .info.yml often creates conflicts when patching Active ). Also as per comment #11, there is an short-term workaround for it as well, we can follow this https://chromatichq.com/insights/patching-info-files-composer

Here is the attached screenshot. And moving to RTBC.

The above patch works fine, tested it locally. Thanks @alok_singh

I am not able to reproduce this issue.

Thanks @BramDriesen for directing to me to the link, we can close this issue.

Added the patch for the issue mentioned in #6, here is the updated patch(Call_on_Null-3321499-7.patch) and interdiff_4-7.txt

siddharthjain_7998 → created an issue.

I came late to this issue queue, but after going through all the comments #47 worked for me. If you are following comment #17 then you must have "oomphinc/composer-installers-extender": "^1.0" version other you will get the same error(as per #27).

siddharthjain_7998 → made their first commit to this issue’s fork.