- Issue created by @rsslwa
- Status changed to Postponed: needs info
over 1 year ago 1:01pm 18 July 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
When I run `drush webform:libraries:download` the `libraries/tippyjs/dist/tippy-bundle.umd.j` file exists and is aggregated via JS.
Are you able to replicate this issue on a plain vanilla Drupal instance?
What happens when you disable JS aggregation?
Does the /libraries/tippyjs directory exist?
- 🇦🇺Australia rsslwa
Thank you Jacob for your help. I'm setting up a fresh vanilla d10 instance to test.
The /libraries/tippyjs directory doesn't exist. All the other library directories are generated by the download command, with the last being /tabby
Disabling JS aggregation removes the optimizer warnings, as expected, and the direct ref to the tippy.js file throws a 404.
- 🇺🇸United States jrockowitz Brooklyn, NY
I am not able to replicate this issue.
Your immediate work around is to manually add the directory
- 🇦🇺Australia rsslwa
I've manually added the tippyjs directory to /libraries, which has fixed the errors.
Thank you.
Interestingly tippy is still not showing under External Optional Libraries in structure > webform > config > libraries.
- 🇮🇳India siddharthjain
@rsslwa
I was also facing the same issue, this documentation helped me to download the libraries using the composer rather than downloading directly. You can also refer here:
https://www.drupal.org/docs/8/modules/webform/webform-frequently-asked-q... → - Status changed to Closed: cannot reproduce
over 1 year ago 2:46pm 13 September 2023 - Status changed to Needs work
about 1 year ago 7:11pm 16 October 2023 - 🇺🇸United States bkosborne New Jersey, USA
I ran into this as well. Debugged with xdebug.
drush webform:libraries:download
does not include tippy for me. The reason is that the the library definition in WebformLibrariesManager indicates the tippy library is only compatible with Drupal 9. It's treated as an "excluded" library due to the logic in WebformLibrariesManager::isExcluded.I think we just need to remove that line that limits the library to D9. Probably left over from when there were two versions of tippy needed, one for 8 and one for 9.
- last update
about 1 year ago 536 pass - @bkosborne opened merge request.
- Status changed to Needs review
about 1 year ago 7:17pm 16 October 2023 - 🇺🇸United States bkosborne New Jersey, USA
I noticed popper has the same issue so I remove it from there too
- 🇺🇸United States jrockowitz Brooklyn, NY
I think this is RTBC. These types of issues are making me feel that the stable release of Webform 6.2.x should be for Drupal 10.x+ only.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
If it works with the core restriction removed, that is a simple fix.
Drupal 9 is out-of-support in a couple of weeks anyway so soon enough it will all be about supporting Drupal 10. It would be best if it can support D9 so that people can upgrade their modules separately from Drupal.
- 🇺🇸United States jrockowitz Brooklyn, NY
Yeh, I feel like we can easily "still support" D9 for a few releases.
- last update
about 1 year ago 536 pass - last update
about 1 year ago 536 pass -
Liam Morland →
committed 0c009277 on 6.2.x authored by
bkosborne →
Issue #3375138 by bkosborne, jrockowitz: Remove core restriction from...
-
Liam Morland →
committed 0c009277 on 6.2.x authored by
bkosborne →
- Status changed to Fixed
about 1 year ago 2:11pm 17 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.