Drupal 10 & CKEditor 5 readiness

@alphex, are you sure you have the checkbox checked to "Display embedded entities" on your text format (Full HTML for example) you enabled the entity embed button on?

hey @alphex,
please check a couple of things below,
1. have you put `Embed media`filter directly after `Align images` and `Caption images` ?
2. have you enabled `Display embedded entities` filter and put it after `Embed media` filter
3. uncheck `Limit allowed HTML tags and correct faulty HTML` if you are not sure which HTML tags need to allow.

Also experiencing the same issue with @alphex, this is because of missing allowed attributes in the <drupal-entity> element.

Pushed fix to MR

I've added a toolbar balloon for edit functionality that brings up a modal dialog. I duplicate core's openDialog function as now it's missing existingValues param as in 🐛 Drupal.ckeditor5.openDialog missing existingValues param Needs work

I personally think we can use something like Image contextual toolbar for display, alt, align, and caption.

Thank you for moving this forward. I, too, need to embed nodes and upgrade to ckeditor5. The patch does not apply to version 8.x-1.3. Is it possible for someone to work on this? Thank you for all your work!

Thanks for the patch!

But I am getting

Uncaught EvalError: Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self' 'unsafe-inline' svc.webspellchecker.net cdn.jsdelivr.net".

    at ./js/ckeditor5_plugins/drupalentity/src/index.js (<anonymous>:1:14050)

error, and the CKEDITOR5 can't be rendered.
The fix for me is `cd` to the `entity_embed` module , run `npm run build` to regenerate the index.js

Attaching the latest code from MR in patch format for testing and usage in one of my projects.

While testing the patch i observed following error on basic html format:
`CKEditorError: plugincollection-soft-required {"missingPlugin":"WidgetToolbarRepository","requiredBy":"EntityEmbedToolbar"}`

On some debugging i observed that this error gets resolved if either table or image widget is enabled.

The current MR/patch doesn't apply properly to me due to conflicts between the .info.yml changes and autogenerated changes from Drupal's packages. Here's a patch that can be applied via composer. The changes should not be brought into the MR.

I also notice that alignment is not displayed correctly in the editor. Alignment is applied on the image, but not the widget, so the widget will still taking full width in the editor.

Just tested 📌 Migrate to CKEditor 5 for Drupal 9.4+ / Drupal 10 Fixed for paragraphs embed with the MR from 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC and MR 12 from here and thinks appeared to be working for me.

Yeah its working for us too. Moving to NR but this might be RTBC pending the Embed module fix.

Confirmed, this is working for me. I used the issue fork from Embed Module with this issue's fork.

This fork is working for me as long as it's paired with the Embed Module fork listed in this issue here 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC (Just like in #68). It successfully solved an issue with a custom embed for the ckeditor 5 interface we were having. Wonderful work here folks.

Also confirming after initial testing the MR here is working well.

A remaining task is listed as adding a CKEditor4To5Upgrade Plugin, but I'm thinking there'll be a bit to that as each site will have a customised list of cke4_buttons that need converting? The plugin would need to load each embed.button and add them as cke4_buttons to be converted.

We could theoretically apply the patch on the embed module via the composer file in the module here :-) but not sure if we want to go that route. Depending on how fast the for that is merged we could pin the min version requirements to the version that contains the fix for embed.

I'd missed the fact that embedded entities cannot be linked. This was possible in CKE4 thanks to ✨ Image entities/fields embedded using Entity Embed cannot be linked in CKEditor Fixed which we'd used to allow linkit links for embedded entities.

Unfortunately this is block upstream in CKEditor 5 itself. This is being tracked. 🐛 [upstream] [GHS] CKEditor 5 removes s that wrap HTML elements not natively supported by CKEditor 5 Fixed and is listed as issue 4. in the tracking issue 🌱 [meta] [upstream] Prioritized CKEditor 5 upstream blockers Active .

Linking embed never worked for me in ckeditor 4 actually. 🐛 Wrapping drupal-media image in a link produces empty P tags after image Needs work 🐛 Adding links around embedded media through CKEditor might lead to invalid/complex markup when rendered Active 🐛 Linking an image creates an empty paragraph tag in CKEditor Needs review so I don't think that's a blocker for this fix.

Also you might be able to work around it by wrapping it in a div? I'm pretty sure we tested linking embed content and it worked but our content might have different wrappers.

This is the patch I used, in case anyone else wants to try out this issue but can't get the MR patch to apply

The merge request only applies to the dev release I noticed when I was testing this out.

I did notice broken CSS today when using entity embed with Acquia Site Studio (cohesion) on the embed dialog where you select the embed type. Still need to check what's happening there and where the issue lays exactly.

I think the icons may need to be converted to SVG too.

@fenstrat I've started looking into adding a CKEditor4To5Upgrade Plugin, and run into some issues. I was wondering if anyone else was looking into it, or if there was anyone more experienced with plugins than I am, who can answer some questions for me:

• Is there a way to add values to annotation dynamically? I don't know of one, but the upgrade plugin needs an array of all the names of CKE4 buttons it deals with. Since users create buttons, it can't be hard coded.
• Are any configuration changes needed? I didn't think so from a quick look at the merge request. If there are no config changes between the CKE4 and 5 buttons, things easy on that front

Are any configuration changes needed? I didn't think so from a quick look at the merge request. If there are no config changes between the CKE4 and 5 buttons, things easy on that front

The buttons are handled by the Embed → module. I started to write test coverage for 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC and it looks like the button configuration itself is completely unaware of the editor.

I have added the CKEditor4To5Upgrade Plugin.

The annotation issue was overcome but using the hook hook_ckeditor4to5upgrade_plugin_info_alter, which allows you to change the array of available CKE 4 to 5 plugins after it has checked the annotations.

This version of the plugin assumes no configuration changes are needed and that the button IDs don't need to change.

To test this, select a text editor format and switch it from using CKE4 to 5. Make sure there are no warnings displayed on the page or errors in the log. You should not need to save the changes to the format to see these.

I have included it as a patch too.

Subscribing

@pbone3b FYI: No need to create noise in the issue queue by placing a comment. You can simply click on the star/follow on the right under the issue meta info on the top of the issue. 😇

I have a ckeditor5 button created using the Embed module ("Embed type" = Views with "Filter which Views to be allowed as options" checked).
When I click on the icon in the editor toolbar, I get this ajax error:

The website encountered an unexpected error. Please try again later.

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of core/lib/Drupal/Core/Entity/EntityTypeManager.php).
Drupal\Core\Entity\EntityTypeManager->getHandler() (Line: 192)
Drupal\Core\Entity\EntityTypeManager->getStorage() (Line: 147)
Drupal\entity_embed\Form\EntityEmbedDialog->loadEntityByAttributes() (Line: 194)
Drupal\entity_embed\Form\EntityEmbedDialog->buildForm()
call_user_func_array() (Line: 534)
Drupal\Core\Form\FormBuilder->retrieveForm() (Line: 281)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 270)
Drupal\shield\ShieldMiddleware->bypass() (Line: 137)
Drupal\shield\ShieldMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 49)
Drupal\remove_http_headers\StackMiddleware\RemoveHttpHeadersMiddleware->handle() (Line: 23)
Stack\StackedHttpKernel->handle() (Line: 718)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Drupal version : 9.5.5
PHP version : 8.0.21

@RedNeko thanks for your work on the CKEditor4To5Upgrade Plugin! Confirming the hook_ckeditor4to5upgrade_plugin_info_alter is the correct approach. It looks good to me.

@neclimdul re linking the embedded entity with a wrapping div, hmm I don't think that'll worth either. See the markup that was tried 🐛 [upstream] [GHS] CKEditor 5 removes s that wrap HTML elements not natively supported by CKEditor 5 Fixed which seems to use a wrapping div.

@drunir I believe you are using the views_entity_embed module. I don't think it is CKEditor5 ready yet.

Working on:

This also really should have some test coverage.

I think you can reuse a lot from Drupal core's MediaTest. For example:

• \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testPreviewUsesDefaultThemeAndIsClientCacheable()
• \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testEmbedPreviewAccess()
• \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testAlignment()
• \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest::testEditableCaption()

That should save you a lot of time :)

Of course, starting with just porting entity_embed's \Drupal\Tests\entity_embed\FunctionalJavascript\CKEditorIntegrationTest::testIntegration() to test the CKEditor 5 equivalent would be a great start! 😊

(I wrote that in #24, in September 2022.)

Just a heads up that I'm working on trying to get an updated Embed module release out today so we can run tests properly here.

• First, catching up on what happened since #47 (January 2023):
• Thanks @MrDaleSmith for= updating the version requirements, looks good 👍
• Thanks @el7cosmos for addressing @lauriii's review at https://git.drupalcode.org/project/entity_embed/-/merge_requests/12#note..., looks good! 👍
• Thanks @el7cosmos for adding editing support! I will defer to @lauriii to review that. 😅 I did test it, and it works! 👍
• Thanks @neclimdul for your optimism in saying in #67 this is RTBC pending embed module changes. 😁 I don't think we're quite there yet though 😅 We at the very least need one functional JS test and a kernel test for the upgrade path. We want to make sure this remains maintainable for @Dave Reid, don't we? 😊
• @pmagunia is right in #77 that this should have equivalent SVGs — just confirmed with @Dave Reid in the room at the DrupalCon sprints 👍
• @RedNeko: thanks for adding a CKEditor4To5Upgrade plugin! 👍 I'll write test coverage for that too 😊

I'm adding some base classes and deriver to 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC that should reduce the amount of code necessary here and also help out the rest of the Embed ecosystem, not just this module. So testing this will be challenging until that lands in Embed just as an FYI.

Also we noted during the DrupalCon sprints that we likely need to add a prefix to the button names, and I don't see that added to the MR yet. I'm hesitant to push up a bunch of refactors until that is also committed - I'm not sure what the state of that is @wimleers?

#89: 👍 +1 for moving the deriver there, as discussed.

You're right that not everything we discussed is in this MR yet: functional JS test is still in progress (it was impossible to do uninterrupted work on that at DrupalCon), and indeed the button names are not yet renamed.

TODO:

1. @Wim Leers: get functional JS tests working
2. @Wim Leers: rename buttons by prefixing so that conflicts are impossible, which will require an update to the upgrade path test AND the functional JS tests, but those tests will prove that the button rename did not break anything 👍🤓
3. @lauriii: review the JS

I will not have time soon though. The remaining June weeks are swamped. I'll try to get this prioritized by my employer in early July.

Just pushed the final commit that makes the CKEditor 4 → 5 upgrade path test coverage pass tests. That now has comprehensive test coverage and uncovered a few bugs in the process! 👍😊

While working on 🐛 [Entity Browser] Tests are failing on D10 Fixed , I ran into the following issue: 🐛 [CKEditor5] Missing dependency on drupal.ajax Fixed .

During the tests of entity_browser, the embed button in the CKEditor5 toolbar doesn't respond because the library internal.drupal.ckeditor5 doesn't have a dependency on core/drupal.ajax. In ckeditor5.js there is a method Drupal.ckeditor5.openDialog(), which calls Drupal.ajax and may fail in some cases.

Posting it here since I think the same problem may occur here.

I was trying the apply the entity_embed-3272732-80.patch using cweagans and it failed on two files.

tests/modules/entity_embed_test/entity_embed_test.info.yml
tests/modules/entity_embed_translation_test/entity_embed_translation_test.info.yml

So removed those two files and using a new patch which gets applied and now able to pull the entity into ckeditor5.

Here is my diff of composer.json

+      "drupal/entity_embed": {
+        "Drupal 10 & CKEditor 5 readiness[https://www.drupal.org/project/entity_embed/issues/3272732]": "https://www.drupal.org/files/issues/2023-06-19/entity_embed-3272732-93.patch"
+      },
+      "drupal/embed": {
+        "CKEditor 5 compatibility[https://www.drupal.org/project/embed/issues/3309747]": "https://www.drupal.org/files/issues/2023-03-30/fix_module_embed_compatibility_CKEditor_5.patch"
+      },

#93's changes seem to be working perfectly for me on my local. I'm gonna change this to needs review so that others can weigh in.

Okay - got it rolling on a lower environment and I get the following error in my php logs

Symfony\Component\HttpKernel\Exception\HttpException: Currently, only CKEditor is supported. in Drupal\embed\Access\EmbedButtonEditorAccessCheck->checkButtonEditorAccess() (line 82 of /var/www/html/docroot/modules/contrib/embed/src/Access/EmbedButtonEditorAccessCheck.php).

First off - thanks for all this!

@laura.gates as noted above, you'll need to patch the embed module 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC as well to get rid of the "only CKEditor is supported" error.

I'm having some trouble with embedded Paragraph entities which contain links - the links interrupt the form's tab order, so once I tab to the CKE field, I can't tab out of it to the next form element. On my screen I can briefly see the first link within a Paragraph flash as if it's selected, but the location of my cursor doesn't change - and every subsequent use of the tab button just flashes that same link. I can Shift+Tab back out of the CKE field, but I can't tab forward past it.

If I add tabindex="-1" to links within the embedded Paragraph, all seems to work as expected, but I'm wondering if there's a better way than this:

// Remove in-Paragraph links from the tab order to prevent breaking the edit form as a whole.
setTimeout(noTabParagraphLinks, 1000);
function noTabParagraphLinks() {
  $('figure.drupal-entity a').each(function() {
    $(this).attr('aria-hidden', 'true').attr('tabindex', -1);
  });
}

I am trying to put right status to this issue. According to @Wim Leers's comment in #91, I am believe this should be in "Needs Review" status.

I tested this MR along with https://www.drupal.org/project/embed/issues/3309747 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC

Environment config:

Drupal 10.1 using DDev
PHP 8.1
Embed & Entity Embed 8.x-1.x branches with patches applied

Attached a static patch of the latest MR 12 that can be used in composer files.

The last submitted patch, 101: entity_embed-3272732-MR-12--20230712-101.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Catching up!

• I worked on this during DrupalCon Pittsburgh ~1 month ago. See #90 + #91 for where I left things.
• #93 uploaded a patch of the MR to make it consistently applicable using cweagans/composer-patches 👍
• @navneet0693 added some really solid improvements yesterday! 🤩

Now working on functional JS test coverage as mentioned in #90.1.

Pushed functional JS test!

It tries to port \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest as directly as possible. This worked out well:

• ✅ ::testConversion()
• ✅ ::testOnlyDrupalMediaTagProcessed() → ::testOnlyDrupalEntityTagProcessed()
• ❌ ::testMediaArbitraryHtml() → ::testEntityArbitraryHtml() ⇒ JS BUG DISCOVERED! 👍
• 🤷‍♂️ ::testLinkedMediaArbitraryHtml() → ::testLinkedEntityArbitraryHtml() + ::testLinkability() + ::testLinkManualDecorator()⇒ linkability of embedded entities is still missing, but per #74, that didn't quite work in CKEditor 4 either, so it's not a regression, so we shouldn't hold this up on that.
• ✅ ::testErrorMessages()
• ✅ ::testPreviewUsesDefaultThemeAndIsClientCacheable()
• 🗑️ ::testAlignment() + ::testDrupalMediaStyleInDropdown() + ::testDrupalMediaStyleWithClass() have not been ported because the alignment functionality (for now) is present solely in the Drupal dialog — that's also less disruptive because AFAIK many sites are customizing the dialog using hook_form_alter()
• 🗑️ ::testEditableCaption() has not been ported for the same reason
• 🗑️ ::testViewMode() has not been ported for the same reason
• 🗑️ ::testAltDisabled(), ::testAlt() and ::testTranslationAlt() have not been ported because it's irrelevant for Entity Embed — that's special-case logic/UX for image media
• ✅ ::testEmbedPreviewAccess()
• ❌ ::testMediaPointerEvent() → ::testEntityPointerEvent() ⇒ JS BUG DISCOVERED! 👍

Hi wim!

linkability of embedded entities is still missing, but per #74, that didn't quite work in CKEditor 4 either, so it's not a regression, so we shouldn't hold this up on that.

Welp... problem located.

I tried to use the patch from #101 ✨ Drupal 10 & CKEditor 5 readiness Fixed , but in "Text formats and editors" config page, when I switch the drop-down to "CKEditor 5" I get the following error in the ajax request:

TypeError: Drupal\entity_embed\Plugin\CKEditor4To5Upgrade\EntityEmbed::__construct(): Argument #3 ($plugin_definition) must be of type Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginInterface, array given, called in /app/web/modules/contrib/entity_embed/src/Plugin/CKEditor4To5Upgrade/EntityEmbed.php on line 67 in Drupal\entity_embed\Plugin\CKEditor4To5Upgrade\EntityEmbed->__construct() (line 50 of /app/web/modules/contrib/entity_embed/src/Plugin/CKEditor4To5Upgrade/EntityEmbed.php)

BTW: the patch from #93 ✨ Drupal 10 & CKEditor 5 readiness Fixed works fine.

My environment:
* Drupal 9.5.9
* PHP 8.0
* embed 1.6
* entity_embed 1.4

I tried to use the patch from #101 ✨ Drupal 10 & CKEditor 5 readiness Fixed , but in "Text formats and editors" config page, when I switch the drop-down to "CKEditor 5" I get the following error in the ajax request:

TypeError: Drupal\entity_embed\Plugin\CKEditor4To5Upgrade\EntityEmbed::__construct(): Argument #3 ($plugin_definition) must be of type Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginInterface, array given, called in /app/web/modules/contrib/entity_embed/src/Plugin/CKEditor4To5Upgrade/EntityEmbed.php on line 67 in Drupal\entity_embed\Plugin\CKEditor4To5Upgrade\EntityEmbed->__construct() (line 50 of /app/web/modules/contrib/entity_embed/src/Plugin/CKEditor4To5Upgrade/EntityEmbed.php)tch from #93 ✨ Drupal 10 & CKEditor 5 readiness Fixed works fine.

My environment:
* Drupal 9.5.9
* PHP 8.0
* embed 1.6
* entity_embed 1.4

It couldn't be applied in 1.4, so I made a temporary patch.

The latest from MR12 didn't apply cleanly. This is the URL I used on the 1.x-dev version of the module:

https://git.drupalcode.org/project/entity_embed/-/merge_requests/12.patch

The entity_embed.info.yml and entity_embed.module files were out of sync.

Even after applying the changes manually the embed icons were missing for me on the text format config page.

#93 worked well for me though.

Thanks everyone for all the hard work on this!

I wonder if it was intentional to set embedded entities to only be allowed at the block level? I'm looking after a site at the moment which embeds entities within text, and upon updating those have all been shunted up the DOM when opened in ckeditor5.

I messed around a bit with the options in _defineSchema():

    schema.register('drupalEntity', {
      isObject: true,
      isContent: true,
      isBlock: false,
      allowWhere: ['$block', '$text'],
      allowAttributes: Object.keys(this.attrs),
    });

to no avail. For reference this is using paragraph_inline_entity_form module to embed a couple of words which open into a tooltip on hover for displaying academic references, they very much need to be in-text.

In Text formats and editors config the new default entity.svg embed button icon is properly being loaded for ckeditor5 editors, but in Embed buttons config the old default entity.png icon is being loaded.

This is also being reported as an error on the status report page

Hmm... the fix is bouncing between MRs and patches which is pretty confusing.

@Wim Leers This is still assigned to you. Would be curious for your assessment on next steps here please :)

@Kristen Pol The MR contains the truth. The patches are just extracted from the MR, to have a stable patch to apply (every commit to the MR would change the auto-generated patch from the MR). This is a limitation of GitLab 🤷‍♂️

I should've unassigned this issue from me in #104, sorry. I am not sufficiently proficient in the CKEditor 5 JS APIs to efficiently fix this. I'm hoping @lauriii can do that in the next few weeks. (He, @nod_ and @bnjmnm wrote >90% of the JS for the CKEditor 5 module!)

Basically: as soon as all functional JS tests I added pass, I'd instantly RTBC, commit and ship this 🤓 (Not because I wrote those tests, but because they're ported from Drupal core's similar "media embed" functionality, which is very thoroughly tested after years of deep reviews and edge case testing!)

Thanks for the great summary of status and next steps 🙏

Hey, just pushed a commit to address the issue I mentioned in #110 ✨ Drupal 10 & CKEditor 5 readiness Fixed

Please let me know if there is any related code that I should update besides this.

(I could also clean up that \Drupal::service() call and properly inject the extension.list.module service while I'm at it)

Got this up and running! Many thanks to everyone working on this.

I installed it on clean D10, added patch from MR and I'm getting the following errors:

Attaching static patch with HEAD at 4d4809529ccfbe64c7488d4438f92e1bff52b900

Everything's working well, except this functionality ✨ Image entities/fields embedded using Entity Embed cannot be linked in CKEditor Fixed it's not possible to create a link around an embedded entity in CKE5

Yeah that's effectively the same as my issue per #109

So this is a OOTB media embed of CKEditor 5 and it has a link feature:

Maybe entity-embed should have something similar?

To speed up release - maybe this feature should be a separate issue?

#120: that's known. See the tests I added and the summary of what passes and fails in #104. Apparently I fixed this in 2019 over at #2511404-77: Image entities/fields embedded using Entity Embed cannot be linked in CKEditor → and committed it in #81 there?! 😳😅 I have no recollection of this! 👴

That means that in #104, the 4th bullet with the "🤷‍♂️" should really be a "❌" too. That means there are THREE bugs to be fixed in the JS, not TWO.

@jannakha We can't release this as-is, because that could result in data loss (links disappearing) when editing existing content with linked embedded entities using CKEditor 5.

Should entity_embed work with the "Limit allowed HTML tags and correct faulty HTML" filter? The embedded entity is not displayed when I have that filter enabled.

@Pasqualle Yes, it should, and it does. The test coverage proves it does. The filters must be ordered correctly though. entity_embed_filter_format_edit_form_validate() ensures the order is valid. The only ways it cannot work: the FilterFormat on your site was created with that validation logic disabled and/or a new bug. If it's the latter, please create a new issue 😊🙏

Clarified the remaining work.

Fixed the pointer test by porting the (CSS-only) fix from 🐛 [drupalMedia] When media is embedded in a view mode whose display is configured to link elsewhere, that link should not be clickable in CKEditor Fixed 👍

2 JS bugs left.

For the two remaining JS bugs surfaced in #104, we need to port:

1. ::testEntityArbitraryHtml() → #3231337: [drupalMedia] Remove manual dataDowncast from DrupalMediaEditing →
2. ::testLinkManualDecorator() → #3248228: Unable to change selection after linking inline media when manual decorators have been defined →

… and maybe more. But at least the patterns in those issues should help a lot in getting this closer to the finish line.

Anybody interested? 🤞

@Wim Leers,

I am willing to offer help, but it seems that my knowledge is limited, I am highly willing to make point 2 in #127 work.

Observation:-
if you add a piece of media using the entity embed on the formatting toolbar, then close out without making a selection, you are taken to the top of the body section.
Steps to reproduce
* Navigate to the bottom of the body content section
* Place your cursor
* Select the “entity embed icon”
* Click the “x” in the top right corner without making a selection
* See that you are taken to the top of the body section

If the content inside