🇮🇳India @guptahemant

Hi Everyone

Internally we challenged SPACE on the demo design and were able to build it within a day by following these steps:

• Compared the provided design with our in-house SPACE design system.
• Identified the components to use and the necessary tweaks.
• Updated the branding elements such as colors, fonts, and typography.
• Used our the enhanced layout builder to create the page.

Demo link: https://demo.spacedxp.com

We welcome your feedback. Thank you!
Note: Currently our components are built on top of UI patterns, but can easily be converted to SDC.

issue Complexity could be another scale to decide the credit scoring. The options could be something like:
Very easy, Easy, Moderate, Hard

Hi Kristen, I discussed internally and was able to get following information:

What kind of user testing did you do and what compliance standards does your design system comply with (e.g. WCAG AA 2.2)?

SPACE being component based allowed us to look at individual component performance and accessibility, allowing us to have lower time to assemble an accessible & performant web page. We have factored for WCAG 2.0? and have noticed some minor gaps that is easy to fix with nominal effort.

What are your open source licensing policies for Figma, UI Kit, etc?

SPACE started as a Drupal accelerator for QED42's projects, since starshot announcement we see lot of similarities in both objective and approach and are looking into open source licensing of our core architecture.

Any background info on the design system’s evolution would be helpful too.

We started with a Design system that had to be flexible to take branding as configuration, figma tokens & annotations for better interoperability with space drupal theme. Build plan also needed to be in line with Drupal core evolution, hence we went with drupal core blocks as components rather than paragraphs and integrated heavily with layout builder.
We would also add a detailed write up in form of a blog post.

That’s a fun coincidence that yours has a space theme

It’s a pleasant coincidence that our product names are similarly themed.
The naming is a pleasant co-incident, it strengthens our co-relation. We named it SPACE, for the fact that any branding needs can be accommodated on the platform and all 3rd party integrations possible in spirit of OpenDXP

Official links:
Main site: https://spacedxp.com
Design system: https://space-design-system.qed42.net
Beta Access: space-drupalconlille.qed42.net

Feel free to reach out for beta access.

Approach mentioned in #3 will only work when the proper development workflow has been followed but with project browser coming in, it can be assumed that the code will not be committed, and recipes will / can be installed on the fly, So should we use the checkpoint API to resolve this?

We have also developed a design system internally, which is built in storybook, http://space-design-system.qed42.net/?path=/story/welcome--page, Component are defined to be compatible with Ui patterns should be easy to convert them and make them work with SDC.

Please let us know further thoughts around it.

Thanks

Possibly this issue can be used as an example to better describe why / when to use ensure_exist config action https://git.drupalcode.org/project/distributions_recipes/-/blob/1.0.x/do...

griffynh → credited guptahemant → .

griffynh → credited guptahemant → .

Thanks @apaderno for the quick update,

guptahemant → created an issue.

hi @shubh511

It seems like your branch is 54 commits behind the base 11.x branch, to rebase please follow these steps https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Couple of scenarios which comes in my mind, which we should address:

• Currently multiple route definition can point to a single class method, How we will define routes like that with php attributes?
• Route names are used to define menu links, menu tabs and at various other places also, I think we are aiming to generate auto route names but it also kind of relates to above point, How we are going to address that?
• What would be the process of overriding an existing route? Using route subscribers or something else?

Following test case is failing Drupal\Tests\taxonomy\Functional\Views\TaxonomyIndexTidUiTest::testFilterGrouping

Hi @riyas_nr

Did a code review and included few more suggestions.

Issue fixed in 2.x branch, New release to follow.

Switching to 2.x branch

Fixed in 2.x and created a new release as well.

Switching this to 2.x for fixing

guptahemant → made their first commit to this issue’s fork.

hi @reetesh

Thanks for contribution, Issue has been fixed and committed along with https://www.drupal.org/project/purge_akamai_optimizer/issues/3397617#com... 💬 Minimum stability issue with drupal/akamai in Drupal 10 Fixed

Patch looks good, committed on 2.x branch, and a 2.0.0 release has been created, Thanks for the contribution.

One additional thing i am observing is that after the changes done in https://www.drupal.org/project/drupal/issues/3265798 🐛 [view:total-rows] problem in Display a 'Specified number of items' pager RTBC , if we try to access `$view->total_rows` in custom code, then it returns the count after the pager is applied and not the actual number of results.

Scenario

in custom code implement:
`hook_views_pre_build` and add something like:

`$view->getPager()->setItemsPerPage(3);`

Then implement: `hook_views_pre_render` and then do something like:
```
dump($view->total_rows);
```
Assuming initial results were 6, but after calling setItemsPerPage, the total_rows count come out as 3.

Not sure if i am doing something incorrect here. but if i comment the code from https://www.drupal.org/project/drupal/issues/3265798 🐛 [view:total-rows] problem in Display a 'Specified number of items' pager RTBC then the total_rows count reflects correctly.

Attaching a patch for drupal 10.1.x version

Attaching a patch which resolves the mentioned issue.

guptahemant → created an issue.

Attaching a patch for drupal 10, In drupal 10 stable theme is no longer present hence removed the changes related to that.

Created a new patch against 2.0.0 version of the module to use on one of my projects. It builds on top of #4 and includes a change for composer.json as well.

Just checked with drupal 9.5.9 on one of my projects and after using patch from #2 it shows the module is compatible with drupal 10, without any additional issues.

Thanks everyone for contribution created a new release for the module https://www.drupal.org/project/purge_control/releases/2.0.0 →

Created a 2.x branch of the project for drupal 10 compatibility, Hence closing this issue

Created a new release https://www.drupal.org/project/purge_control/releases/2.0.0 →

Marking this as done.

Here is a work in progress patch which tries to replace default by adding an underscore at the start but it is not complete since if we try to replace page_manager_page then the page manager access starts failing.

The reason for that failure is inside PageAccessCheck the routes defaults / parameters starting with underscore are not available.

Not sure if this is the correct approach to resolve the issue, but posting it here in case if it helps to proceed with this issue further.

guptahemant → created an issue.

Patch in #2 introduces following issue:

The visual label must appear in the accessible name of links and controls,
Example Visual label: Facebook share(Opens in a new tab/window) not in Opens in a new tab/window

To fix this we need to make sure aria-label attribute contains the complete text which appear in link element.

Here ia patch which builds on top of #2 to fix this issue.

While testing the patch i observed following error on basic html format:
`CKEditorError: plugincollection-soft-required {"missingPlugin":"WidgetToolbarRepository","requiredBy":"EntityEmbedToolbar"}`

On some debugging i observed that this error gets resolved if either table or image widget is enabled.

Attaching the latest code from MR in patch format for testing and usage in one of my projects.

This one might be interesting to look at https://www.drupal.org/project/openai → .