🇮🇳India @guptahemant

breidert → credited guptahemant → .

I think we did a small experiment with sliders before, we can continue on that. Also we should try tabs and accordions, Additionally trying out a unique field and widget like rating would be interesting to see how it behaves with XB.

chrisfromredfin → credited guptahemant → .

Updated the title and summary to better reflect the issue.

I am able to consistently reproduce this issue, and it seems filters are conflicting between different tabs, Like if i select Accessibility on Drupal.org tab and then i switch to recipes do couple of refreshes i am able to see recipes but then if i try to search for recipe named performance, i am not able to see the results and i see zero results.

guptahemant → created an issue.

I think its useful to include SDDS as well along with tugboat previews but we also need to call out that SDDS design system is being included with this preview for testing purposes.

I also encountered this today, seems duplicate of https://www.drupal.org/project/experience_builder/issues/3470422 📌 Gracefulness when developing SDCs: SDCs may appear/disappear from one request to the next Active

Today during my testing i observed this issue is still present, workaround from #3 did the fix for me.

Adding my findings here, I will keep updating my comment as i encounter new issues.

Issue 1
Drupal\Core\Render\Component\Exception\ComponentNotFoundException: Unable to find component "starshot_demo:starshot-case-study2" in the component repository. [The "starshot_demo:starshot-case-study2" plugin does not exist

On my previous setup i took the latest pull and it seems this component was removed from the codebase and i got hit with this error.

hmm yes maybe plane one looked better, Lets look for additional feedback

Maybe instead of sun we can use drupal logo?

All of them looks good, but updated number 3 looks best.

Looks great to me as well, Just one question, do we have any concerns on using images of people?

Added around usage of nvm

kristen pol → credited guptahemant → .

@pbouchereau In #8 i created a new contrib module, check if that helps

@tonypaulbarker thanks for sharing the survey link, i shared more thoughts in there.

+1 to remote media along with oembed providers configuration
Additionally I would like to recommend adding media / image cropping tools in this recipe, The module we use are https://www.drupal.org/project/image_widget_crop → along with https://www.drupal.org/project/automated_crop → ,
Also i would recommend to add https://www.drupal.org/project/media_bulk_upload → module to support bulk uploads.

pameeela → credited guptahemant → .

griffynh → credited guptahemant → .

Kristen Pol → credited guptahemant → .

Looks like my recent updates regarding the usage of the script were reverted https://www.drupal.org/node/3464545/revisions/view/13666619/13667940 →

Re-adding that with manual edit. @Kristen Pol please modify them as needed.

Re-added accidental reverted changes

Great, thanks

Kristen Pol → credited guptahemant → .

Hi @Kristen Pol

@annmarysruthy has updated the users in issue summary, there were few accounts for which she was not able to figure out who is the d.org user,
Please have a look further.

Thanks

Thanks @Akhil Babu for detailed steps i have documented them on https://www.drupal.org/community-initiatives/starshot-demo-design-system... →

Also @Kristen Pol can we please review and merge this PR https://git.drupalcode.org/project/demo_design_system/-/merge_requests/3...
It will reduce any additional work on component twig files for metadata correction.

Thanks

Added the usage of SDC script

hestenet → credited guptahemant → .

hestenet → credited guptahemant → .

hestenet → credited guptahemant → .

In that call Read.Ai was added hence with the help of that i was able to find the name of the users, now it will need some additional effort to find individual usernames, maybe someone else can help with that.

• Ahsan Nazir
• Akhil @Salsa
• Akhil Babu
• Akshay Dalvi
• Alan Cole
• Alan Rako
• Alex Chan
• Alex Ismail
• Alfred Deeb
• Alka Elizabeth
• Andy Dopleach
• Ann
• Antoine Osanz
• Ashish Dalvi
• Avani
• Ben Peter Mathew
• Binoli Lalani
• Chetan Sonawane
• Chris Harrop
• Con Fountas
• Dharti Patel
• Dhruvi Shah
• Drupal Community Zoom
• Feb Dao
• Fiona Morrison (she/her)
• G4MBINI
• Gábor Hojtsy
• Irawan Irawan
• Jatin Gupta
• Jaydev Bhatt
• John Aroza
• Joshua Fernandes
• José Carlos Tamayo
• Karl (PreviousNext)
• Kelvin
• Kim
• Kiran Kadam - QED42
• Kobus van Wyk
• Kristen Pol (Salsa Digital & CivicTheme)
• Kunal Patel
• Luke McCormick
• Marcus Morba (Freelance A11y Specialist)
• Matt Commons
• Meeni Dhobale (QED42)
• Michael Fanini
• Mike Gough
• Mithun S
• Mohit Aghera
• Nicolas Haase
• Oscar Loría
• Paul Morriss
• Pavlos
• Prabhavathi
• Prashant Chauhan
• Rahul
• Ravi
• Rob Montero
• Ruturaj Chaubey
• Saanvi Dua
• Sarvjeet
• Simon Lindsay
• Simon@AA
• Snehal
• Snehal Chibde
• Snehal Gaikwad
• Steven Worley
• Suchi Garg
• Thomas Peterson
• Vakul Rai
• Vidit Anjaria
• VinmayiSwamy
• akash dabhi
• hemant Gupta
• kushal
• murray
• siddharth
• snehal
• souvik pal
• swati chouhan

Kristen Pol → credited guptahemant → .

Kristen Pol → credited guptahemant → .

griffynh → credited guptahemant → .

Just now followed the updated development guide on mac and i was able to do the setup without any issues.

thejimbirch → credited guptahemant → .

Interested in leading and helping with this track. Submitted the proposal

Interested in leading and helping with this track. Submitted the proposal

griffynh → credited guptahemant → .

Thanks @laurii for finalising on this.

We are committed and look forward to contributing here, We will keep following the progress via issue queues and slack, and will jump in to contribute when Migration guide is ready.
@Kristen Pol Please let us know if there are some specific areas where we can help. Overall very excited to see what we can deliver here as community.

Additionally we would definitely check around D.O redesign opportunities and would reach out to @hestenet via slack / Issue Queues

Hi @laurii

Regarding #41 Please find our response for each individual item:

When do you expect to start and finish the project (rough timeline)?

We can start working from mid next week and we will be covering below things

• Conversion of current Figma to align with our Design System Figma file, keeping the essence of current figma design intact
• Atoms & Molecules to convert into SDC

We are expecting this to be completed by Mid August.

Are you open to collaborating with outside contributors or would you prefer to run this internally within your organization? If you are open to collaborating with outside contributors, how would you prefer to engage with outside contributors?

Initially, we prefer to work internally until the basic setup and cleanup tasks are completed. Once we reach that stage, we are open to collaborating with contributors to advance the project further. We anticipate reaching this point by the last week of July or aim to start collaborating with contributors during the mid-process of cleanup.

Does your team have prior experience working with SDC?

Yes, but not on the actual projects but our SPACE product architecture uses Ui patterns, so it should be easier to convert them on SDC.

How much timezone overlap does your team have with CET office hours (9.00-17.00)?

(9.00-17.00) CET = (12.30-20.30) IST - Considering this, overlap hours can be 6-6.5 hours.

Please let us know your thoughts further.
Thanks

Reviewed the Code in PR, it looks good as a start, Moving this to needs review for manual testing.

griffynh → credited guptahemant → .

Hi Everyone

Internally we challenged SPACE on the demo design and were able to build it within a day by following these steps:

• Compared the provided design with our in-house SPACE design system.
• Identified the components to use and the necessary tweaks.
• Updated the branding elements such as colors, fonts, and typography.
• Used our the enhanced layout builder to create the page.

Demo link: https://demo.spacedxp.com

We welcome your feedback. Thank you!
Note: Currently our components are built on top of UI patterns, but can easily be converted to SDC.

issue Complexity could be another scale to decide the credit scoring. The options could be something like:
Very easy, Easy, Moderate, Hard

Hi Kristen, I discussed internally and was able to get following information:

What kind of user testing did you do and what compliance standards does your design system comply with (e.g. WCAG AA 2.2)?

SPACE being component based allowed us to look at individual component performance and accessibility, allowing us to have lower time to assemble an accessible & performant web page. We have factored for WCAG 2.0? and have noticed some minor gaps that is easy to fix with nominal effort.

What are your open source licensing policies for Figma, UI Kit, etc?

SPACE started as a Drupal accelerator for QED42's projects, since starshot announcement we see lot of similarities in both objective and approach and are looking into open source licensing of our core architecture.

Any background info on the design system’s evolution would be helpful too.

We started with a Design system that had to be flexible to take branding as configuration, figma tokens & annotations for better interoperability with space drupal theme. Build plan also needed to be in line with Drupal core evolution, hence we went with drupal core blocks as components rather than paragraphs and integrated heavily with layout builder.
We would also add a detailed write up in form of a blog post.

That’s a fun coincidence that yours has a space theme

It’s a pleasant coincidence that our product names are similarly themed.
The naming is a pleasant co-incident, it strengthens our co-relation. We named it SPACE, for the fact that any branding needs can be accommodated on the platform and all 3rd party integrations possible in spirit of OpenDXP

Official links:
Main site: https://spacedxp.com
Design system: https://space-design-system.qed42.net
Beta Access: space-drupalconlille.qed42.net

Feel free to reach out for beta access.

Approach mentioned in #3 will only work when the proper development workflow has been followed but with project browser coming in, it can be assumed that the code will not be committed, and recipes will / can be installed on the fly, So should we use the checkpoint API to resolve this?

We have also developed a design system internally, which is built in storybook, http://space-design-system.qed42.net/?path=/story/welcome--page, Component are defined to be compatible with Ui patterns should be easy to convert them and make them work with SDC.

Please let us know further thoughts around it.

Thanks

Possibly this issue can be used as an example to better describe why / when to use ensure_exist config action https://git.drupalcode.org/project/distributions_recipes/-/blob/1.0.x/do...

griffynh → credited guptahemant → .

griffynh → credited guptahemant → .

Thanks @apaderno for the quick update,

guptahemant → created an issue.

hi @shubh511

It seems like your branch is 54 commits behind the base 11.x branch, to rebase please follow these steps https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Couple of scenarios which comes in my mind, which we should address:

• Currently multiple route definition can point to a single class method, How we will define routes like that with php attributes?
• Route names are used to define menu links, menu tabs and at various other places also, I think we are aiming to generate auto route names but it also kind of relates to above point, How we are going to address that?
• What would be the process of overriding an existing route? Using route subscribers or something else?

Following test case is failing Drupal\Tests\taxonomy\Functional\Views\TaxonomyIndexTidUiTest::testFilterGrouping

Hi @riyas_nr

Did a code review and included few more suggestions.

Issue fixed in 2.x branch, New release to follow.

Switching to 2.x branch

Fixed in 2.x and created a new release as well.

Switching this to 2.x for fixing

guptahemant → made their first commit to this issue’s fork.

hi @reetesh

Thanks for contribution, Issue has been fixed and committed along with https://www.drupal.org/project/purge_akamai_optimizer/issues/3397617#com... 💬 Minimum stability issue with drupal/akamai in Drupal 10 Fixed

Patch looks good, committed on 2.x branch, and a 2.0.0 release has been created, Thanks for the contribution.

One additional thing i am observing is that after the changes done in https://www.drupal.org/project/drupal/issues/3265798 🐛 [view:total-rows] problem in Display a 'Specified number of items' pager Fixed , if we try to access `$view->total_rows` in custom code, then it returns the count after the pager is applied and not the actual number of results.

Scenario

in custom code implement:
`hook_views_pre_build` and add something like:

`$view->getPager()->setItemsPerPage(3);`

Then implement: `hook_views_pre_render` and then do something like:
```
dump($view->total_rows);
```
Assuming initial results were 6, but after calling setItemsPerPage, the total_rows count come out as 3.

Not sure if i am doing something incorrect here. but if i comment the code from https://www.drupal.org/project/drupal/issues/3265798 🐛 [view:total-rows] problem in Display a 'Specified number of items' pager Fixed then the total_rows count reflects correctly.

Attaching a patch for drupal 10.1.x version

Attaching a patch which resolves the mentioned issue.

guptahemant → created an issue.

Attaching a patch for drupal 10, In drupal 10 stable theme is no longer present hence removed the changes related to that.

Created a new patch against 2.0.0 version of the module to use on one of my projects. It builds on top of #4 and includes a change for composer.json as well.

Just checked with drupal 9.5.9 on one of my projects and after using patch from #2 it shows the module is compatible with drupal 10, without any additional issues.

Thanks everyone for contribution created a new release for the module https://www.drupal.org/project/purge_control/releases/2.0.0 →

Created a 2.x branch of the project for drupal 10 compatibility, Hence closing this issue

Created a new release https://www.drupal.org/project/purge_control/releases/2.0.0 →

Marking this as done.

Here is a work in progress patch which tries to replace default by adding an underscore at the start but it is not complete since if we try to replace page_manager_page then the page manager access starts failing.

The reason for that failure is inside PageAccessCheck the routes defaults / parameters starting with underscore are not available.

Not sure if this is the correct approach to resolve the issue, but posting it here in case if it helps to proceed with this issue further.

guptahemant → created an issue.

Patch in #2 introduces following issue:

The visual label must appear in the accessible name of links and controls,
Example Visual label: Facebook share(Opens in a new tab/window) not in Opens in a new tab/window

To fix this we need to make sure aria-label attribute contains the complete text which appear in link element.

Here ia patch which builds on top of #2 to fix this issue.

While testing the patch i observed following error on basic html format:
`CKEditorError: plugincollection-soft-required {"missingPlugin":"WidgetToolbarRepository","requiredBy":"EntityEmbedToolbar"}`

On some debugging i observed that this error gets resolved if either table or image widget is enabled.

Attaching the latest code from MR in patch format for testing and usage in one of my projects.