The functionality of showing results behaves abnormally on tab switch sometimes

I am able to consistently reproduce this issue, and it seems filters are conflicting between different tabs, Like if i select Accessibility on Drupal.org tab and then i switch to recipes do couple of refreshes i am able to see recipes but then if i try to search for recipe named performance, i am not able to see the results and i see zero results.

Updated the title and summary to better reflect the issue.

Have done some manual testing and I can confirm this fixes a ton of the flashing and jumping back and forth and is a significant improvement.

One thing I'm noticing, and I'm wondering if it's introduced by this MR or not, is that the categories seem to disappear for me from time-to-time (not every time) as I shift tabs back and forth. Note that I did also enable the Drupal core plugin, in case that has something to do with it.

Re #10, It seems an existing issue to me.
Steps to reproduce:

• Enable Drupal core plugin
• On Drupal.org(JSON:API), click clear filters
• Select first 3 categories from category dropdown
• Switch tab to Drupal core plugin and select one category, eg: Core(Experimental)
• Switch tabs in random order to see the issue

OK, then we should open a separate issue for that, while this is an improvement. Has all MR review been addressed?

🐛 Selected categories disappear on switching tabs Active has been created. The ProjectBrowserUiTest::testMultiplePlugins should be updated to ensure this issue is caught in the first place. I will make the necessary updates and report back.

Suggestion applied and comment added.

@narendrar kindly got on Zoom with me to explain the nature of the problem and what he did. Thanks to his clear explanation, I see what was going on -- the filters applied on any given tab were being applied globally (that is, to all tabs), which of course would filter out all results on other tabs. The tests weren't catching this because they were asserting the wrong thing.

Naren demonstrated that the adjusted test fails on 2.0.x HEAD, so all good there!

The changes in the code now make sense to me; we're keeping all filters localized to particular tabs, except for the keyword search, which is globally applied. The tests appear to cover that this works.

A little manual testing couldn't hurt but I'm too busy with other things for that, and I'm satisfied that this does what's advertised and fixes the bug. Therefore, RTBC!

I'm not 100% that there should be a special case of what "carries over" - maybe nothing should. however, I think we should advance this issue, and if UX people bring it up later, we'll file it then (I don't even think we should file a FU now, even). I will test and review.

thanks @narendraR, i've just tested your latest changes and i can confirm as soon as the last checkbox in a multiselect is unchecked the results count is set back to the number of all available modules for the the source type in question.

This has a legit merge conflict after 🐛 Selected categories disappear on switching tabs Active went in, not just on the compiled svelte.

Rebased to latest code.

Kapow!

Are these test failures legit? Bad rebase from last commit?

It's curious that the same test failed twice, but with a different number (3 vs. 2)?!

Wonderful! This was a tricky one - thanks for the refactor.

Automatically closed - issue fixed for 2 weeks with no activity.