Selected categories disappear on switching tabs

Created on 16 October 2024, 8 days ago

Problem/Motivation

While working on ๐Ÿ› The functionality of showing results behaves abnormally on tab switch sometimes Active it was found that selected categories disappear when tabs are changed. This issue is probable introduced in ๐Ÿ“Œ Improve the categories filter type in context to the rest of the filter component ui Fixed .

Steps to reproduce

  • Enable Drupal core plugin
  • On Drupal.org(JSON:API), click clear filters
  • Select first 3 categories from category dropdown
  • Switch tab to Drupal core plugin and select one category, eg: Core(Experimental)
  • Switch tabs in random order to see the issue

Proposed resolution

๐Ÿ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @narendraR
  • Merge request !603Fix โ†’ (Merged) created by narendraR
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia narendraR Jaipur, India
  • Pipeline finished with Success
    6 days ago
    Total: 830s
    #314017
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    oh i havent realized that those empty selected filters with the undefined chips could happen on and off! i always ran right away into it as soon as i've switched to the core modules source type. never tried switching tabs repeatedly, so never fully grasped that the hiding can switch on and off. at first i thought this issue wouldnt be reproducible and about something else than i've raised in the slack on thread. but understood now the steps to reproduce and also am able to confirm that the MR603 fixes the issue. thank you! only tested the MR functionally/manually, leave it at needs review that someone else can also review the code.

  • I tested the MR and the issue reported here is fixed, also the code changes looks good to me so marking it RTBC.

  • First commit to issue fork.
  • Pipeline finished with Success
    about 15 hours ago
    Total: 725s
    #318310
  • Pipeline finished with Skipped
    about 14 hours ago
    #318374
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

    Woohoo! Testing this caused me to notice separate issues with the Core plugin but they are present on 2.0.x without this MR. And this MR seems to fix the issue the way I caused it. And RTBC with two other manual tests, so here it goes!

Production build 0.71.5 2024