- Issue created by @Kristen Pol
- ๐ช๐ธSpain Carlitus
I don't know the components from CivicTheme but in Omitsis we use Mercury editor with this components:
Layout type:
- Layout: General layout to insert into other componets
- Accordion Layout: Layout to insert accordions content.
- Accordion Content: Layout, that behaves like an accordion, to insert other components
- Tab Layout and Tab Content: Same as Accordion.
Content type:
- Header
- Text
- Content teaser: To insert a content with a view mode, teaser by default.
- Dynamic list: To insert configurable views from the page builder.
- Form: To insert webforms
- Image
- Download
- Link
- Video
- Number: Typical number that when scrolling you see an animation from 0 to the indicated number, plus an icon, prefix, suffix and description.
- Card: With predefined fields to be filled in manually. Configurable view mode
- Blockquote
- Iframe
- Review: An opinion, with a photo and a rating
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks so much!
I'm marking the ones that have CivicTheme components and bolded the ones that don't.
Layout type:
- (n/a) Layout: General layout to insert into other componets
- (accordion) Accordion Layout: Layout to insert accordions content.
- (accordion) Accordion Content: Layout, that behaves like an accordion, to insert other components
- (tabs) Tab Layout and Tab Content: Same as Accordion.
Content type:
- (header) Header
- (paragraph) Text
- (snippet) Content teaser: To insert a content with a view mode, teaser by default.
- (list) Dynamic list: To insert configurable views from the page builder.
- (webform) Form: To insert webforms
- (image) Image
- (attachment) Download
- (link) Link
- (video) Video
- (subtheme component)Number: Typical number that when scrolling you see an animation from 0 to the indicated number, plus an icon, prefix, suffix and description.
- (several) Card: With predefined fields to be filled in manually. Configurable view mode
- (n/a) Blockquote
- (iframe) Iframe
- (n/a) Review: An opinion, with a photo and a rating
Ignoring the naming differences, here are some thoughts on the ones we don't have OOTB. Note also that we have several kinds of cards which could be thought through further.
- Layout: The subtheme has container, columns and grid which can handle layout so we could consider pulling those into the base theme.
- Blockquote: The subtheme has a testimonial. We could decide if that's sufficient to use.
- Review: If the rating probably would be tied to a rating module, this requires would require more thought
- ๐ฎ๐ณIndia guptahemant
I think we did a small experiment with sliders before, we can continue on that. Also we should try tabs and accordions, Additionally trying out a unique field and widget like rating would be interesting to see how it behaves with XB.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks. The slider worked pretty well (wasn't demoed unfortunately). Agree about the tabs and accordions.
I am curious how we'd do some special field like a rating field... perhaps we can create our own schema? Not sure.
- ๐ฆ๐นAustria roromedia Linz
How fine-grained are the SDCs planned? Are you planning to add SDCs like "link", "button", "pill", "image", "video", etc. or other "smallish" components? Or do you think of SDCs rather as a combination of smaller partials as in a typical cards which incorporates "text", "button", "image" components?
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
We already have atoms, molecules, and organisms that we are incorporating. These can be seen here in CivicTheme
Just curious what others are using regularly in their design systems, particularly at the molecule and organism level, that could be nice to have.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Been discussing padding adjustments with Jacob. Let's decide if we'd want a "Spacer" type component to put in between components or if we want this type of padding to be handled per component.
- ๐ฎ๐ณIndia shyam_bhatt Gujarat
@kristen pol, We can include the below components to the organisms:
- Gallery: An image or media gallery with thumbnails and a lightbox feature for viewing full-sized images.
- Pricing Table: A table that compares different pricing plans with features and call-to-action buttons.
- Modal Dialog: A dialog that overlays the main content and contains text, forms, buttons, and sometimes images.
- ๐ช๐ธSpain Carlitus
Been discussing padding adjustments with Jacob. Let's decide if we'd want a "Spacer" type component to put in between components or if we want this type of padding to be handled per component.
I think it's a lot better to have margins and paddings in the components instead of having a spacer component, a spacer has no semantic meaning.
+1 for #10
- ๐ฆ๐นAustria roromedia Linz
I agree with
a spacer has no semantic meaning
but these paddings or margins need to be configurable based on different breakpoints.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks for the feedback ๐
- ๐ช๐ธSpain Carlitus
but these paddings or margins need to be configurable based on different breakpoints.
I think it is better to have this directly in all style properties.
For example, if you have margin-left you should be able to set, in addition to the default, a value for each breakpoint.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Gotcha. One place where we allow different padding is for props+components that may want more or less breathing room above/below. But, I can see for the overall spacing defaults, perhaps having these globally defined so each site has some freedom to make things tighter or more airy.
- ๐ฆ๐นAustria roromedia Linz
It would make sense to me to integrate the existing breakpoints from the themeโs THEME.breakpoints.yml file. Additionally, it would be beneficial to centrally manage margin and padding styles in the XB configuration per breakpoint with classes. For example, if we use TailwindCSS breakpoints like sm, md, lg, xl, and 2xl in our breakpoints.yml file, we can set standard padding and margin values based on these breakpoints (eg. sm:p-1 md:p-1.5 lg:p-2 and so on - either directly or if there would be classes for that already we could map this in our CSS - this would be better because we wouldn't need to add those classes to our safelist because of purgeCSS). Component-specific overrides can then be handled within the XB settings of the respective component when needed.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Thanks for the feedback ๐