Upps, sorry, i did something wrong with this MR. I will try to fix this.
carlitus → made their first commit to this issue’s fork.
@bramdriesen Could you review this issue?
This way we can know if it is something that is not interesting. Or if you are interested in, we can make the necessary modifications to merge this in a future release.
But otherwise we have to stay on this version or change the code with each new version.
thank you!
I've made a MR to change to put this:
.ck-balloon-panel {
z-index: 10000 !important;
}
Because with the old value the balloon was under and invisible. I'm using layout paragraphs, by the way, and now i can see the balloon when i click in the link button of ckeditor.
Carlitus → changed the visibility of the branch 11.x to active.
Carlitus → changed the visibility of the branch 11.x to hidden.
I think i can close the issue, because i was another module that cause this.
I've made a MR to 8.7 to add a wildcard to the end of every word.
It's a partial solution, there are some weird use cases using this.
Carlitus → made their first commit to this issue’s fork.
Something strange has happened. I created the MR but when I clicked on the link after the push I had no access. I passed it to my partner paucala and he was able to access it.
Carlitus → created an issue.
I've tried with #28 with drupal 10.3 but doesnt work.
Carlitus → made their first commit to this issue’s fork.
I've made a MR to 3.0, with the path from #3 and a small modification: rounded the min and max when are float.
Carlitus → made their first commit to this issue’s fork.
I've made a MR to add the prefix and sufix to summary filter of range sliders.
Carlitus → made their first commit to this issue’s fork.
My problem was:
I have n facets, for example:
Quality
- New (100)
- Medium (300)
- Poor (50)
Family
- Item family 1 (500)
- Item family 2 (30)
...
I want users to be able to filter on each of the facets with as many facet items as they want, using an OR.
But between the different facets it has to be an AND.
That is, if someone selects Item family 2 and Quality new and Quality Poor it would really be:
(Item family 2) AND (Quality New OR Quality Poor)
This already works this way by default, but it is not reflected in the number of results, so the logic that can be applied to the facets according to the results does not work well. For example hide a facet item if the results are 0. Or hide a facet if it is empty, having all its facet items deactivated.
Without the patch this doesn't work like that, but applying patch #44 it seems to work perfectly. Thanks to everyone who made this possible!
I'm using:
"drupal/search_api":"^1.34",
"drupal/elasticsearch_connector": "7.x-dev@dev",
"drupal/facets": "^2.0",
You are right, i don't know why i was using 2.0, sorry.
yes, thats it. It's in bat_module, without the whitespace and also without this patch all works well.
https://www.drupal.org/project/bat_api/issues/3411329#comment-15590410
🐛
With Drupal 10.2.0 the rest api doesn't return a valid json
Needs work
Thanks!
Finnaly i found it!
It's in the bat module, in bat_event.module.
The first line has a whitespace before the opening php tag.
https://git.drupalcode.org/project/bat/-/blob/8.x-2.x/modules/bat_event/...
it has
<?php
Instead of
<?php
@marc5000 i think this is another issue.
What do you recommend? should I put this MR in the other issue?
@cilifen, the workaround it's copied from here, you can see that @MLZR links to this issue.
Your welcome @MLZR, I am glad that my solution has been able to help more people.
Why is a duplicate?
It's similar but i have not the err_http2_protocolol_error, and the solutions didn't work for my problem.
It seems like a core thing, but I understand that it must be something that happens to almost no one, because there would have to be a lot more people talking about this.
The endpoint:
/bat_api/calendar-units?_format=json&types=7&ids=&event_type=availability_hourly&_=1711364361712
Without the patch:
With the patch (
https://www.drupal.org/project/drupal/issues/3432990
🐛
Content-length incorrect and response truncated in web servers
Active
):
I have put screenshots to simplify this comment, but I can put the code that returns the endpoint.
I have not any file with a php closing tag.
I've a made a core MR, more of a temporal solution, but now it works:
https://www.drupal.org/project/drupal/issues/3432990
🐛
Content-length incorrect and response truncated in web servers
Active
Carlitus → created an issue.
In this related issue https://www.drupal.org/project/bat_api/issues/3411329#comment-15458113 🐛 With Drupal 10.2.0 the rest api doesn't return a valid json Needs work , and using the last bat_api 3.1RC i get the same result, the json it's not valid.
¿Do you know if i need to do something more?
I get the same result with the last bat_api 3.1RC, the json it's not valid
I'm using this with Mercury editor, i don't remember now, but maybe I'm basing it on something that's from the mercury.
With Drupal 10.2.1 it's the same. And i see that with calendar-units endpoint (/bat_api/calendar-units?_format=json&types=8&ids=&event_type=availability_hourly&_=1704794828919) there is the same problem:
[
{
"id": "8",
"title": "P2 Lab",
"children": [
{
"id": "S119",
"title": "RNA Extraction Area",
"create_event": true
},
{
"id": "S120",
"title": "Hood 16_IRSIQ 05\/029 - Sample Processing",
"create_event": true
},
{
"id": "S121",
"title": "Hood 17_IRSIQ 05\/029 - Sample Processing",
"create_event": true
},
{
"id": "S122",
"title": "Hood 18_IRSIQ 05\/027",
"create_event": true
},
{
"id": "S123",
"title": "Hood 19_IRSIQ 05\/028",
"create_event": true
},
{
"id": "S124",
"title": "DNA extraction area 1",
"create_event": true
},
{
"id": "S125",
"title": "DNA extraction area 2",
"create_event": true
},
{
"id": "S126",
"title": "Hood DNA adition_IRSIQ 05\/024",
"create_event": true
},
{
"id": "S127",
"title": "Hood RNA adition_IRSIQ 05\/025",
"create_event": true
}
]
right! thanks @medienverbinder!
Some of these errores are like this?
Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegistry': the name "mercury-dialog" has already been used with this registry
at https://creafd10.ddev.site/modules/contrib/mercury_editor/build/js/dialog.element.min.js?s6sayk:374:1330
at https://creafd10.ddev.site/modules/contrib/mercury_editor/build/js/dialog.element.min.js?s6sayk:374:1345
at at (https://creafd10.ddev.site/modules/contrib/mercury_editor/build/js/dialog.element.min.js?s6sayk:56:291)
at https://creafd10.ddev.site/modules/contrib/mercury_editor/build/js/dialog.element.min.js?s6sayk:374:1274
at https://creafd10.ddev.site/modules/contrib/mercury_editor/build/js/dialog.element.min.js?s6sayk:374:1484
iIt's a javascript error when adding a layout element width Drupal >= 10.2.0.
I not i willl create a new issue.
Yes, confirmed.
With the last versión (3.1.0-rc1) i get a different but incomplete result:
[
{
"id": "0103",
"bat_id": 0,
"resourceId": "S103",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0104",
"bat_id": 0,
"resourceId": "S104",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "092",
"bat_id": 0,
"resourceId": "S92",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "093",
"bat_id": 0,
"resourceId": "S93",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "094",
"bat_id": 0,
"resourceId": "S94",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "095",
"bat_id": 0,
"resourceId": "S95",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "096",
"bat_id": 0,
"resourceId": "S96",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "097",
"bat_id": 0,
"resourceId": "S97",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "098",
"bat_id": 0,
"resourceId": "S98",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "099",
"bat_id": 0,
"resourceId": "S99",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0100",
"bat_id": 0,
"resourceId": "S100",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0101",
"bat_id": 0,
"resourceId": "S101",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0102",
"bat_id": 0,
"resourceId": "S102",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0105",
"bat_id": 0,
"resourceId": "S105",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0106",
"bat_id": 0,
"resourceId": "S106",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0107",
"bat_id": 0,
"resourceId": "S107",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0108",
"bat_id": 0,
"resourceId": "S108",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0109",
"bat_id": 0,
"resourceId": "S109",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0110",
"bat_id": 0,
"resourceId": "S110",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0111",
"bat_id": 0,
"resourceId": "S111",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0112",
"bat_id": 0,
"resourceId": "S112",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0113",
"bat_id": 0,
"resourceId": "S113",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0114",
"bat_id": 0,
"resourceId": "S114",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0115",
"bat_id": 0,
"resourceId": "S115",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0116",
"bat_id": 0,
"resourceId": "S116",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0117",
"bat_id": 0,
"resourceId": "S117",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
},
{
"id": "0118",
"bat_id": 0,
"resourceId": "S118",
"start": "2024-01-04T00:00:00",
"end": "2024-01-05T00:00:00",
"title": "Disponible",
"color": "#009AD8",
"blocking": 0,
"fixed": 1,
"editable": false,
"rendering": "background",
"type": "availability_hourly"
Yes!, with this MR all works like before, thanks!
And i searched before i created the issue but i didn't find this issue, sorry.
Carlitus → created an issue.
Carlitus → created an issue.
Carlitus → created an issue.
I have several groups of meetings rooms
Each group have diferent meeting rooms:
Without this MR:
I only can book in meetings room of one group, the one defined in the yml of my content type.
With the MR:
I can book in all the meetings rooms, because i don't look the configuration of the content type for the type_id
Carlitus → created an issue.
To solve this i did this:
https://www.drupal.org/project/mercury_editor/issues/3381727
🐛
Vertical and horizontal layout shift
Active
To solve this i did this:
https://www.drupal.org/project/mercury_editor/issues/3381727
🐛
Vertical and horizontal layout shift
Active
We don't use bee hotel, only bee, bat and bat_api. We use this for booking of meetings rooms.
And there is no question, sorry, only that we need this patch so we can no longer book the meetings room that the type_id inf config/sync are different.
Carlitus → created an issue.
I had the same problem, for a user not admin i dind' see any event in the calendar i cannot make a booking.
With this patch, and after i enable this two permissions form my rol, all works as before.
@sassafrass I recomend you using this module: https://www.drupal.org/project/viewsreference_filter →
It's a lot better, because the webmaster can use the exposed filters (no contextual) to define the filters of the view, and there is an option to hide this filters.
Carlitus → created an issue.
This doesn't work for me.
Steps:
View with exposed filters
Enabled: "Show Filters on Page"
Filters with "All" option, because I want the user to filter, and show all by default.
With this, no filters are applied because the code filter always with "All".
As I see there are two main scenarios:
1. I want to show the filters, but without filtering by default
2. I want to show a predefined list but without options.
The third scenario is:
I want to show a predefined list, but I want the user modify the filter. I think this is less common, and now I don't need it, and because of that I created a MR to resolve the 1 and 2 scenario.
(PD: I cannot reopen the issue)
Carlitus → created an issue.
I seem to have broken the first two laws of the drupal programmer:
First law: Clear the cache
Second law: If that doesn't work clear the cache again.
And now it works, thank you very much
I have the same problem, when i edit the view display, when using Field formatter with inline settings i don't see all the responsive image that i have.
As a temporal solution i can export config, change the responsive image id and import.
For me still doesn't work. When enabled MR38 it works as before, when i submit the field edit form, only argument and pager can be enabled in Enable extra settings.
In the config export i see this:
enabled_settings:
argument: argument
limit: 0
pager: pager
offset: 0
If i change to
enabled_settings:
argument: argument
limit: 1
pager: pager
offset: 1
and import the new config nothing happens, i don't see the limit and offset options in the entity where the field is included.
Carlitus → created an issue.
Carlitus → created an issue.
New patch for other replacements to solve the same error.
I know it's not the best to use static methods, but al least it solves the problem. Maybe the mantainer can tell me how to do it the best way and i will do it.
I finnaly upload a patch because i don't see this change in the last release and i need it.
Sorry, I've seen that in 2.x versión in gitlab the code is good. Closed.
Carlitus → created an issue.
Carlitus → created an issue.
With the 2.1 version this happens yet, and the patch of #10 doesn't work for me.
I've made a change in the MR but it wanted to put in the 2.x version and i don't know how to change, or if tis possible.
I've made a new patch instead.
Carlitus → made their first commit to this issue’s fork.
Carlitus → created an issue.
Carlitus → created an issue.
I've made it with drupal lenient:
https://github.com/mglaman/composer-drupal-lenient
And this config in composer.json
"drupal-lenient": {
"allowed-list": ["drupal/bat_api", "drupal/bat_event_ui", "drupal/bat_fullcalendar", "drupal/fullcalendar_library"]
}
I have the same problem
Ahh, yes, I use ckeditor 5, that's it then.
Thanks @keiserjb!
This may be a silly question, but how should this work?
When I'm viewing a node built with Mercury editor I don't see any way to edit the text paragraphs.
Does it have to be configured somehow?
Same, i need to enable "Limit results" but i cannot.
The problem, as @frazras comments, is that the function submitConfigurationForm never triggers but neither of this plugin nor of others of the style options.
Finally I have done it in a not very optimal way, but the only one I have seen.
From a hook_node_update I go through all the paragraphs looking for the style options that has the backgroun image and I do the same thing that should be done in the submitConfigurationForm.
This is my code in case someone wants to use it or improve it:
use Drupal\Core\Entity\EntityInterface;
use Drupal\file\Entity\File;
use Drupal\paragraphs\ParagraphInterface;
function omitsis_modular_node_update(Drupal\Core\Entity\EntityInterface $entity) {
if ('modular_page' == $entity->bundle()) {
if ($entity->hasField('field_paragraphs')) {
foreach ($entity->field_paragraphs as $paragraph) {
$paragraph = $paragraph->entity;
$style_options = om_getStyleOptions($paragraph);
foreach ($style_options as $key => $value) {
if ('background_image' == $key) {
$fid = $value['fid'][0];
$file = File::load($fid);
$file->setPermanent();
$file->save();
}
}
}
}
}
}
function om_getStyleOptions(ParagraphInterface $paragraph): array {
$style_options = [];
if ($behaviors = $paragraph->getAllBehaviorSettings()) {
if (!empty($behaviors['style_options'])) {
$style_options = $behaviors['style_options'];
}
}
return $style_options;
}
I have the same problem, @frazras did you solved this?
Rate your excitement about SDC in core: 1 ... 10 | N/A
10
Rate your excitement about potential contrib extending SDC: 1 ... 10 | N/A
10
Rate our documentation: 1 ... 10 | N/A
8
Did you 1️⃣ refactor existing template into a component, or did you 2️⃣ write a component from scratch? 1 | 2
1 & 2
Rate the helpfulness of error messages encountered: 1 ... 10 | N/A
8
Have you tried the Storybook integration? Yes | No
Yes
Any thoughts you would like to share? The sky is the limit
It would be amazing if the same yml was the source for storybook, so that no more files have to be generated, which is, although small, an extra effort.
(sorry, I messed up when adding the comment and i edited the post. I reverted it back to the previous version)
Tested with 2.1 dev and it seems that all works well
I tested again and it works
Tested and now it works well, thanks @johntarling!
Thanks @sassafrass
We have to rethink how to made this more maintainable and see how it can be done so that the module maintainers see it as something that gives value.
Carlitus → created an issue.
In case it helps you I comment some alternatives to the layout builder to have a page builder that I believe that they have very interesting points.
Mercury Editor:
This is what we are currently using. It is very intuitive and usable. Our customers have seen a big jump compared to layout builder.
It doesn't use layout builder, but layout paragraphs.
https://www.drupal.org/project/mercury_editor →
https://www.youtube.com/watch?v=OVCPu4_ZtzE&ab_channel=AtenDesign
It uses style options which allows to specify in a single yml file properties like Layout Options. Very useful to be able to pass this configuration to other sites, for example new developments.
DXPR:
https://www.drupal.org/project/dxpr_builder →
They have also dedicated a lot of effort to make it usable, with many customization options.
It is paid with subscription.
New patch, the last one was wrong
New patch to support managedFile and Ajax Callback.
I think this is not the best way to do it, but now al least works in my manual tests. I am sure that a person with more control of the core can do it in the most appropriate way.
I've see that the problem was when in the ajax callback to upload the file, the preRenderGroup was not needed and i've make a unset of the #groups in uploadAjaxCallback to skip this function.
Another issue with this.
If i have a layout inside a layout i cannot see the controls of the first level layout. But when saving the .lpb-layout with padding 0 of the modules/contrib/mercury_editor/build/css/preview-screen.css disapears and with the padding 20px i can see well the layout controls.
Provisional solution:
function hook_library_info_alter(&$libraries, $extension) {
if(!empty($libraries['preview_screen'])) {
unset($libraries["preview_screen"]["css"]["component"]["build/css/preview-screen.css"]);
}
}
Something easey for this it to give a width to component the form inside the modal:
Something like
.layout-paragraphs-component-form {
max-width: 95%;
width: 1000px;
}