Make client site entity bundeable

Created on 23 April 2024, 9 months ago
Updated 19 September 2024, 4 months ago

Problem/Motivation

Right now, the ClientSite entity is not easaly fildeable, on our side, we need this entity to have more fields, like the mantainer, the host... The better option for this is make the ClientSite entity bundeable, so people can manage it, adding fields.

On this patch, we have created this bundel entity and add some changes to install it.

Maybe is a good thing to think on a 3.0 version of this module?

Feature request
Status

Needs work

Version

2.0

Component

Code

Created by

🇪🇸Spain paucala

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @paucala
  • Status changed to Needs work 9 months ago
  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    The issue fork of this issue is empty, and there is no patch attached yet.

    Please make the changes on the issue fork as it's easier to test.

  • Merge request !12Client site bundeable → (Open) created by paucala
  • Pipeline finished with Failed
    9 months ago
    Total: 36s
    #162411
  • Status changed to Needs review 9 months ago
  • 🇪🇸Spain paucala

    Hi, sorry, we opened this issue some days ago but sudenly came a big ammount of work, so i haven't been able to finish the work on this issue till now:
    On this update we propose a major checnge on this module, deleting the actual entity, merging the fields of the url and password with the new bundleable entity.
    We think that the form should also be removed, as a view is a more simple and esay way to expose the data.
    Now users wil be able to add custom fields to this entiy, us, for exemple, want some fields such as the mantainers on the project.

    Also have implemented some minor changes, like a Null safety check on some fields, so the view shows results even if some site isn't able to reach data.

    I think that, if you like the proposal, we can work on it and release it as a new major update. A 3.0 version.

    I also would like to apply, if you think you need some help, as a module mantiner.

  • Pipeline finished with Success
    9 months ago
    Total: 164s
    #162430
  • Pipeline finished with Success
    9 months ago
    Total: 144s
    #162456
  • Pipeline finished with Success
    9 months ago
    Total: 150s
    #162598
  • 🇪🇸Spain Carlitus

    @bramdriesen Could you review this issue?

    This way we can know if it is something that is not interesting. Or if you are interested in, we can make the necessary modifications to merge this in a future release.

    But otherwise we have to stay on this version or change the code with each new version.

    thank you!

  • Status changed to Needs work 4 months ago
  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    Just went over the changes (code wise, did not test). It makes sense to do this, as I can see not everyone requires the same amount of fields.

    Given the big change of going to bundles it makes sense to create a 3.x version for this yes.

    Didn't check in dept, but does this require changes to the client module as wel?

  • 🇪🇸Spain paucala

    Thanks for the answer, I'll review the coments as soon as I can.
    Ansewering your question, the only changes required on the client side are the ones on this issue:
    https://www.drupal.org/project/status_dashboard_client/issues/3361398 Add more info to the status report Needs review
    On wich we added some new fields.

  • Pipeline finished with Success
    4 months ago
    Total: 151s
    #285204
  • Pipeline finished with Success
    4 months ago
    Total: 161s
    #285997
  • Merge request !14new branch to match current version → (Closed) created by paucala
  • 🇪🇸Spain paucala

    paucala changed the visibility of the branch 3442895-bundleables-entities-new to hidden.

  • Pipeline finished with Success
    4 months ago
    Total: 135s
    #286005
  • Pipeline finished with Canceled
    4 months ago
    Total: 77s
    #286008
  • Pipeline finished with Success
    4 months ago
    #286010
  • Pipeline finished with Success
    4 months ago
    Total: 143s
    #286989
  • 🇪🇸Spain paucala

    I've added a few changes and try to correct the errors you marked @bramdriesen

Production build 0.71.5 2024