Belgium 🇧🇪
Account created on 7 January 2016, over 9 years ago
#

Merge Requests

More

Recent comments

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Assigning credits.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Thanks for looking into this and providing support!

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Updated link and title structure

🇧🇪Belgium BramDriesen Belgium 🇧🇪
🇧🇪Belgium BramDriesen Belgium 🇧🇪

That commit only updated the info.yml, so not sure where things went wrong :-)

🇧🇪Belgium BramDriesen Belgium 🇧🇪

yet they are maintained by individuals who are part of the security review or advisory process.

What exactly is this referring to? People with the vetted role so they can opt-in a module? Let's use correct terminology :)

🇧🇪Belgium BramDriesen Belgium 🇧🇪

See #34 and #39

To propose improvements, you would need to accurately describe the current processes and how what the changes would be.

That has not been done in this issue, only misrepresentation. Categorising the responses you've received as a lack of 'openness' is further misrepresentation of the issue.

Those need to be in the issue summary (hence the tag "Needs issue summary update").

🇧🇪Belgium BramDriesen Belgium 🇧🇪

i don't neither understand the current status of the issue what mean, what are the needed information from which mantainer?

The status reads: Maintainer needs more info.

Meaning, the moderators need more info from you, the reporter. As we're just circling around about what the goal here really is.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Can you create an issue fork and merge request?

I also don't think we need such a "complex" IF-ELSE structure.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

I think you forgot to upload the image. Also looks like the wrong type of tab indenting was used (see eslint report).

error Replace `↹↹↹↹↹` with `··········`

🇧🇪Belgium BramDriesen Belgium 🇧🇪

@bigbabert I think you're misinterpreting a lot of things being said here. The fact if a junior can or can't write code with or without bugs really doesn't matter here. The real issue is that people are just blindly "accepting" what those LLM's generate and push potentially dangerous code if they don't take the time to properly review what was generated.

I'm using CoPilot in PhpStorm since it's release. And I must say, what it spits out sometimes really makes my eyes frown. It's a really handy tool to have, and does save a lot of time, if used properly. I'm only using it to write single lines of code, more like a "autocomplete" like you are suggesting. For things that I used to google each time (such as the date function in PHP, some specific entity/database query, or even just translating .po files) it really saves time. But when it tries to do larger things, I always skip it since the output is still not good enough to be used. Even the most simple design principals are skipped, resulting in poorly written and none performant code. Fixing and reviewing all those things are simply not worth it, and it's a lot faster if I just write it myself, properly from the first time (pretty much what Cmlara is saying in #40).

Again the thing to take away here is: AI works great, if used and monitored properly. And I don't think many people have issues with using AI like that. The push back in this issue is about entirely generated modules, without proper knowledge/review of what it's doing. Yes what it spits out might work when you tested it, but is it safe? Performant? Following Drupal's or even just PHP best practices (not talking about PHPCS et al)?

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Hmm not as trivial.

Drupal\Component\Plugin\Exception\ContextException: The 'entity:node' context is required and not present. in Drupal\Core\Plugin\Context\Context->getContextValue() (line 73 of core/lib/Drupal/Core/Plugin/Context/Context.php).
🇧🇪Belgium BramDriesen Belgium 🇧🇪

Can we create a merge request for this?

Looking at the code removed in the setSessionInfo function, the php code doc should also be changed?

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Re #7, probably not, but that was the default value when creating a core security issue from the security team docs ;-).

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Adding a related issue which was mentioned in the private issue queue. However to me that is not the issue here but a broader discussion.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

add Switzerland 

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Works great :-)

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Going to re-roll this for 3.x

🇧🇪Belgium BramDriesen Belgium 🇧🇪

This seems to be a regression from adding D11 support.

https://git.drupalcode.org/issue/minisite-3524424/-/commit/340184efdee81...

So this might need to be solved differently.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Great to see this happening 🙌 my votes go to:
- Marine Gandy (Mupsi)
- Joris Vercammen (borisson_)

🇧🇪Belgium BramDriesen Belgium 🇧🇪

I didn't test nor investigate this yet, but noticed the cache_metadata is set to -1. Doesn't that effect this as well.

Also need to check how the Drupal core node view for example does caching, as this is just an admin overview.

Will leave it at NR for now. Thanks for the report and merge request @alorenc

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Also updated in the event.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Think Jonas also deserves credit no? :-)

🇧🇪Belgium BramDriesen Belgium 🇧🇪

I noticed today that the user is seeking guidance on how to contribute properly on slack.
https://drupal.slack.com/archives/C1BMUQ9U6/p1745611803988939

Alberto Cocchiara
:palm_tree: 10:10 PM
hi all, I'm a Solution Architect working on Global project in the past 12 years, some of this are on Drupal where i moved my first step in Enterprise CMS practice, nowdays i work on Adobe AEM mostly but i want to give back something to Drupal community, that i'm part from almost 7 years, so i'm looking for a mentor to be guided to properly contribute in an effective way, thanks to anyone can point me or become my mentor :good-luck:

🇧🇪Belgium BramDriesen Belgium 🇧🇪

No problem! Thank you for the MR 😇

🇧🇪Belgium BramDriesen Belgium 🇧🇪

@mfrosch Please don't name an issue fork branch the same as the base branch in the future :-P it's a nightmare to work with when you want to rebase set base branch on the issue fork.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

bramdriesen made their first commit to this issue’s fork.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Will tag a new release because of the broken update hook.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

No activity over 2 days, un-assigning. Feel free to pick this up again.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

I would advise against this. Just imagine you're using this to store the database credentials, and somebody manages to do a screw up on production wiping the entire file. Meaning if this was done through the UI, Drupal would crash and you have to scramble to find someone to fix the file on the server. You might also not want everyone to be able to get access to those secrets, having the possibility as a site admin to just enable this via a module, seems a bit as a risk to me.

I guess this can also happen there, but at least a sysadmin shouldn't make such a mistake :-).

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Just needs a rebase, there is another issue open also adding an update hook so let's wait for that one.

Tested, could reproduce and this MR fixed the issue.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Code is also not OK, this is part of the entity already, no need to define a new basefield. No upgrade path provided either.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

We could look into implementing this with a recent core feature. Not that much logic needed for this.

https://www.drupal.org/node/2896596

🇧🇪Belgium BramDriesen Belgium 🇧🇪

If you applied the patch from issue 🐛 Entity mismatched after 1.6.0 to 2.0.0-alpha3 upgrade Active which was not rebased, you're overriding the update hook. poll_update_8007 should be the install of the field. poll_update_8008 should belong to the issue you are referencing.

Please check what is in your install file after applying the patches.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Isn't this more a Drupalorg Infra ticket? If I'm not mistaken that queue is responsible for the GitLab CI pipelines.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

I tested MR !103 from @ericgsmith and this seem to cover our use case as well. Since it's more flexible as the first approach, I would assume this is the better way to go.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Thanks @ivnish

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Patch looks good, no longer shows the generic login error when the user is created in a blocked state.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

I believe there are some other ways as well like ignoring some files.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Great! Thanks

🇧🇪Belgium BramDriesen Belgium 🇧🇪

To add something meaningful to this issue (beside my tests above :-) ), I updated the technical details code snippet.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

This is now implemented for anonymous users. Not sure if this is needed for none anonymous users.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Works as expected now, thanks! Merged :-)

🇧🇪Belgium BramDriesen Belgium 🇧🇪

This introduced a warning

Deprecated function: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\openid_connect_windows_aad\Plugin\OpenIDConnectClient\WindowsAad->__construct() (line 82 of modules/contrib/openid_connect_windows_aad/src/Plugin/OpenIDConnectClient/WindowsAad.php).

Created a follow up: 🐛 Deprecated function: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\openid_connect_windows_aad\Plugin\OpenIDConnectClient\WindowsAad->__construct() (line 82 of modules/contrib/openid_connect_windows_aad/sr Active

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Feel free to re-open if still relevant. But I would assume this is indeed fixed.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Hi,

The easiest way for you to achieve this I think is to create a custom entity/node with an entity reference field to "Poll". That way you can link multiple polls to your entity and render them. That way you still have control over each poll separately.

I don't really see/understand the need to have this feature in the Poll module itself.

🇧🇪Belgium BramDriesen Belgium 🇧🇪

This can be taken up again since 📌 Anonymous users - Multiple voting from one IP Needs review landed.

I would go for the checkbox approach as mentioned in #6

🇧🇪Belgium BramDriesen Belgium 🇧🇪

Number 2 is included in the "regular" poll. The others would be nice features although I'm not sure what the concordset exactly is.

Production build 0.71.5 2024