Skip Display to own activities not working as expected

Thanks for the merge request!

I don't remember by hearth how notifications are stored, so I'll need to manually test this change.

I was starting to think I was the only one unable to make this module work. I have the recommended configuration in the block.
- Notification content: As logged-in user
- Skip Display to own activities

But by default, after installing and uninstalling the module several times (both 1.x and 2.x versions) No notification showed.

If I turned off: Skip Display to own activities checkbox, a user would see notices for their own activities, but not other people's. Setting the block to show notifications "As Admin" seemed to show everything to everyone.

I applied the patch from @andileco, and that makes the module work as I expected it to. Authenticated users now see notifications of actions by other users.

I recommend merging this with the next module release.

Thanks for testing. Merged and will tag a new release

We applied the latest alpha today and the notifications counts for all of our users were all off, showing all notifications to all users. Tracking backwards it was this commit that caused the issue and specifically the part that removed this line from the query:
$query->condition('n.entity_uid', $uid); When that line is re-applied the notification counts are all correct again.

In case it's helpful for context we're using the notifications_widget.logger service in a custom module to add a custom notification for each user in a comment thread (except the comment author) when a new comment is added.

Going to mark this as needs work in case others are experiencing the same thing.

Hmm that should not happen. I think the whole if/else section could be simplified to also improve readability.
And o boy, what a bad variable naming happened when this module was created 😅
I think a small description for what "Skip Display to own activities" does would also help.