🇺🇸United States @andileco

andileco → created an issue.

Thank you for your work on this, @tommasorandazzo! Would you be willing to take a look at the branch I created? This allows one to have a package.json at the root like:

{
"name": "foo",
"private": true,
"scripts": {
"postinstall": "npm run libraries:copy --workspaces --if-present"
},
"workspaces": [
"web/modules/***/**/*"
]
}

and when you run `npm install`, it puts the libraries into their proper folders (if you only wanted certain charts submodules, you could adjust the workspaces).

You are clearly more adept at using npm than me, so please let me know if your thoughts on this approach.

Hi! This is mostly working well, except in the case where the field plugin is used and the "Enable fields by default" is checked. In that case, the sort removes the selection (for checkboxes or multi-select), although the fields stay in place. Please see the attached video.

Hi all, I don't use Commerce myself, and so testing this always proves to be a big hassle. This ticket is also marked for 8.x-1.x, which is two versions back. @dahousecat is your patch for 3.0.x? If so, please update the ticket. If someone can provide some steps to repeat and test the patch, I would appreciate it.

Hi @chike! For our use-case, we do have some user roles who create and edit certain types of nodes, and it's a less disruptive user experience if they are not switched between an admin and front-end theme. I believe this patch will work with Claro, Gin, and Bootstrap, as it uses a more generic selector. So, it might be worth it for the maintainers to incorporate.

We don't have a convention for charts_library_type, but we do for charts_library_extendedfeature. Check out how Highcharts is handling additional files (JS modules) and the relatively new library+type method. We might not need a separate module.

andileco → created an issue.

Thank you! There's a minor issue where if you move from the third option to the second (on a taxonomy term field), then it looks different than if you move from the first to the second. But I'm going to make it a follow-up issue.

For some reason, GitLab wanted to apply my patch to the 8.x branch versus the 2.x branch. The MR that's showing now is the one to use.

andileco → changed the visibility of the branch 3543115-select-parents-automatically to hidden.

@yospyn, please try this MR. Make sure to clear your cache (including browser cache so the updated JS file loads). For me, this works on a Bootstrap Barrio-based subtheme and continues to work with Claro. Please let me know if the same goes for you.

The failed code quality tests shown in the MR pipelines are from the existing codebase and are not related to my patch.

andileco → made their first commit to this issue’s fork.

andileco → created an issue.

Thank you! This is working well.

Thank you, and sorry for the delay!

andileco → made their first commit to this issue’s fork.

Things seem to be working well - thank you!! One thing that I think needs to happen from a UX perspective is to provide a message if the user selects an option but the underlying data doesn't support it. For example, if there are no fields of a select type, then we should have a message that no eligible fields were found. For example, all three options show up for me for a view based on Views CSV Source.

Haha, thank you, but you made it easy. Yes, it appears the underscore in "3542281-improve-charts_chartjs-readme" might be what caused the issue.

andileco → created an issue.

@jofitz - the infrastructure team though the underscores in the branch name may have been the issue, so I created a MR to test. However, I will commit yours.

Going to reach out to the infrastructure team so that I can do this through the D.O. interface. Thanks!

I think this is just the commit, not the MR - can you make sure you've submitted the MR? That way the code quality steps run. If those pass, this looks good to me.

andileco → created an issue.

Needed a slight tweak if you turn the CDN back on.

Thank you! Going to issue a new release.

Thank you! I will check and issue a release tonight or tomorrow.

andileco → created an issue.

Spotted two minor PHPCS issue - fixing those.

Tested the various operators included in the numeric field. Also checked that the existing filters continued to work as expected.

andileco → created an issue.

andileco → created an issue.

andileco → created an issue.

andileco → created an issue.

Thank you!

andileco → made their first commit to this issue’s fork.

andileco → created an issue.

OK, I've added a video of how to make a chart with a chart attachment. Apologies for the lack of voice in the video. Let me outline the steps:

1. Add a view of Charts Usage Statistics content type, with the initial display being a page.
2. Add a field to hold the value (in this case, I choose "7.x")
3. In the Format section, select a chart with "Title" as the label and "7.x" as the data provider.
4. Preview to make sure it works
5. Now add a "Chart attachment" display. I chose to "Clone as chart attachment" to save a little time.
6. Configure your chart attachment as needed, remembering to select "This display" for everything, INCLUDING the format (the form where you select "Chart" versus "Table" or "Unformatted list). In my case, I added an "8.x" field and in the chart settings selected that as the data provider. I also used a column for this display instead of a line.
7. Make sure you "Attach" your attachment to the Page display.
8. Preview your attachment to make sure it works.
9. Toggle to the Page display: you should see both your main chart and the chart attachment.

If you follow these directions and still have an issue, can you either post a video here like I did (I made this with Slack) or send me a DM (@andileco) on the Drupal Slack workspace?

Can one of you share which library you are using and what chart types you are wanting? Then I can make a video showing what to do.

To be honest, I lost track. I think this should definitely be reviewed, though. Thanks for working on this module!

matthews → credited andileco → .

andileco → created an issue.

It's already committed to Charts dev, so you would just need to require drupal/charts:dev-5.1.x and then apply the User Interface changes mentioned in the ticket.

Hi @sirclickalot, have you seen this issue and tried this solution already? https://www.drupal.org/project/charts/issues/3532198 ✨ Highcharts dark mode support and styledMode Active

Did you save Highcharts in the Charts Default Settings form (under Config > Content Authoring)? Or any other details you can provide? I am having trouble recreating the issue. Thank you!

Thank you for your work on this, @stefan.korn! I know you haven't marked this as "Needs review" yet, but I see an issue and wanted to suggest an alternative approach.

Before I do that: the issue is that I looked into the other charting libraries that are bundled in the Charts module, and it seems like most don't actually have a lot of styling options for title and subtitle, including font size. Highcharts, which is probably the reason the title_font_size key exists, no longer has a title font size option in their API because the library automatically adjusts the font size based on the amount of text and the size of the chart.

So, I don't want to add fields where they don't do anything and the user thinks something is broken when in actuality the field was just for a different charting library. These types of fields DO exist in the module (e.g. "Make the chart three-dimensional"), but only for historical reasons, and I have unwritten plans to remove them in a later version.

What I think you should do is refactor at least some of your code into the "addBaseSettingsElementsOptions()" method in Chartjs.php (you may need to add it, but you can look to Highcharts.php for an example of how to do so). This will make the settings for title/subtitle font size appear as soon as "Chart.js" has been selected as your library. There's a video about this here: https://www.linkedin.com/posts/daniel-cothran-43878218_drupal-charts-dat... and there are several recent issues about it, too: https://www.drupal.org/project/charts/issues/3458753 ✨ Add support for PieChart colorAxis options Active , https://www.drupal.org/project/charts/issues/3528781 ✨ Add StackLabel option for Highcharts Active , and https://www.drupal.org/project/charts/issues/3493686 🐛 Billboard and C3 not using custom colors for Pie or Donut charts Active .

Please let me know what you think!

Quick question...did you try dev? Also, what base field did you use for your media type?

Thank you for this report, @jonathan_hunt. I like this approach. I'm working on this!

@catch - I created it. This approach works for me. I didn't *find* any files in my site that contained "use strict" outside of a function.

andileco → created an issue.

I agree we shouldn't show that button if it's not applicable. I would be interested in a setting/property on libraries where they can define whether or not they support this option, and then if they don't, that's what determines if the checkbox shows or not.

By the way: the color-changer code isn't part of any library - it's custom to this module - so I would like to actually add the color changer on more libraries as a longer-term goal.

Thank you for your recent contributions, @stefan.korn! Would you be willing to do a quick assessment of which libraries support setting the title font size? If it's not available with all of them, we may want to do something similar to the other issue you worked on with the color changer.

OK, now C3.js is addressed too. @superfedya, please copy the D3 repository in the updated README file and then overwrite it in your composer.json. Run composer require --prefer-dist c3js/c3:0.7.20 d3/d3:4.9.1 and your d3 library should now contain d3.min.js.

Whoops, I did this for Billboard.js (a fork of C3.js). Need to replicate the solution for C3.js, which uses an older version of D3.

This is fixed thanks to @ivan zugec, who shared the solution in a streamed tutorial about the Charts module: https://www.youtube.com/live/ANzw3y8maFk?si=-CTj0j3T9Zvaa4dV&t=1827

andileco → made their first commit to this issue’s fork.

Thank you! Committed.

andileco → made their first commit to this issue’s fork.

andileco → created an issue.

That's fine, was just trying to have a single place where all the optional libraries are toggled on and off. I'll take a look at the updated MR tomorrow my time.

Thanks for clarifying. I think we need the option to bring in the library or some sort of validation that prevents users from doing something they're not going to like. What about like one of these, except it says, "Enabled styledMode" (with a link to more info)?

If I disable styled mode, then I actually get a nice, dark-mode chart.

This is very cool and thanks for this write-up and patch! When I use your MR, I am getting a black, infinite-scrolling box where the chart should be (see uploaded screenshare video). Did you experience this? Do you have any other configurations in your site?

andileco → created an issue.

andileco → created an issue.

andileco → created an issue.

andileco → created an issue.

andileco → created an issue.