🇺🇸United States @andileco

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

Thank you!

andileco → made their first commit to this issue’s fork.

@jdgamsterdam - I tried on simplytest.me and was able to uninstall. The trick is after clicking the "Reset to Default Configurations" button, you don't save that page again. Just go directly to Extend > Uninstall, and uninstall the submodules. Then uninstall Charts. Can you please try again?

Also, sorry to see you go! Please let me know if there was a feature that wasn't present and made you want to try a different solution.

This also addresses the field and argument.

Setting this back to "needs work", as this will only work when the view is aggregated. We have another solution that I will commit soon.

andileco → changed the visibility of the branch 3452355-make-filter-selector to hidden.

andileco → created an issue.

andileco → created an issue.

Thank you for the nice write-up and patch. Fixed.

andileco → made their first commit to this issue’s fork.

andileco → created an issue.

@Dylan Donkersgoed - I slightly modified your code at https://www.drupal.org/project/charts/issues/3449184 🐛 Fix bubble chart for Google Charts Active . Would you be willing to try out that patch?

andileco → created an issue.

This looks good! It also inspired me to fix a couple things, particularly related to Bubble charts.

andileco → made their first commit to this issue’s fork.

andileco → created an issue.

andileco → created an issue.

Hi @vistree - apologies for the delay. I've uploaded two videos. Can you take a look and let me know if they help?

Found a typo after committing.

1) removed extraneous files (that never should have been there)
2) added a requirements check for either charts_highcharts or charts_highstock
3) added the appropriate dependency library to Highmap.php
4) flagged the js as minified
5) added the type option in Highmap.php
6) updated the version to the latest Highcharts used in the Charts module
7) updated the README
8) marked Drupal 11 compatible
9) ensured PHPCS passed

andileco → created an issue.

andileco → created an issue.

andileco → created an issue.

andileco → created an issue.

Have you looked at https://www.drupal.org/project/external_entities → and decided that definitely does not work for your use-case?

This was merged in GitLab.

This is fixed. In this situation, you would use code like this in MYMODULE.module:

function MYMODULE_charts_plugin_supported_chart_types_alter(array &$types, string $chart_plugin_id) {
  if ($chart_plugin_id === 'MYLIBRARY') {
    $types = array_diff($types, ['area', 'bar', 'bubble', 'column', 'gauge', 'line', 'scatter', 'solidgauge', 'spline',]);
  }
}

This new hook, which is added to charts.api.php, could also allow you to add additional chart types.

function MYMODULE_charts_plugin_supported_chart_types_alter(array &$types, string $chart_plugin_id) {
  if ($chart_plugin_id === 'MYLIBRARY') {
    $types[] = 'candlestick';
  }
}

I tested and confirmed it works - thanks again!

Thank you for your patch! If you wanted to, you could add that identical code in the C3.js class.

Billboard.js and C3.js are a little neglected within the Charts module just because I end up using Highcharts for my work. I appreciate you identifying, posting, and patching!

andileco → changed the visibility of the branch 3437972-enable-aggregation-options to hidden.

andileco → made their first commit to this issue’s fork.

@Liam Morland please see the video I added. Is this what you did?

Can you please explain how the later version is not compatible and why we couldn't just patch that version?

andileco → created an issue.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

That's amazing! You can just add a MR/patch to this issue. I'm away from my computer, but will get back to you on the documentation.

Need to sit and think about the API, but wanted to alert you to https://drupal.org/project/views_csv_source, which we are going to have in really good shape by the end of the week.

andileco → created an issue.

@cballenar, I think the difference is updating the libraries to version 11. Will look into this!

andileco → created an issue.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

@drupaler99 - please try the merge request (patch: https://git.drupalcode.org/project/charts/-/merge_requests/85.patch) and let me know how it goes!

andileco → made their first commit to this issue’s fork.

andileco → made their first commit to this issue’s fork.

For some reason that I can't figure out, I can't get any patch for this module to apply on my hosting provider (Pantheon). It works fine locally. So if anyone else is facing this situation, here's what I did:

1) I removed my patch in composer.json

2) I created replace_bootstrap_styles_yml.php inside a directory I named "scripts" inside my root, with the following inside:

<?php

// Define the path to the file.
$file_path = './web/modules/contrib/bootstrap_styles/bootstrap_styles.info.yml';

// Read the current content of the file.
$content = file_get_contents($file_path);

// Replace the specified line.
$new_content = str_replace(
  '  - media_library_theme_reset:media_library_theme_reset',
  '  - layout_builder_iframe_modal:layout_builder_iframe_modal',
  $content
);

// Write the updated content back to the file.
file_put_contents($file_path, $new_content);

echo "Replacement complete.\n";

3) I added the following inside my composer.json:

    "scripts": {
        "post-update-cmd": ["php ./scripts/replace_bootstrap_styles_yml.php"],
        "post-install-cmd": ["php ./scripts/replace_bootstrap_styles_yml.php"]
    },

4) Committed and pushed (Pantheon - if you're using the "build step" - runs composer install each time you push, which triggers this script).

Note that you'll need to adjust this based on whether or not you're using the "web" directory or if you have a different name for the folder your "contrib" modules go into.

The code for media_library_theme_reset will still exist in your codebase, but because the dependency for it is no longer in bootstrap_styles, you can uninstall the module via Drush or via that UI.

andileco → created an issue.

Thanks for sharing your work! We'll take a look.

andileco → created an issue.

Would someone please make a merge request from the latest patch? The code looks good, but I like to see the pipeline results that run on merge requests.

Hi, I'm going to close this ticket and point you to this module that my colleague and I just created: https://www.drupal.org/project/views_csv_source → .

It's not production-ready yet, but it would be great to get feedback from users like yourself on its issue queue.

Thank you - fixed!

Remaining issues will be addressed in the (older, but more complicated) ticket added as a related issue.

Thank you and apologies for that oversight! I'll issue a new release today.

andileco → created an issue.

Thank you - committed!