- 🇬🇧United Kingdom fonant
Works for me with Drupal 9 if I patch with #3 then #18.
- Issue was unassigned.
- 🇮🇳India mukhtarm
Hi I am using D9.5 and here is the patch that works for the custom date fields (I combined the #18 and #3 basically, but there were some tweaks needed as #18 was not applying cleanly). It works well to apply the custom SQL format to the custom field. Thanks
- 🇵🇹Portugal lolgm
I'm using D10.1 and patch #22 is working as expected, however, I'm getting the following warning:
Trying to access array offset on value of type null views_date_format_sql.views.inc:34 Undefined array key "field" views_date_format_sql.views.inc:34
The attached patch fixes this problem.
- 🇵🇹Portugal lolgm
@MukhtarM I'm having a problem with the patch.
It seems to me that something went wrong with the combination of patch #3 and #18.
The code below is referencing a plugin that does not exist in the current patch.if (!empty($field['field']['id']) && $field['field']['id'] === 'date') { $field['field']['id'] = 'views_date_format_sql_date'; }
Could we remove this one?
- Status changed to Needs review
about 1 year ago 7:20am 15 November 2023 - last update
about 1 year ago 4 pass, 1 fail - 🇮🇳India mukhtarm
@lolgm Actually the patch didn't included the new plugin file (my bad :( ). Corrected it and included your changes also. thanks.
- last update
about 1 year ago 4 pass, 1 fail - 🇬🇧United Kingdom fonant
Patch in #26 applies cleanly to 3.x-dev and fixes the problem, Drupal 10. Thanks @MukhtarM!
- First commit to issue fork.
- First commit to issue fork.
- Merge request !14Resolve #2978329 "Using Views Date Format SQL options on custom date fields" → (Open) created by loze
- 🇺🇸United States loze Los Angeles
Patch #26 was no longer applying to the the latest dev version, so I've created MR14 with the changes in #26
here is a patch to use for composer