Account created on 26 April 2013, about 11 years ago
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom littlepixiez

Apologies if my flow in Gitlab is incorrect for this merge request - first time doing it totally outside of the issue queue. Let me know if I need to do anything differently next time!

πŸ‡¬πŸ‡§United Kingdom littlepixiez

littlepixiez β†’ changed the visibility of the branch 3299708-remove-d7-tpl-file to hidden.

πŸ‡¬πŸ‡§United Kingdom littlepixiez

littlepixiez β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom littlepixiez

littlepixiez β†’ changed the visibility of the branch 3414743-preprocess-hook-change to active.

πŸ‡¬πŸ‡§United Kingdom littlepixiez

littlepixiez β†’ changed the visibility of the branch 3414743-preprocess-hook-change to hidden.

πŸ‡¬πŸ‡§United Kingdom littlepixiez

Closing this as works as designed as there are hooks to achieve what you need.

πŸ‡¬πŸ‡§United Kingdom littlepixiez

I'm going to close this as it is 10 years old now and the site was moved to D9. Again thanks for the great module though. :)

πŸ‡¬πŸ‡§United Kingdom littlepixiez

I've added the code, although to be honest, upgrading for it to be compatible with GA4 includes the currency code in the new code: https://www.drupal.org/project/commerce_google_tag_manager/issues/3190724 ✨ Support Google Analytics 4 Needs review so this will probably be rendered obselete!

πŸ‡¬πŸ‡§United Kingdom littlepixiez

Ah, just reviewing this - I think our problem is that our content type was created AFTER the node_read_time was set up, so it didn't have a value in the config. This patch fixes the error though. :) Thanks for the great module!

πŸ‡¬πŸ‡§United Kingdom littlepixiez

I need to add tests for this, but I've done the initial commit that provides the context provider.

πŸ‡¬πŸ‡§United Kingdom littlepixiez

Thanks for the patch @mmbk. I've used your changes as inspiration to apply the same changes to the 8.x-1.x branch, which is slightly different in that it uses V2 API and isn't loading external libraries. Similar approach:

1) .install
- Add requirements to check access_token is set
- Remove old config for client_id and client_secret and remove oauth access/refresh tokens from state API

2) AdminSettings form
- Remove disconnect button and oauth submit functions
- Remove client_secret & client_id and replaced with access_token
- On submit, authorize the access_token and store it with the state API, not in config

3) Hubspot API service
- Changed authorize function to check access token and compare the portal ID to ensure it's correct. If not, it removes the access_token in state
- Removed oauth retry for refresh token
- Changed isConfigured to check for access_token

Would be good for others using 1.x to review this. Wasn't sure whether to open another issue or not!

πŸ‡¬πŸ‡§United Kingdom littlepixiez

Closing this as https://www.drupal.org/project/mailchimp_transactional/issues/3279838 πŸ› TypeError: Drupal\mailchimp_transactional\API::send(): Return value must be of type array, ConnectException returned Needs review basically is the same problem, and at the moment, patch #7 fixes the problem.

Production build 0.69.0 2024