TypeError: Drupal\mailchimp_transactional\API::send(): Return value must be of type array, ConnectException returned

I just tested and the first merge request does apply to the latest version of the module, 1.0.1. If there are other places this needs to be fixed, why not commit to the existing MR like @Janec did? I don't see a reason to open a new one, it's just a potential source of confusion.

nielsva → made their first commit to this issue’s fork.

Agreed, MR 11 could easily be updated with MR12, just merged that into MR 11 so that is leading again. We're currently patching this issue, using the attached patch extracted from the MR.

Just to be clear, this probably needs some extra work, handling all the exceptions from the api.

Whoops, scratch that, wrong patch. This should be the correct one:

DieterHolvoet → closed merge request !12

I did some more changes: I got rid of all try/catches, since exceptions are being caught and returned anyway. I also noticed the return type of ApiInterface::getUser isn't nullable, but we're returning null if the request failed. I fixed that.

@DieterHolvoet Code review there looks good to me!

Thanks everybody!

Why is the array cast to an object and then put inside an array? Why not just return the array?

Automatically closed - issue fixed for 2 weeks with no activity.