Prevent combining carts from different stores

Created on 27 September 2022, almost 2 years ago
Updated 17 April 2024, 2 months ago

Problem/Motivation

When you have multiple carts of different stores with different currencies, and you log in and it tries to combine carts, you'll get a currency mismatch exception.

Steps to reproduce

1. Create two stores with different default currencies.
2. In the different stores, make two carts (with different currencies).
3. Login and get error.

Proposed resolution

Add a condition to skip combining carts if the store IDs don't match.

Remaining tasks

Figure out why it isn't combining all the store carts when logged in. It only combines one of the store carts, and creates two of the extra one. The below patch fixes it so that it atleast combines the cart with one of the main ones...

Thanks for the excellent module! :)

πŸ› Bug report
Status

Needs work

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom littlepixiez

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024