Should we store a salted IP address to maintain visit uniqueness?
$settings['hash_salt']
$salt = \Drupal::getContainer()->getParameter('hash_salt');
$hashed_ip = hash('sha256', $salt . $ip_address);
I think all this only makes sense if there is full coverage in UnitTesting?
It is useful without full coverage. It finds breaking changes and other things when running the code in different versions of Drupal.
You can also use the Filter plugin instead of the field plugin and you will not have this issue.
bluegeek9 → created an issue.
bluegeek9 → created an issue.
bluegeek9 → created an issue.
bluegeek9 → changed the visibility of the branch 2.0.x to hidden.
bluegeek9 → made their first commit to this issue’s fork.
There hasn't been activity on this issue in years and 8.x-1.x is End of Life.
bluegeek9 → created an issue.
Thank you for you contribution to the project. Drupal 7 is end of life. We encourage you to update to a modern version of Drupal.
Thank you for you contribution to the project. Drupal 7 is end of life. We encourage you to update to a modern version of Drupal.
Thank you for you contribution to the project. Drupal 7 is end of life. We encourage you to update to a modern version of Drupal.
Thank you for you contribution to the project. Drupal 7 is end of life. We encourage you to update to a modern version of Drupal.
Thank you for you contribution to the project. Drupal 7 is end of life. We encourage you to update to a modern version of Drupal.
You need to reorder the fields. The On/Off field needs to be below fields it will use. These are the same requirements to use other fields when rewriting the results.
bluegeek9 → created an issue.
bluegeek9 → changed the visibility of the branch 8.x-1.x to hidden.
bluegeek9 → made their first commit to this issue’s fork.
bluegeek9 → created an issue.
bluegeek9 → changed the visibility of the branch 3544079-sha256 to hidden.
bluegeek9 → created an issue.
I am interested in making a Word cloud module using chartjs and the wordcloud library.
https://www.npmjs.com/package/chartjs-chart-wordcloud
What should the machine name be charts_chartjs_wordcloud ? I want to be consistent with the charts ecosystem.
bluegeek9 → changed the visibility of the branch 3.0.x to hidden.
I sent restyler a message through the contact form requesting to take over the namespace.
bluegeek9 → created an issue.
bluegeek9 → created an issue.
jdleonard → credited bluegeek9 → .
No - I checked out a smoke test branch to keep things consistent while I was planning out smoke tests.
You should only report bugs after you have confirmed it exists in the latest dev branch, and have not already been reported.
bluegeek9 → created an issue.
bluegeek9 → created an issue.
Are you using the latest dev release?
This sounds very similar to 🐛 Error prevents adding phone number to contact Active
bluegeek9 → created an issue.
Drupal 10 is still using Annotation for ConfigEntityType, so I did not convert the name_list_format and name_format entities.
Also, I did not update plugins for Feeds and Diff.
Feeds only support Annotation at the moment.
I wal unlue if I should convert the Diff plugin to Attributes since the dependency is dev.
bluegeek9 → changed the visibility of the branch 2.x to hidden.
bluegeek9 → made their first commit to this issue’s fork.
bluegeek9 → created an issue. See original summary → .
I am inclined to close this as works as designed.
There is an issue to rename crm_field since it now only contains the external crm field.
📌 External Identifier field Active
Current Group integration is limited to adding Contacts (crm_contact) to Groups as content.
bluegeek9 → created an issue.
bluegeek9 → changed the visibility of the branch 1.0.x to hidden.
bluegeek9 → changed the visibility of the branch 1.0.x to hidden.
bluegeek9 → changed the visibility of the branch 1.0.x to hidden.
bluegeek9 → made their first commit to this issue’s fork.
I added Unit and Kernel tests for the Element\Name.php
What you are describing is the expected behavior.
2.0.0 does not include the changes in this issue.
I updated the MR to use DeprecationHelper::backwardsCompatibleCall
Maybe this should be the same as add Taxonomy term form:
'Save' and 'Save and goto list'.
bluegeek9 → made their first commit to this issue’s fork.
I don't know if PHP 8.2 is available. It appears there is not an 8.2 image.
re-saving the view from UI will actually fix the schema for given view.
RC2 did not deliver upgrade paths for views, which it should.
I believe upgrade paths are only available for stable releases.
bluegeek9 → created an issue.
I added Kernel and Functional tests.
I updated NameFormatter.php::getListSettings()
I think my change is correct, but should be reviewed.
I use ddev. It includes phpcs and phpcbf.
I also work on Drupal issues everyday :)
Hi John,
For MR 65, I updated it to exclude office_hours.api.php from the code coverage report.
https://project.pages.drupalcode.org/-/office_hours/-/jobs/6283709/artif...
I will make a seperate MR for testing Drupal 10.2 with php 8.2 support later today.
What you are describing is the expected behavior.
This will install the latest release, 2.0.0
composer require drupal/change_pwd_page:^2.0
This will install the dev release.
composer require 'drupal/change_pwd_page:2.0.x-dev@dev'
jdleonard → credited bluegeek9 → .
I think it would look like this. I do not know if 8.2.19 is supported/valid, it is the latest 8.2 release.
I haven't tried testing specific core versions before.
composer (10.2):
extends: .composer-base
stage: build
variables:
_TARGET_PHP: 8.2.29
_TARGET_CORE: 10.2.12
phpunit (10.2):
extends: phpunit
rules:
- when: on_success
needs:
- "composer (10.2)"
variables:
_TARGET_PHP: 8.2.29
_TARGET_CORE: 10.2.12
I update the issue with a description.
The office_hours.install has one hook_update_N() inside another hook_update_N(). I also added tests.
https://git.drupalcode.org/project/office_hours/-/merge_requests/70/diff...
This is the link to the workflow default settings. If you do not have access you can request to be made the project owner.
https://git.drupalcode.org/project/workflow/-/settings/repository#branch...
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
I fixed Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps and added a unit test form the office_hours.module file.
bluegeek9 → changed the visibility of the branch 3542418-phpcs-xml-dist to hidden.
bluegeek9 → created an issue.
The StatusUpdateController has 100% code coverage.
https://issue.pages.drupalcode.org/-/office_hours-3542502/-/jobs/6280948...