- Issue created by @finn lewis
- π³π±Netherlands johnv
In the past, one could test against different version of PHP.
The new system does not support that, I believe.When developing, I work in 1 version, so, indeed, sometimes a PHP8.3 feature was built in, innocently.
Now, I have several issues for this and other module that should be postponed, until 8.1 and 8.2 are not supported anymore.If you have any tests failing, I am happy to revert some code.
Please create an issue in that case. - π³π±Netherlands johnv
I now see thisis possible with gitlab:
- https://lostcarpark.com/drupal/future-proofing-your-module-and-dependenc...
But it requires phpunit tests for full code coverage, and that is missing in my modules. - First commit to issue fork.
- Merge request !65Issue #3529359 by bluegeek9: Testing different PHP versions β (Open) created by bluegeek9
- π³π±Netherlands johnv
Thanks,
just committing as-is, and awaiting what happens with it. - πΊπΈUnited States bluegeek9
You can see the repos code coverage overtime here: https://git.drupalcode.org/project/office_hours/-/graphs/8.x-1.x/charts
- πΊπΈUnited States bluegeek9
bluegeek9 β changed the visibility of the branch 8.x-1.x to hidden.
- πΊπΈUnited States bluegeek9
I updated the code coverage to exclude office_hours.api.php
- π³π±Netherlands johnv
Nice page, #10.
Can you also tell me how to change the default branch (not yet for this module, but already for e.g., workflow module) ?
I cannot find it. And Google and drupal.org give me outdated answers. - πΊπΈUnited States bluegeek9
You need to be the administrator, not just a maintainer.
It gitlab, it is the settings menu on the left, and at the bottom.
https://git.drupalcode.org/project/workflow/-/settings/repository#branch...
- π³π±Netherlands johnv
I am the only maintainer. How do I promote myself?
And:
how to add a test for D10.2 with PHP8.2 ? - πΊπΈUnited States bluegeek9
If you are the only Maintainer than you should have access. Which project is this for?
- π³π±Netherlands johnv
I have changed version naming for workflow, workflow_notifications, and will do this for office_hours, languagefield.
For those I am de facto the only developer. - πΊπΈUnited States bluegeek9
This is the link to the workflow default settings. If you do not have access you can request to be made the project owner.
https://git.drupalcode.org/project/workflow/-/settings/repository#branch...
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... β
- π³π±Netherlands johnv
THanks, I created an issue for later follow-up: π¬ Offering to be project owner/administrator Active
- π³π±Netherlands johnv
Coming back to #15. Is this possible?
"How to add a test for D10.2 with PHP8.2 ?" - πΊπΈUnited States bluegeek9
I think it would look like this. I do not know if 8.2.19 is supported/valid, it is the latest 8.2 release.
I haven't tried testing specific core versions before.
composer (10.2): extends: .composer-base stage: build variables: _TARGET_PHP: 8.2.29 _TARGET_CORE: 10.2.12 phpunit (10.2): extends: phpunit rules: - when: on_success needs: - "composer (10.2)" variables: _TARGET_PHP: 8.2.29 _TARGET_CORE: 10.2.12
- π³π±Netherlands johnv
Setting this to Active again, since there is a need to add above test for PHP8.2, D10.2
- πΊπΈUnited States bluegeek9
Hi John,
For MR 65, I updated it to exclude office_hours.api.php from the code coverage report.
https://project.pages.drupalcode.org/-/office_hours/-/jobs/6283709/artif...I will make a seperate MR for testing Drupal 10.2 with php 8.2 support later today.
- Merge request !71Draft: Issue #3529359 by bluegeek9, johnv, finn lewis: Testing different PHP versions β (Open) created by bluegeek9
- πΊπΈUnited States bluegeek9
I don't know if PHP 8.2 is available. It appears there is not an 8.2 image.
- π³π±Netherlands johnv
I invited Finn Lewis (original poster) to join the discussion here.
Finn, please check the changes, and if the last pending patch makes any sense for you.
I think all this only makes sense if there is full coverage in UnitTesting?