The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs work
about 1 year ago 1:33pm 19 June 2023 - π·π΄Romania radubutco
Re-rolled it against 11.x, also applies on 10.1.x.
- Status changed to Needs review
about 1 year ago 1:34pm 19 June 2023 - last update
about 1 year ago 29,499 pass, 1 fail - Status changed to Needs work
about 1 year ago 2:08pm 19 June 2023 - πΊπΈUnited States smustgrave
Was previously tagged for tests which still need to happen.
- First commit to issue fork.
- Merge request !57303032353: Patched views per https://www.drupal.org/node/3032353. β (Open) created by COBadger
- First commit to issue fork.
- Status changed to Needs review
6 months ago 1:15am 10 February 2024 - πΊπΈUnited States COBadger
Re-rolled patch for 10.2.x and added test coverage.
- Status changed to Needs work
6 months ago 4:35pm 12 February 2024 - πΊπΈUnited States smustgrave
Tests should be added to the MR. But it needs to be cleaned up as there are now a mix of patches and MRs with no explanation or interdiffs between them.
Also issue summary should follow standard issue template.
- π§πͺBelgium p-neyens
New patch starting from comment 42 β¨ Exposed forms in a block are not currently updated when Ajax filtering is executed Needs work but with adding the missing use.
Error: Class "Drupal\views\Controller\RenderContext" not found in Drupal\views\Controller\ViewAjaxController->ajaxView() (regel 222 van /var/app/web/core/modules/views/src/Controller/ViewAjaxController.php). Error: Class "Drupal\views\Controller\BubbleableMetadata" not found in Drupal\views\Controller\ViewAjaxController->ajaxView()
- π§π¬Bulgaria SimeonKesmev
There are instances where the form ID can have uniquifying suffix, so here is a change to account for that.
The whole approach looks fragile to me as in theory there can be multiple blocks on the page.
Also I have problem with the facets as the parameter "exposed_form_display" does not get attached, as commented in #28. What is the use case for it?