Account created on 7 May 2013, almost 11 years ago
#

Merge Requests

Recent comments

🇬🇧United Kingdom andy_w

Assuming this is no longer an issue, given the timeframe.

🇬🇧United Kingdom andy_w

I suspect that you would need https://www.drupal.org/project/role_delegation (but closing this ticket now, as I suspect the user has solved there issue).

🇬🇧United Kingdom andy_w

I would like to apply to be a maintainer of this project, we make use of it, and have the amends to make a drupal 10 ready version.

🇬🇧United Kingdom andy_w

Added a sub-module, currently only works with the media gallery image upload.

🇬🇧United Kingdom andy_w

Apologies, I missed this, I agree, and have just added a few extra comments.

🇬🇧United Kingdom andy_w

In order to resolve the issue we need to use the BookManagerInterface as drupal 10.2 changed to use a proxy class for the book manager (see https://www.drupal.org/node/3397515 )

🇬🇧United Kingdom andy_w

The mysql Connection now resides in its own module, so I've attached an amend to the patch.

🇬🇧United Kingdom andy_w

As it stands at the moment the suggestion mode simply populates the alt text field on upload, ready for the user to either overwrite or accept (i.e. not overwrite) the suggestion.

🇬🇧United Kingdom andy_w

It strikes me that I must have missed something, but it seems like extracting the other associated issues we are left with the fact that the edit / delete links do not currently work if the field is not a multi value element (i.e. it has no delta). Would an adequate solution to this be the assignment of a delta of 0, as this appears to allow the editing/deleting of the scheduled instance.

Apologies if I have misunderstood the ticket.

🇬🇧United Kingdom andy_w

I began looking at this issue, and could see that the forward revisions were not included, the attached patch will cause future revisions to be included in the dynamic view. There is still an issue around moderation state and datetime that requires further work.

So in short the patch will show all valid rows, it will however be missing the future publishing state and execution time.

🇬🇧United Kingdom andy_w

Added a patch for this behaviour.

🇬🇧United Kingdom andy_w

Thanks @jeroen_vreuls I missed that, and it turned out that caused issues for us as well, and low and behold you had already fixed it!

🇬🇧United Kingdom andy_w

I've re-factored the patch to work on 1.1 and switched to using a checkbox as it does make sense to either redirect to the front page or to the setup form.

🇬🇧United Kingdom andy_w

Sorry about that, a very good reason not to copy & paste a solution into another file :facepalm

🇬🇧United Kingdom andy_w

One possible solution in light of the inline JS being used to prevent this problem in the toolbar (admittedly not a nice solution) would be to use a similarly unpleasant inline css solution to prevent that initial flash of menu.

I offer this merely to see if it sparks an alternative solution, I will continue to try to find a better solution when I can find a bit more time.

🇬🇧United Kingdom andy_w

Thanks for identifying this issue jerrac, I have updated the patch now that the node_type condition has been removed (see https://www.drupal.org/project/drupal/issues/1932810 )

🇬🇧United Kingdom andy_w

I have made a start on the process to update this drush command to work with drush 11, this is not yet fully tested but I'm aiming to find some more time to work on this soon.

🇬🇧United Kingdom andy_w

As this issue is still ongoing, I'm not sure if this is helpful but here is the updated patch from 34 to work with the 2.x branch.

🇬🇧United Kingdom andy_w

Additional to this Drupal 10 also requires all queries explicitly set accessCheck as part of the query (see https://www.drupal.org/node/3201242 ) therefore the request to fetch all view_mode_page_patterns requires ->accessCheck(TRUE) to support Drupal 10.

🇬🇧United Kingdom andy_w

Potentially a new suggestion plugin for handling media absolute url's.

🇬🇧United Kingdom andy_w

We had a similar use case, and I'm afraid I'm not sure if this is helpful for either this use case or the module in general (apologies if not).

We needed to extend the module to utilise the source entity (i.e. when displaying a form on a node page) and then display that source entity dynamically in a given view mode.

Attached is the patch that we used for this (great module btw, thanks).

🇬🇧United Kingdom andy_w

Really impressive find, but as you mentioned it does seem to be throughout the drupal core codebase. Including the tests themselves. So I've added the update to the the tests in BrowserTestBaseTest (which failed above).

Production build https://api.contrib.social 0.61.6-2-g546bc20