While debugging an issue with a menu cache tag I noticed that the tags will be invalidated even if the menu didn't change. As menus are usually used on most pages on the site this can result in a large number of invalidations in the CDN for no reason. MenuTreeStorage::doSave already checks to see if the menu item changed, so we can leverage this information to only clear the cache tags if it did.
Set a conditional breakpoint in CacheTagsInvalidator::invalidate for the config:system.menu.main cache tag. Save the menu without changing anything, and the cache tag will be invalidated.
Only save if it has changed.
N/A
N/A
Changing the return value of MenuTreeStorage::doSave to return a boolean value instead of the menu name in the array. Currently it returns an associative array like main => main. Change to main => TRUE. This is a protected method so should be ok to change as it's internal?
N/A
Active
11.1 🔥
menu system
Even though categorized as a task, maybe could be feature request, seems like a change that needs test coverage
I'm happy to write tests, however before I do maybe someone familiar with the menu system can review the approach and see if this is a sensible change?