Node edit form re-saves menu items even if no change has occurred

Its worth mentioning that menu link weight has a similar patch for a very similar observation,

The test bots don't test patches any more. Please would you open a merge request?

I have a suggestion for a simpler change that might work.

MR also needs tests.

As I understand it $entity->hasTranslationChanges() will only give us the output we are after if the menu is setup to use translation, which is why I wrote it off in the first place (though I could be wrong, and hope I am, as it would be a much nicer solution).

On a standard profile install, hasTranslationChanges() detects changes on the entity without content translation enabled.

andy_w → changed the visibility of the branch 3486604-node-edit-form to hidden.

The actual issue here appears to stem from the fact that the doSave method on menu tree storage still returns the current menu even if no changes were detected - causing an unnecessary cache clear.

The code suggests an exit early state but it still returns with the current menu, causing follow on actions.

andy_w → changed the visibility of the branch 3486604 to hidden.

It would appear that this was flagged as a follow up action many years https://www.drupal.org/project/drupal/issues/2302137#comment-12070910 → and further discussed here: https://www.drupal.org/project/drupal/issues/2876343 →

However this has a significant impact upon a sites performance if every time an editor saves a page in the menu system (without making a change to the menu) the whole site is essentially cleared from the cache.

My assumption is that the failing tests (in unrelated aspects of the system) are based on the fact that they require a cache clear and are relying on an incidental cache clear to occur based on this change.

@andy_w, shall we close this one and focus on https://www.drupal.org/project/drupal/issues/3485030 📌 MenuTreeStorage shouldn't invalidate cache tags if the menu didn't change Active instead?

I agree @dmitry.korhov

Closed as duplicate of https://www.drupal.org/project/drupal/issues/3485030 📌 MenuTreeStorage shouldn't invalidate cache tags if the menu didn't change Active