πŸ‡΅πŸ‡±Poland @dmitry.korhov

Poland, Warsaw
Account created on 14 March 2016, over 8 years ago
#

Merge Requests

Recent comments

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

If that's for Drupal CMS and not for every installation, why not to use separate `node/config/install` sub-folder that will install the relevant config?

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

gitlab shows that there is a conflict in .module file, please rebase and fix

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

It seems that no more work is needed so we can go further

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

Looks good, approved.

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

@andy_w, shall we close this one and focus on https://www.drupal.org/project/drupal/issues/3485030 πŸ“Œ MenuTreeStorage shouldn't invalidate cache tags if the menu didn't change Active instead?

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

@alexpott

vendor/bin/drush ev "var_dump(\Drupal\Core\Site\Settings::get('yaml_parser_class'));"
/vendor/drush/drush/src/Commands/core/PhpCommands.php(32) : eval()'d code:1:
NULL

Drupal version : 10.3.5
PHP version : 8.3.13
Drush version : 12.5.3.0

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

Looks straightforward, so there are no issues with merging this.

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

patch from latest comment did not apply on macOS, re-created fromdiff

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

Hi laurii,

Would be nice to respect all the contributors with credit for participating in resolving this issue.

Thanks

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

re-rolled agains latest version of module which is compatible with drupal 10.1

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

re-rolled for 10.1

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

dmitry.korhov β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

re-roll on drupal 9.5.x branch

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

Hi @mark_fullmer,

We are using this patch for almost 3 months and I can confirm that it works as expected.
Thanks for your efforts (and marking it as RTBC :) )

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

dmitry.korhov β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

`mixed` return type should not be used, we know what kind of entity|variable is returned.

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

The field only displays overridden layouts, it does not work with default layouts.

There is a workaround for it, we managed it by triggering Enhancer (from JSONAPI Extras) manually in some event

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

@kuhikar please add interdiff

πŸ‡΅πŸ‡±Poland dmitry.korhov Poland, Warsaw

Any news so far? This functionality is pretty essential for decoupled Drupal.
Is https://www.drupal.org/project/drupal/issues/3151275 β†’ a blocker?
Can we have this patch released at least as experemental module?

Production build 0.71.5 2024