- Issue created by @dmitry.korhov
- Status changed to Postponed: needs info
11 months ago 1:04pm 11 January 2024 - 🇦🇲Armenia murz Yerevan, Armenia
In the
onFinishRequest
the module only ends the request span:public function onFinishRequest(FinishRequestEvent $event): void { if (!$this->isSpanInitialized) { return; } $this->requestSpan->end(); }
without any uploading or additional actions, so this should be executed almost instantly.
All trace info uploading is done in the
OpentelemetryService::onTerminate()
event subscriber, which executes after finishing sending the request to the client browser, so should not affect the request response time at all.Please recheck the exact stage of the request in which this 600-700ms delay happens.
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
It is true that both
finishRequest
andonTerminate
increases the response time
1. I i feel, in
onRequest
method should only work for http kernel::MAIN_REQUEST
2. Is it possible to useBatchSpanProcessor
instead ofSimpleSpanProcessor
https://docs.newrelic.com/docs/more-integrations/open-source-telemetry-i...
https://github.com/open-telemetry/opentelemetry-collector/blob/main/proc... - Status changed to Active
10 months ago 4:41am 16 January 2024 - 🇦🇲Armenia murz Yerevan, Armenia
Yeah, using BatchSpanProcessor should improve the performance, so I'll prepare an MR with this change.
- 🇦🇲Armenia murz Yerevan, Armenia
Tested the MR - works well, so committing and closing.
- Status changed to Fixed
10 months ago 5:45am 17 January 2024