CKEditor 5 should respect <textarea disabled>

Seems test-only patch passed.

MR should probably be updated for 11.x as that's the current development branch. Could be backported from there.

JeroenT → closed merge request !4038

The last submitted patch, 10: 3362386-10-test-only.patch, failed testing. View results →

Thanks for the test-only patch.

Think this is good. Could almost move to feature request though.

Asked question on the MR.

Could we extend the tests to include an additional text field?

re-rolled for 10.1

I've tested the MR with multiple CKEditor5 fields and the MR works.

The example on https://ckeditor.com/docs/ckeditor5/latest/features/read-only.html also uses the same ID "docs-snippet", which can be found in the following js files:
https://ckeditor.com/docs/ckeditor5/latest/snippets/features/read-only-h...
https://ckeditor.com/docs/ckeditor5/latest/snippets/features/read-only/s...

Still think the tests should be expanded for when there are multiple ckeditors on a form and only 1 is being disabled.

I've extended the tests to check if it still works with multiple fields.

Thanks!

Wim Leers → made their first commit to this issue’s fork.

Fixed nits, RTBC++ — thank you, @JeroenT!

Committed b00c941 and pushed to 11.x. Cherry-picked to 10.1.x as a non-disruptive bug fix. Thanks!

lauriii → closed merge request !4282

Hi laurii,

Would be nice to respect all the contributors with credit for participating in resolving this issue.

Thanks

@dmitry.korkhau Thank you for your contributions to Drupal! I agree that it would be nice to grant all participants with issue credit. However, Drupal Core maintainers are trying to encourage contributors to contribute in ways that help the issue move forward. This means that we are not granting credit for certain types of participation that are not helping the issue move forward.

In the case of #16, the issue had been converted to an MR, meaning that posting additional patches of the MR is not helping the issue move forward. For that reason, I didn't grant credit for the additional patch posted.

More information on the issue credit guidelines → .

Closed the duplicate (but older issue 😅) at ✨ CKEditor 5 doesn't honour #disabled: enable CKEditor 5's readonly mode Closed: duplicate .

Automatically closed - issue fixed for 2 weeks with no activity.