Logic in code doesn't follow the logic in settings.

Created on 23 July 2020, almost 4 years ago

Updated 31 May 2024, about 1 month ago

Hi there,

when I was setting up the module I figured out, that some settings did not take effect ,although there was no reason for that.

Steps to reproduce

Sub-issue 1

Go to module settings at /admin/config/content/content-notify
Set up the first tab "Notify user of old content" and nothing else.
Email recipient will never get an email, because there is an extra condition in the NotifyExtendForm.php at line 170 if (!empty($entity->unpublish_on->value)).

This condition is not necessary, as this feature should only check if a content is old, it has nothing to do with scheduling.

Sub-issue 2

In our use case, we are using the workflow module, but don't want use the workflow settings in Content notification. So the Criteria variable (set on line 559) is still FALSE at line 592. Then the next code hunk "syncing the unpublished time" is run because of it. And at the end of this hunk is a return so nothing more will get ever evaluated.
I don't think the return should be there. Next parts are independent and should run as well.
Maybe my fix is not the correct one, but there is something in the logic which seems not exactly right.

Go to module settings at /admin/config/content/content-notify
Set up the first tab "Notify user of old content" and nothing else.
Email recipient will never get an email, because there is a return in content_notify.module at line 608.

Patch for both sub-issues will follow.

🐛 Bug report

Status

RTBC

Version

2.0

Component

Code

Created by

🇨🇿Czech Republic Petr Illek

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 month ago →
🇬🇧United Kingdom andy_w
Currently this module works fine if workflows module is not used, or if the content notify date is set manually in the field.

However the default date is ignored currently due to the erroneous return (as highlighted above) if the workflows module is enabled but transitions are not used as part of the module configuration.

This patch does not go back and rectify old data, if you had been using this module with existing data this patch will not fix existing data, but will allow the default to be populated on new and updated content going forward.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024