🇨🇿Czech Republic @Petr Illek

petr illek → created an issue.

Nice to see it is moving forward.

Could we use SVG's for icons, and convert PNG's to WEBP?
E.g. this image https://new.drupal.org/assets/styles/large/public/2024-09/unicef-case-he... is 1.2MB large.

And for the showcase section it might be actually better to have the dashed frame as SVG and only change the image inside.

petr illek → created an issue.

Hi,
I accidentally stumbled on this issue and got some notes and ideas.

I think the logo is too complicated.

• It does not need to contain the module name, as in most of the cases the logo will be accompanied by the module name in a text variant.
• The most important part (the counter) is the smallest element on the image
• The count is too specific (does the module allow another values or not?)
• The count is wrong – the text in the field "MaxLength" is 9 characters :D

I did try to simplify the logo to the very base of the module feature.

tonypaulbarker → credited petr illek → .

Petr Illek → created an issue.

Petr Illek → created an issue.

@mrshowerman I tested your patch. It is doing what expected. There is just one tiny issue I have found. The setting page `/admin/config/media/media-library-edit` is only accessible from the widget setting of each field. But should be also visible in the menu system.

Merge request created. It took a bit of trial and error (and help from Daniel Pickering) to find how to do that. :)

I've tried to do the initial integration, mainly looking at other tags how they were done.
If I install the OpenGraph submodule I got the new field. But not sure if anything special needs to be done to update existing installations and if there is need for extra test for new field.

Petr Illek → created an issue.

@RobBNL I would asume it is a safe value for the start. When you use it the HSTS instruction is being stored outside your server in a central DB from where the browsers are taking the information. If you do have some misconfiguration, or issue with SSL certificate, it may render your site inaccessible for a long time. So it is better to start with a quick turnaround and when you are sure all is working properly, then you can set a longer period.
Miminum max-age to be included in the preload database is 31536000 seconds (1 year).
More info here: https://hstspreload.org/.

Hi Paul and others,
my photos are on Flickr, they should be all under the appropriate CC license (if not let me know, I will change that). Feel free to use any of these if they fit your needs.

Adding a simple fix, which fixed the issue for me.

Petr Illek → created an issue.

Petr Illek → created an issue.

Thank you Rachel!

🥳

Thank you @rachel_norfolk for being picky,
I've reverted the changes and left there only the one regarding the newly added code.

A side note – and feel free to point me to a discussion if that was (and I'm sure it was) already being discussed before.
I must admit I on one hand like the strict approach with doing the code only for what is described in the issue. I understand the need for that as it is easier to do the CR. On the other hand if it is a merely a coding standard fix, does not this approach slow down the overall development?

MR for v 4.x prepared.

Hi,
I run into the issue as well. According to my finding it is indeed the issue with webform layout elements (webform_section).
I did not realized this issue was marked with version 2.x, so my MR is branched from that version.
Will switch over to Version 4.x (as that seems to be the one currently maintained) and will post the MR once again (if that is possible).

Petr Illek → made their first commit to this issue’s fork.

I realize I forgot to update the Readme file.

Looks fine to me now.
The target blank is annoying, but not a blocker for having this again working.

I tested the patch, and can see the map tiles comming from new location.
But there are tiles randomly missing, still displaying the same message already mentioned.
I do not have Stadia account, but if it is required, it would be good to mentioned it on the settings page in the "Map provider…" section.

Personally I would remove all the target="_blank" from the code as that is mostly considered a bad practice.

Thanks for the reviewing almost in realtime! Highly appreciated.
You were right, I copied that piece from the Mapbox snippet. I looked at the others and it was everywhere. So I removed it as it does not make any sense. Not sure if there might by some JS (or other code) somewhere doing something according to the target value??

I've also done some updates on the Mapy.cz attribution so it should look ok in more situation (now it was in second line thanks to the Olivero styling).

To answer your question about the dev account. I don't know, but I'll be writing them soon, so I will ask. ;)

@ressa
Sorry for the confusion. MR now ready.

Hi,
adding initial MR with the required functionality.

Petr Illek → created an issue.

It seems that this issue is solved in the latest DEV version.
For details have a look at related issue https://www.drupal.org/project/path_redirect_import/issues/3396112 📌 Drush 12 compatibility RTBC .
Please test it, so we can get the new release soon.

Hi Pablo,
I try to use the new dev version and it is no longer producing any errors while trying to export the config.
From that perspective it seems the issue is fixed.

Hi,
I'm reopening this as I've just been hit with this issue. I've tested it on a fresh install on Simplytest.me with Drupal 9.5.10.

Steps to reproduce

1. Install the site
2. Log in
3. Go to /admin/content
4. The initial tab name is "Content" – I want to change it to something else e.g. "Customised content"
5. Go to /admin/structure/views/view/content
6. In Page settings column click Menu: Tab: Content
7. Rewrite to Customised content
8. On the next step (Parent menu link) leave it, or rewrite to "Customised content parent"
9. Save the view
10. Go to /admin/content
11. The tab should be "Customised content", but it is still "Content"

Use case

On a site I do have a special content type, which is most important for that site and there is thousand of nodes. It also requires extra filtering. So I have created a new display for the default content view set up just for this content type. And I need to move this page display to the first default poistion. Would be nice if this default tab could have different name than content. The non-default tab could have customized names and they are showing it.

smustgrave → credited Petr Illek → .

@john.karahalis
According to my observation the domain access module does not limit the users to log-in to domain they are not assigned to.
But there is a module Domain Login Restrict → which is adding this behaviour. Although the module is working I need to point out, that it is a bit weird as the configuration is not exported (more info in this issue 🐛 The configuration is not exported Active ).

Petr Illek → created an issue.