Update Stamen map tiles to use Stadia hosting

Thanks! It does looks like an account is required, and a fee to be paid for Commercial use "... defined as any usage by a company which is for-profit, or as part of a product that is sold or generates revenue.":

We've set up an onboarding flow specifically for Stamen users to make the migration as easy as possible. No credit card is required to create an account, and we offer a free tier for non-commercial users.

... where you can then register a domain with the account:

Domain-based authentication is the easiest form of authentication for production web apps. No additional application code is required, and you don't need to worry about anyone scraping your API keys.

https://docs.stadiamaps.com/authentication/#domain-based-authentication

I added all the available Stamen layers and subsets, please review.

Thanks! I looked over the code and tested with the Stamen Toner style. The tiles successfully load on both a local dev site and an AWS-hosted site. I confirmed that it's no longer requesting tiles from stamen-tiles-*.ssl.fastly.net, now only tiles.stadiamaps.com. On the public site, once I deployed the change, rebuilt caches, and registered for domain-based authentication with Stadia, the "basemap tiles will no longer be available" message no longer appeared. (On the dev site the message never appeared.)

Great, thanks for a fast review, and for confirming that the patch works as expected!

I updated the Stamen license link, so changing status.

I tested the patch, and can see the map tiles comming from new location.
But there are tiles randomly missing, still displaying the same message already mentioned.
I do not have Stadia account, but if it is required, it would be good to mentioned it on the settings page in the "Map provider…" section.

Personally I would remove all the target="_blank" from the code as that is mostly considered a bad practice.

Thanks for a fast review! I agree very much about target="_blank" and never use it personally. But that's the format they want .... If you check for example Stamen Watercolor attribution, and I think we need to respect that.

You're correct, Stadia requires an account, so I added info on the form about that, and updated the patch.

Looks fine to me now.
The target blank is annoying, but not a blocker for having this again working.

As I try this out, I’m amused by the quote Development from 127.0.0.1 or localhost does not require setting up a domain; these requests will "just work". — especially as I’m currently using DDEV running on Codespaces and my iPad to check - I have to localhost…

Ah - tiny thing but it’s worth updating - there’s an update to the Google terms of service link in the README that seems out of scope of the issue. Can you remove that change from the MR, set back to RTBC and I’ll merge?

If you want to create a follow up issue for the Google terms link, that’d be great!

Sure, thanks!

When this and the other improvements such as retina support are committed, perhaps a fresh release could be considered? The last one was Nov. 2022. I have created 📌 [Meta] Release version 2.2 Active to keep track of the issues.

@rachel_norfolk and @ressa, I'm missing the most important thing of the Stamen update and that's the API Key. The whole point of the switch to stadia.com, is that you need to register and retrieve an API Key to use the maps in Drupal.
Right now it works only on localhost and I don't think we only build local websites here ;).

The best way is to add an extra field in the backend for the API key. And 'navionics' is already doing that, so why don't do the same?

Stadia recommends domain-based authentication:

... the easiest form of authentication for production web apps. No additional application code is required, and you don't need to worry about anyone scraping your API keys. We recommend this for most browser-based applications.

Domain-based authentication

I have updated the link to point to that anchor, to make this clearer. What do you think?

Hi folks here ... I jumped on this "unpassant" as I don't have much time for the Leaflet More Maps module, but still I care as I can deploy new releases on this.
I quickly tested the leaflet_more_maps-3393412 MR locally (I have a Stadia account but the API Key is not needed locally) and none of the Stadia maps work for me. Am I missing something or the MR still doesn't fix this issue properly?
Please let me know when this is fully RTBC so that we could deploy into new release ...

Oh well I can see that also @berramou is able to generate new releases of Leaflet More Maps ... (isn't it?)

Thanks for looking at this @itamair. You're correct that using API Key is an option.

But Stadia recommends using "Domain-based authentication", so If you're using DDEV, you need add a property called for example "DDEV" and *.ddev.site.

I have expanded the info text in the form page, to make this clearer. Is it better now?

Update Issue Summary, adding "Domain-based authentication" info.

I like it. If someone can test that this is now working, describing the steps they took to test it, I'll merge it.

Awesome, thanks @rachel_norfolk. I am adding a method for testing the MR without a Stadia account to the Issue Summary.

@Petr Illek: I saw target="_blank" got removed in 🐛 Attribution links open new windows without informing user Fixed , and have also deleted them here.

Wouldn't it be great to get this MR committed?

berramou → closed merge request !5

Automatically closed - issue fixed for 2 weeks with no activity.