🇫🇷France @berramou

It works for me without implementation __wakeup(), it doesn't seems necessary because the parent BackendPluginBase already implementing __wakeup method.

  /**
   * Implements the magic __wakeup() method.
   *
   * Reloads the server entity.
   */
  public function __wakeup(): void {
    parent::__wakeup();

    if ($this->serverId) {
      $this->server = Server::load($this->serverId);
      $this->serverId = NULL;
    }
  }

Hello,

yes this is still an issue on Drupal 10.2.X with the 8.x-2.0-beta6 version.
I attach new patch that fix this issue.

I attach a patch that fix this issue.

Ah sorry my bad, it's D7 issue you still have the issue with version 7.x-1.17 ?

Hello @alekas thank you for your report.

Is this behavior normal for this filter?

Yes this module allows you search in all content event if they are in the past, your issue is not related to this module.
You need to add another condition to your views, for example in the upcoming events view should ad Filter criteria the pull only content with date after today and the do the same with Past events.
If you do so and place the filter in your views will give you the right results.

You are welcome @ressa, thank you for your contribution.
Yes he can make me maintainer.

Thank you @paulvandenburg for reporting this, and for the issue.
You can still reproduce this issue with new releases 2.2 ?

Anyone can reproduce this issue ?

Yes you are right @ressa it should be 2.2-dev, i just created a new branch 2.2.x but i can't make it default branch i don't have this permission.
Thank you @demonde for your report i will publish new release 2.2.1 today.

Hello,
Thank you for reporting this, yes you are right it works better with tile.openstreetmap.de/{z}/{x}/{y}.png
with the actual code some it's missing graphics.

I will let this issue open for some time if anyone face the same issue or if you could give more details how to reproduce this.

I can't reproduce this error, it seems not related to this module.

berramou → created an issue.

Thank you @ressa for your help done, i added credit in those two issues.

New release 2.2.0 has been created https://www.drupal.org/project/leaflet_more_maps/releases/2.2.0 → 🎉
Thank you all for your work!

Thank you @ressa for your help, yes of course i give you credit sorry i din't pay attention that you are checked for credit.

I just review and validate ✨ Add support for GDPR-friendly openstreetmap.de Needs review
I will create a new release when i have some time.
Thanks everyone for your work!

It's already implemented in GIN theme.
Go to /admin/appearance/settings/gin in the Logo image uncheck Use the logo supplied by the theme and upload the logo you want.

Thank @Anybody,
Do you have any contact of Centarro guys ?

I can help maintain this module, if someone can give me maintainership access!

Hello @Nico,
Since you are the only maintainer, if you can give me co-maintainer access, i could help you keep this module going, i help fix issues prepare stable releases for D10 and D11.
Thank you for your contributions.

I tried to fix unit tests this commit, but still 3 errors to fix, and maybe add other tests for dynamic breadcrumbs.

I just fixed the conflicts and update the code in feature/megre_dynamic-breadcrumbs branch
@Greg Boggs Let me know when you have time to look at the MR.

berramou → created an issue.

Here is a step by step to upgrade to commerce_license 3.X if you are using recurring_period
https://www.drupal.org/project/commerce_license/releases/8.x-2.0 →

It seems not required anymore, they already merge its code into commerce_license.

berramou → created an issue.

+1 for the patch it works for me too.
Thanks @dineshkumarbollu

Thanks @wells!

berramou → created an issue.

Hello @Webbeh,
Thank you for your interest, i added you as a maintainer.
I know it's a late, sorry ;)

Thank you for your report it's duplicate of 🐛 Error: Call to a member function getValue() on null in entity_embed_link_form_entity_embed_dialog_alter() (line 23 of /var/www/web/modules/contrib/entity_embed_link/entity_embed_link.module) Fixed
I close it as fixed

berramou → created an issue.

berramou → created an issue.

Fixed in the release 4.0.0.

I just pushed a commit to add hook update and into hook_install if the module DB installed migrate it's configuration and uninstall it
https://git.drupalcode.org/project/easy_breadcrumb/-/merge_requests/99/d...

I just committed https://git.drupalcode.org/project/dynamic_breadcrumb/-/commit/42220efd8...
I assumed that the merger will be in the next release 2.0.7, if it's not the case, we can change the version later just before create the new release of DB.

Still have hook update in the release of merge if the DB already installed, we should migrate the config to EB and uninstall DB module.

Yes, it's a good idea to give user the ability to config or alter routes where they want to apply the builder.
I created this issue 📌 Due to the merge into Easy Breadcrumbs add hook_install Active to prevent both modules be installed in the same time after the merge.

berramou → created an issue.

Thank you all your reactivity, support, and contribution.

Yes, you are right adding extra hooks always good 😉, itself good, the hook to add more allowed routes is mandatory otherwise the custom entities even if the dynamic breadcrumbs configured it will not work because it will not pass the if condition.
I was wondering just about the hook alter if it has really a value.

Phpunit tests should be fixed, and do more testing of the features, i did test but not all the cases.

I don't think it's a good idea, if we have multiple fields of office hours, you will have more than one identical ID within the same HTML page, which is not recommended.

I fixed Drupal CS and i added a hook to give developer the possibility to add their own route, this hook is useful when you have custom entities
https://git.drupalcode.org/project/easy_breadcrumb/-/blob/feature/megre_...

I hesitate about the alter maybe we don't need to give the possibility to alter allowed routes, maybe someone don't want dynamic breadcrumbs to be applied on taxonomy routes, but they can do it in configuration just donc check Taxonomy term entity type.
Anyway when you have time you can review the the MR.

It's a duplicate of 🐛 office_hours.js hides other [Add] buttons in widget Needs review ,
@jonas139 can you please help us test the patch https://www.drupal.org/project/office_hours/issues/3422607#comment-15461107 🐛 office_hours.js hides other [Add] buttons in widget Needs review

Yes @johnv it's duplicated of this issue, and the fix it will cause the same issue if other modules add [Add] buttons with the same attribute
data-drupal-selector finish with add clear or copy.
I think it's better to wrap all operation in div with specific selector like that are sure that JS target only buttons added by the module.

Number 2 is fixed here https://git.drupalcode.org/project/easy_breadcrumb/-/merge_requests/99/d...
I moved the code from the hook to the class maybe need some optimisations.
I let you review the MR.

I just pushed first version of the merge in this branch
here is a draft MR https://git.drupalcode.org/project/easy_breadcrumb/-/merge_requests/99

Todo:

1. Maybe an Ajax button to update fieldSets of config when user check other entities
2. Move code from hook_system_breadcrumb_alter to EasyBreadcrumbBuilder, we need to adapt applies and build methods
3. Test that all features works together
4. Maybe rename configuration naming (value and checkbox not so clear)
5. Maybe add hook_update for people who has already the Dynamic breadcrumbs or block users to update to version that have already Dynamic breadcrumbs merged, and tell them to disable it and just update easy breadcrumbs it has already the DB

Thank you Greg,
Okay i will try this when i have some time.
I guess we still need to add the config of dynamic breadcrumbs to the EB form, like the both modules will have the configuration in the same place.

+1 for the merge.