🇫🇷France @berramou

It seems good idea @spuky !

I will close this issue, since no one can reproduce it.
@e5sego feel free to create another issue if this occurred again.

Thank you @olivierh65, for the report and the MR
I want to test it but, i couldn't manage to get an API key, can you please give us steps how we can get an API key.
And it will be great if we could add a link to page documentation or steps in the api key description in the module.

Ah i don't have this error,
I guess it's better to create a new issue and make it a follow up to this one, and describe what Block Visibility Groups you have.

Where do you want to add this params ? can you give a link to a documentation how to add region to google maps ?

The version 2.2.2 working perfect for me using custom MAP.

Can you please provide steps to reproduce this issue ?
Anyone else facing this issue ?

I close this issue as fixed, since now the module propose a hook that let developers add their maps ✨ Add hook to give custom modules possibility to add other maps to default list. Fixed

Fixed in 2.2.2 →

Thank you @ankitv18 fro your contribution!

berramou → made their first commit to this issue’s fork.

Here is a patch needs reviews, the idea is to filter out the contexts without value before passing them to applyContextMapping.

Here is how to reproduce this error:

1. Create a Visibility Group with at least two condition one Request Path and another one with Content type
2. Apply this group to a block
3. Go to any pages that's not a node page or page listed in request path condition

You will have this error, it seems that the node (maybe any other entity type) it's required in the context, it seems that module evaluate the condition even if the context don't have value.

this line of code who throw the exception
$this->contextHandler->applyContextMapping($condition, $contexts);

because the $contexts will have ["@node.node_route_context:node" => "contextValue":protected]=> NULL ]

I'm getting the same error

Closing this issue as won't fix, because this module will not be needed for Drupal 11, the issue ✨ Image entities/fields embedded using Entity Embed cannot be linked in CKEditor Fixed has been fixed.

berramou → created an issue.

wells → credited berramou → .

Thank you @andileco for you contribution,
I will work on this when i have some time!

Still TODO:

1. Add tests for dynamic breadcrumbs part

I just added the check to apply dynamic breadcrumbs only if there is an entity types configured.
TODO:

1. Add tests for dynamic breadcrumbs part
2. Add AJAX to the Entity Types configuration to display the appropriate settings.
3. Adapt dynamic breadcrumb hook_requirements set the right version instead of 2.0.6

Yes you are right we need to check if entity_types not configured no need to apply DB build.
Thank you for the fix i accept you suggested changes.

To test dynamic breadcrumbs,
you need to create two content of the selected bundle i will give an example with article content

1. Configure dynamic breadcrumbs for article for example article - [current-date:html_date]
2. Create first article for example Article test1 with alias /article-1
3. Create a second article for example Article test2 with alias /article-1/article-2
4. Now if you visit the article test2 you will see that the breadcrumbs like this Home > article - 2024-08-15 > Article 2

This is what dynamic breadcrumbs does, it changes the generated part of the configured content in breadcrumb.

Hello @spuky thank you for the tests and review,
It's working in my local env, how did you test, how can i reproduce the warning ?

Thank you @spuky, i created an issue ✨ Merge Dynamic breadcrumb Active

berramou → created an issue.

Patch adapted to version 3.0.0-rc20.

Thank you @spuky yes it fixed the 3 failing unit tests.
@Greg Boggs if you have some time to review the MR, and maybe add more tests for dynamic breadcrumb ?

Yes still don't have maintainer access.

Thank you @ressa, for reporting this.
And yes there is a problem with the ERSI Ocean/World Ocean Base that code generate an html ID 'esri-ocean/world_ocean_base' which is not good.

I close this issue as won't fix, because it's a minor feature few people will need it.

I guess it's related to #3451510 can anyone reproduce this bug on 2.2 versions ?

It works for me without implementation __wakeup(), it doesn't seems necessary because the parent BackendPluginBase already implementing __wakeup method.

  /**
   * Implements the magic __wakeup() method.
   *
   * Reloads the server entity.
   */
  public function __wakeup(): void {
    parent::__wakeup();

    if ($this->serverId) {
      $this->server = Server::load($this->serverId);
      $this->serverId = NULL;
    }
  }

Hello,

yes this is still an issue on Drupal 10.2.X with the 8.x-2.0-beta6 version.
I attach new patch that fix this issue.

I attach a patch that fix this issue.

Ah sorry my bad, it's D7 issue you still have the issue with version 7.x-1.17 ?

Hello @alekas thank you for your report.

Is this behavior normal for this filter?

Yes this module allows you search in all content event if they are in the past, your issue is not related to this module.
You need to add another condition to your views, for example in the upcoming events view should ad Filter criteria the pull only content with date after today and the do the same with Past events.
If you do so and place the filter in your views will give you the right results.

You are welcome @ressa, thank you for your contribution.
Yes he can make me maintainer.

Thank you @paulvandenburg for reporting this, and for the issue.
You can still reproduce this issue with new releases 2.2 ?

Anyone can reproduce this issue ?

Yes you are right @ressa it should be 2.2-dev, i just created a new branch 2.2.x but i can't make it default branch i don't have this permission.
Thank you @demonde for your report i will publish new release 2.2.1 today.

Hello,
Thank you for reporting this, yes you are right it works better with tile.openstreetmap.de/{z}/{x}/{y}.png
with the actual code some it's missing graphics.

I will let this issue open for some time if anyone face the same issue or if you could give more details how to reproduce this.

I can't reproduce this error, it seems not related to this module.

berramou → created an issue.

Thank you @ressa for your help done, i added credit in those two issues.

New release 2.2.0 has been created https://www.drupal.org/project/leaflet_more_maps/releases/2.2.0 → 🎉
Thank you all for your work!