🇧🇪Belgium @p-neyens

Hi,

I added the patch => Works fine but the message wasn't translatable. So i pushed new code to make this possible.

p-neyens → made their first commit to this issue’s fork.

p-neyens → created an issue.

+1

New patch with change that the $query_params always exists.

I provided a new patch that also remove also AJAX related query parameters and q param from the link.
Identical to the logic provided here →

Maybe a alternative approach would be to use the url_processor to build urls?

Updated patch #31which breaks facet summary (ajax) to work with the changes of #3052574-275
I don't started from #32 @waropd because issue https://www.drupal.org/project/facets/issues/3254732 🐛 Facets summary compatibility with views_ajax_history Needs review is fixed.

changed lines:

if (updateFacetsSummaryBlock() && (facetId === 'facets_summary_ajax')) {
  $(once(facetId, '[data-drupal-facets-summary-id=' + facetSettings.facets_summary_id + '] ul li')).click(function (e) {
    e.preventDefault();
    var facetLink = $(this).find('a');
    updateFacetsView(facetLink.attr('href'), current_dom_id, view_path);
  });
}

becomes

else if (facetId == 'facets_summary_ajax_summary' || facetId == 'facets_summary_ajax_summary_count') {
    if (updateFacetsSummaryBlock()) {
       $(once('data-drupal-facets-summary-id', '[data-drupal-facets-summary-id=' + facetSettings.facets_summary_id + ']')).children('ul').children('li').click(function (e) {
          e.preventDefault();
          var facetLink = $(this).find('a');
          updateFacetsView(facetLink, current_dom_id, view_path);
       });
   }
}

If we specify to also pass the facets data then it seems better to also provide the serach_results as an empty array.

Result:

• If we don't have the ‘show_facets’ setting enabled, we get back an empty array and when results are available a filled array.
• If we do have the ‘show_facets’ setting enabled, we get back an array that also contains the search_results so it is consistent.

Yes, I set up 3 term facets with the facet exposed filters setup as described here https://project.pages.drupalcode.org/facets/exposed_filters/

Hi @aaronbauman,

I tried to reproduce your problem. but with no results. Do you perhaps have more info of the specific setup.

Kind regards,

p-neyens → made their first commit to this issue’s fork.

p-neyens → created an issue.

p-neyens → created an issue.

New patch starting from comment 42 ✨ Exposed forms in a block are not currently updated when Ajax filtering is executed Needs work but with adding the missing use.

Error: Class "Drupal\views\Controller\RenderContext" not found in Drupal\views\Controller\ViewAjaxController->ajaxView() (regel 222 van /var/app/web/core/modules/views/src/Controller/ViewAjaxController.php).
Error: Class "Drupal\views\Controller\BubbleableMetadata" not found in Drupal\views\Controller\ViewAjaxController->ajaxView()

Here a patch for D10.2.5 with a fix for "Warning: Undefined array key "#delta" in Drupal\Core\Field\WidgetBase::addMoreAjax() (regel 340 van /var/www/html/core/lib/Drupal/Core/Field/WidgetBase.php)"

This is a patch for 10.2.x version.

Also a patch that contains only the unset of the ajax_page_state query param.

The new patch is a combination of patch 64 ✨ Add option to show current search string in facet summary Needs work with the unset of the ajax_page_state uery param.

p-neyens → created an issue. See original summary → .

p-neyens → created an issue.

p-neyens → made their first commit to this issue’s fork.

p-neyens → made their first commit to this issue’s fork.

p-neyens → created an issue.

p-neyens → created an issue.

I switch back to version 8.x-1.x: that use the menu_ui.

p-neyens → created an issue.

p-neyens → created an issue.

p-neyens → created an issue.

here the patch to easily use with cweagans/composer-patches

p-neyens → created an issue.

p-neyens → created an issue.

p-neyens → created an issue.

reroll of #182 add the missing facets_preprocess_block hook from #174

p-neyens → created an issue.

Don't translate the message when adding the constraint. This will be done in the validate method of UniqueFieldValueValidator

Fix TypeError: Cannot access offset of type string on string in Drupal\content_browser\Plugin\Block\ContentEmbedBlock->blockForm()

This is indeed the correct solution. It also fix my issue.

p-neyens → created an issue.

https://www.drupal.org/project/seven/issues/3304752 🐛 Icons are missing Fixed

p-neyens → created an issue.

Can we reopen the ticket because the change to use the drupal ->toUrl() call triggers early rendering. (For more info on that read this article https://www.lullabot.com/articles/early-rendering-a-lesson-in-debugging-...)

p-neyens → made their first commit to this issue’s fork.

p-neyens → made their first commit to this issue’s fork.

p-neyens → made their first commit to this issue’s fork.

Already fixed in https://www.drupal.org/project/webform/issues/3293182 →

p-neyens → created an issue.

Patch for v2.0.1

p-neyens → created an issue. See original summary → .

Hi Nigel,

The committed patch isn't correct. It add an extra param to the route but it isn't used.

I also think it isn't the correct patch.
I followed the steps to reproduce the issue described above and only with the patch of cgoffin → it works.