- Issue created by @BramDriesen
- Assigned to akshaydalvi212
- 🇮🇳India akshaydalvi212
hey
I will find the replacement for decodeIdToken() method and provide the patch.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
@akshaydalvi212 Thanks!
I had a quick glance through the commit history and couldn't find what the logic originally was. I didn't spend too much time on it either so could be I just skipped the correct commit.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 7:37am 16 March 2023 - 🇮🇳India akshaydalvi212
Replaced the decodeIdToken() with decodeToken() and fixed the issue.
kindly review. - Status changed to Needs work
almost 2 years ago 7:58am 16 March 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
+++ b/keycloak.module @@ -220,7 +221,7 @@ function keycloak_openid_connect_post_authorize(UserInterface $account, array $c + $user_data = $client->OpenIdConnect::decodeToken($tokens['id_token']);
I don't think this can work. I think $client-> needs to be removed.
I also couldn't find the declaration of the decodeToken method in the class you are referencing. I do see a parseToken method.
And finally, instead of calling the method statically, it would make more sense to use the Service (openid_connect.openid_connect).
- First commit to issue fork.
- @p-neyens opened merge request.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
This got fixed in 🐛 Keycloak url not getting concatenated correctly Fixed
- Status changed to Fixed
over 1 year ago 6:51pm 28 March 2023 -
BramDriesen →
committed a80339b4 on 2.2.x authored by
p-neyens →
Issue #3348290 by p-neyens, BramDriesen: Call to undeclared method "...
-
BramDriesen →
committed a80339b4 on 2.2.x authored by
p-neyens →
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I was not paying attention. Re-opened and merged! Thanks all.
- @p-neyens opened merge request.
-
BramDriesen →
committed 064bdeab on 2.2.x authored by
p-neyens →
Issue #3348290 by p-neyens, BramDriesen: Call to undeclared method "...
-
BramDriesen →
committed 064bdeab on 2.2.x authored by
p-neyens →
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Last commit fixed the revert which happened on the other ticket (parent).
Automatically closed - issue fixed for 2 weeks with no activity.